From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE11123C397 for ; Tue, 5 Aug 2025 10:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754390670; cv=none; b=eCUC5IK1ddqHy993EMNXeNaqziQWTKMASkXxF7NuD5nuHdQcYw3wm//f3eettVeaGiC2WX2gzKh6mUaY5HoSNJvVlbdc2GGvn7QnaJaz+o0D9cv45xV5kjzNt/WEX8zRCKboYZvE4XNXNopr5bk9622DlWOZ5T8i1rTRIzXbtXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754390670; c=relaxed/simple; bh=xMNNkjuSH+3HYtbiIl/ollmFmRenFvaiHSjwqXnvo7k=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NugdJyP7hFlSDvxMTgVDQwdP19Y3XvZtHsxKa96yDxDB/ggVTnXJhqUp8Ss6l6+PUkiXXYcp0/4/VNZQAJxARO3+qyalC0KrotLTqWtxXLxus6I6urRwbOxZOQ0Tlss4KNDtTr/oR80pU/2wlaZWxFNpPBtEbMENZsE+bQuqppU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TZxJetnW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TZxJetnW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5756OOl8021762 for ; Tue, 5 Aug 2025 10:44:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=rxC9YEhF7HAygPUX1sY/MO8v Fp8TOmYu1uxrDnl8C1s=; b=TZxJetnW9Ot2Rc8/0i+mRkOdGAqLaeIOByVf09NP Xg0QjaSfXfPnI/SHy2TUb3bjnW+G9TGKzi7vSxIbpLM7sNFjHGhLwWGXBmV8MnWU VlrHfXLaU0wFsSu+nRbx0f3yxHpYvNlb9ycMKGcVoV4NTkvyOKD7eu4/0NnvNF2g lxOml6dn/SWpRVxG5c1lhyyByHlsKtIHSVA0vmTMVSNTUsAMqZcAOgx/KzFag8BN jlUeP6wk6zLu/pCB5r+yBcu4MRWEz6UGMJ9B80HPt7p9VT0G+CLjPIb7D3HlsyTv fmMr8DXKwnBJ4yBngQhZk7dYD/YimVORxcII3Xtr0D5UNA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 489byc85jf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 05 Aug 2025 10:44:27 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4b0680f6270so48045321cf.3 for ; Tue, 05 Aug 2025 03:44:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754390666; x=1754995466; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rxC9YEhF7HAygPUX1sY/MO8vFp8TOmYu1uxrDnl8C1s=; b=bLq4hQVPACVmUa0AsPOA3ZuE1T+UsyCJL9U5sZBsraFN1ID1MR4024Bw3nu41rjXlm ZSRSGBDGX9oPjS/xO/Bd+nWIZE30GDa+BddvRaLRQe4PNIzaj4kn4A1Ov15ZGlY7aynz N46fr6jzOKCe1OM1VXvfxt6zN4M8Lx4XcY7+jFD6uCF1AEsHNYMGt93d4tuM0OVLtIPo IPoSvIbwjYIFiMvLZdVmp0s1/4hosTvshnylnCxGt4POvCcs8dcZPH0/5jHf89gQszCa iwjfTgkr7qxil1953Sl75m2XTgW10gD57+T5NiQoEHWUnI70Hn/i9MJ2wGetHdmqsT36 zSvw== X-Forwarded-Encrypted: i=1; AJvYcCVd0VHOYZDdmYsTW31PuQYWajxQ1T+C8GYTzE+89Eu8oktGguE9FZYC2TyXv6Y6Z7zqCMp5up2WVclJ@vger.kernel.org X-Gm-Message-State: AOJu0YwBLYkUgQtz5dPoPXU+hX8uYz9B4JIOosk9xvU0s7dT+m+kRTD/ ttfyEG7gtyZpIRbBBMkRz4FDRSaPPEoi7M0ZiRP5Iaix8tQJlzarqyJC7gk+7Z0B6BP8qf+HPPl AnvLEK+pV1IMPIFFrPqo6WV0t9iANsOj92u0WDWnMb43b/mTrbu+1GtYNVX/NmbYK X-Gm-Gg: ASbGncvfs8IH0sYcsuRe+2o8wYEzklcXXhnmE6iAFfRLFa2Hsow+QXlIcLmsivpl75E mm+VTHVL+xOi6uZVpTO5rYuhbqddZa5nu4gyU3Sxbu666LY02JNetLelAV6ZhQGS6qNmhC2sX5b tAPWsJfG2vGmYn2rXVQFvYT7JWWxbJic/P4RU9ewhsbfZ7egplOoZQnTpRboa0JhbM7Pgs9zm4o WjSetguMLLXAUF3aZcJ+O+4Qw7cYcRa4q1LyiXRyraC+dNcZ5IOAsS7Z6ZjN4PU0X6E2WSXJmKJ zFdra1kGggS3n00c123ykXngBzSHdDm/ePZVvOvHWjtrz2HW5XKzp7Ix8p4QiC3fZRQslg== X-Received: by 2002:a05:6214:dab:b0:705:816:6179 with SMTP id 6a1803df08f44-709362d810cmr182505066d6.38.1754390666038; Tue, 05 Aug 2025 03:44:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFP9CTM5JXUtM9Z6l08Gil36MWqvJFmbSlsYeDtXThdsrHNGHHg9GP8BD/fDSOt/tjYpA41+w== X-Received: by 2002:a05:6214:dab:b0:705:816:6179 with SMTP id 6a1803df08f44-709362d810cmr182504726d6.38.1754390665534; Tue, 05 Aug 2025 03:44:25 -0700 (PDT) Received: from trex (205.red-83-60-94.dynamicip.rima-tde.net. [83.60.94.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459d7d722dcsm83892505e9.24.2025.08.05.03.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 03:44:25 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Tue, 5 Aug 2025 12:44:23 +0200 To: Dmitry Baryshkov Cc: Jorge Ramirez-Ortiz , bryan.odonoghue@linaro.org, quic_dikshita@quicinc.com, quic_vgarodia@quicinc.com, konradybcio@kernel.org, krzk+dt@kernel.org, mchehab@kernel.org, conor+dt@kernel.org, andersson@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 5/7] media: venus: core: Add qcm2290 DT compatible and resource data Message-ID: References: <20250805064430.782201-1-jorge.ramirez@oss.qualcomm.com> <20250805064430.782201-6-jorge.ramirez@oss.qualcomm.com> <4chbcvub4scnv4jxjaagbswl74tz4ygovn3vhktfodakysbgy3@kukktkwd2zsr> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4chbcvub4scnv4jxjaagbswl74tz4ygovn3vhktfodakysbgy3@kukktkwd2zsr> X-Proofpoint-ORIG-GUID: LYo-XXRd5jDEmbrAThWrV1vNqmAN35L7 X-Authority-Analysis: v=2.4 cv=Y6D4sgeN c=1 sm=1 tr=0 ts=6891e08b cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=Rr2dNH5/fcnoRoBmcVUeRg==:17 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=COk6AnOGAAAA:8 a=KpVMlk9tmVbli1cETwMA:9 a=CjuIK1q_8ugA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: LYo-XXRd5jDEmbrAThWrV1vNqmAN35L7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA1MDA3NiBTYWx0ZWRfX8L94G+Bq0m5O VgWN03FcUn1RVKPziJRYRo7yPVkfJUHjOo44nXFMhCji1hC9pRZpMBnI/LCYe+5OukPYokxaQ67 nwkaEbEhtn5/tohm+KKoGJUWtMJkBv2yWFbRrIZuJB2wyMHtU25UNxhQvG7GroJUgQiQKJrqLBn tE5YglkPThuEonFyRRctQ8di3OXIU+7gGKrNM+SJ3RZPVnR3cSwW132IEebFEwKLP8Fht9U2RLS Lw/0V9prtaQ5efwqprmGl4O5RUJmFAY6BcaCKvafx/2nGjp800Wjur8vGMBTOb/F0ISPFwUJULy rTLg3TTdlBjd/7uDOXMnl+pNOEGG79u92l6fHP0/qmO2KnvjJ6wBh/yNdDeaSFcMyYfoXjCu9os MY3h4mHs7/NWthbYj8Tz7mi4Y+HboiQWpAouUXDQOIvvWKQnVCUwJeOtEZdn+j+8FL8PDZs9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-05_03,2025-08-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508050076 On 05/08/25 13:04:50, Dmitry Baryshkov wrote: > On Tue, Aug 05, 2025 at 08:44:28AM +0200, Jorge Ramirez-Ortiz wrote: > > Add a qcm2290 compatible binding to the Cenus core. > > > > The maximum concurrency is video decode at 1920x1080 (FullHD) with video > > encode at 1280x720 (HD). > > > > The driver is not available to firmware versions below 6.0.55 due to an > > internal requirement for secure buffers. > > > > The bandwidth tables incorporate a conservative safety margin to ensure > > stability under peak DDR and interconnect load conditions. > > > > Co-developed-by: Loic Poulain > > Signed-off-by: Loic Poulain > > Signed-off-by: Jorge Ramirez-Ortiz > > Reviewed-by: Bryan O'Donoghue > > Reviewed-by: Dikshita Agarwal > > --- > > drivers/media/platform/qcom/venus/core.c | 50 ++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > > index adc38fbc9d79..753a16f53622 100644 > > --- a/drivers/media/platform/qcom/venus/core.c > > +++ b/drivers/media/platform/qcom/venus/core.c > > @@ -1070,6 +1070,55 @@ static const struct venus_resources sc7280_res = { > > .enc_nodename = "video-encoder", > > }; > > > > +static const struct bw_tbl qcm2290_bw_table_dec[] = { > > + { 352800, 597000, 0, 746000, 0 }, /* 1080p@30 + 720p@30 */ > > + { 244800, 413000, 0, 516000, 0 }, /* 1080p@30 */ > > + { 216000, 364000, 0, 454000, 0 }, /* 720p@60 */ > > + { 108000, 182000, 0, 227000, 0 }, /* 720p@30 */ > > +}; > > + > > +static const struct bw_tbl qcm2290_bw_table_enc[] = { > > + { 352800, 396000, 0, 0, 0 }, /* 1080p@30 + 720p@30 */ > > + { 244800, 275000, 0, 0, 0 }, /* 1080p@30 */ > > + { 216000, 242000, 0, 0, 0 }, /* 720p@60 */ > > + { 108000, 121000, 0, 0, 0 }, /* 720p@30 */ > > +}; > > + > > +static const struct firmware_version min_fw = { > > + .major = 6, .minor = 0, .rev = 55, > > +}; > > This will make venus driver error out with the firmware which is > available in Debian trixie (and possibly other distributions). If I > remember correctly, the driver can work with that firmware with the > limited functionality. Can we please support that instead of erroring > out completely? yes, in V7 I did implement this functionality plus a fix for EOS handling (broken in pre 6.0.55 firmwares). This added some complexity to the driver. And so in internal discussions it was agreed that it was not worth to carry it and that it should be dropped. I'll let Vikash and Bryan comment on the decision. > > > @@ -1080,6 +1129,7 @@ static const struct of_device_id venus_dt_match[] = { > > { .compatible = "qcom,sc7180-venus", .data = &sc7180_res, }, > > { .compatible = "qcom,sc7280-venus", .data = &sc7280_res, }, > > { .compatible = "qcom,sm8250-venus", .data = &sm8250_res, }, > > + { .compatible = "qcom,qcm2290-venus", .data = &qcm2290_res, }, > > Please keep the table sorted. argh...sure > > > { } > > }; > > MODULE_DEVICE_TABLE(of, venus_dt_match); > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry