From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] iio: adc: ad7476: Simplify scale handling
Date: Wed, 6 Aug 2025 23:21:09 +0300 [thread overview]
Message-ID: <aJO5NRESqxFfxi3s@smile.fi.intel.com> (raw)
In-Reply-To: <645ac6fb917e12db6cdc0fc343487531f61c176a.1754463393.git.mazziesaccount@gmail.com>
On Wed, Aug 06, 2025 at 10:03:07AM +0300, Matti Vaittinen wrote:
> The ad7476 driver supports variants with different amount of supply
> regulators. On some variants there is only VCC, which is used as a
> reference voltage. Others have separate VREF regulator, and some rely on
> internal VREF. Some have both internal VREF and option to connect
> external one.
>
> The ad7476 driver reads the regulator voltage only when the user asks to
> get the scale. This means the driver needs to do some dancing while
> picking the correct reference regulator (or internal reference), and
> store it for the later use.
> According to the discussion:
> https://lore.kernel.org/linux-iio/20250331122247.05c6b09d@jic23-huawei/
This may be made a Link tag
According to the discussion [1] ...
...
Link: $URL #1
> variable voltage references are rare, making it hard to justify the
> added complexity for supporting those.
>
> Drop the support for the variable voltage references and simplify things
> by using the managed regulator get and enable interfaces.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-06 20:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 7:02 [PATCH 0/8] Support ROHM BD79105 ADC Matti Vaittinen
2025-08-06 7:02 ` [PATCH 1/8] iio: adc: ad7476: Simplify chip type detection Matti Vaittinen
2025-08-06 7:03 ` [PATCH 2/8] iio: adc: ad7476: Simplify scale handling Matti Vaittinen
2025-08-06 20:21 ` Andy Shevchenko [this message]
2025-08-07 5:43 ` Matti Vaittinen
2025-08-06 7:03 ` [PATCH 3/8] iio: adc: ad7476: Use mV for internal reference Matti Vaittinen
2025-08-06 7:03 ` [PATCH 4/8] iio: adc: ad7476: Use correct channel for bit info Matti Vaittinen
2025-08-06 15:04 ` Jonathan Cameron
2025-08-07 6:46 ` Matti Vaittinen
2025-08-06 7:04 ` [PATCH 5/8] iio: adc: ad7476: Conditionally call convstart Matti Vaittinen
2025-08-06 7:04 ` [PATCH 6/8] dt-bindings: iio: adc: ad7476: Add ROHM bd79105 Matti Vaittinen
2025-08-06 15:15 ` David Lechner
2025-08-07 7:14 ` Matti Vaittinen
2025-08-06 7:04 ` [PATCH 7/8] iio: adc: ad7476: Support ROHM BD79105 Matti Vaittinen
2025-08-06 15:23 ` David Lechner
2025-08-07 7:27 ` Matti Vaittinen
2025-08-06 20:26 ` Andy Shevchenko
2025-08-07 7:30 ` Matti Vaittinen
2025-08-07 21:08 ` Andy Shevchenko
2025-08-06 7:04 ` [PATCH 8/8] MAINTAINERS: A driver for simple 1-channel SPI ADCs Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJO5NRESqxFfxi3s@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).