RE: [PATCH v3 net-next 01/15] dt-bindings: ptp: add NETC Timer PTP clock

Wei Fang
2025-08-15T02:05:15Z

> > +title: NXP NETC V4 Timer PTP clock
> > +
> > +description:
> > + NETC V4 Timer provides current time with nanosecond resolution, precise
> > + periodic pulse, pulse on timeout (alarm), and time capture on external
> > + pulse support. And it supports time synchronization as required for
> > + IEEE 1588 and IEEE 802.1AS-2020.
> > +
> > +maintainers:
> > + - Wei Fang <wei.fang@nxp.com>
> > + - Clark Wang <xiaoning.wang@nxp.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - pci1131,ee02
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > + description:
> > + The reference clock of NETC Timer, if not present, indicates that
> > + the system clock of NETC IP is selected as the reference clock.
> > +
> > + clock-names:
> > + description:
> > + The "ccm_timer" means the reference clock comes from CCM of SoC.
> > + The "ext_1588" means the reference clock comes from external IO
> > + pins.
> > + enum:
> > + - ccm_timer
>
> You should name here how the input pin is called, not the source. Pin is
> "ref"?
>
> > + - ext_1588
>
> This should be just "ext"? We probably talked about this, but this feels
> like you describe one input in different ways.

The NETC Timer has 3 reference clock sources, "ccm_timer" and "ext_1588"
are two of them, but the clock mux is inside the IP, so we want to set this
mux to select the desired clock source by parsing the clock name. This
method is the same as https://lore.kernel.org/imx/20250403103346.3064895-2-ciprianmarian.costea@oss.nxp.com/

>
> You will get the same questions in the future, if commit msg does not
> reflect previous talks.

Okay, I will add more information to the description or the commit message

>
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +allOf:
> > + - $ref: /schemas/pci/pci-device.yaml
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + pcie {
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > +
> > + ethernet@18,0 {
>
> That's rather timer or ptp-timer or your binding is incorrect. Please
> describe COMPLETE device in your binding.
>
> > + compatible = "pci1131,ee02";
> > + reg = <0x00c000 0 0 0 0>;
>
> Best regards,
> Krzysztof