Re: [PATCH v3 net-next 03/15] dt-bindings: net: add an example for ENETC v4

Frank Li
2025-08-13T15:10:31Z

On Wed, Aug 13, 2025 at 01:38:55AM +0000, Wei Fang wrote:
> > On Tue, Aug 12, 2025 at 05:46:22PM +0800, Wei Fang wrote:
> > > Add a DT node example for ENETC v4 device.
> >
> > Not sure why need add examples here? Any big difference with existed
> > example?
> >
>
> For enetc v4, we have added clocks, and it also supports ptp-timer
> property, these are different from enetc v1, so I think it is better to
> add an example for v4.

If there are not big change, needn't duplicate one example at yaml file,
the content should be in dts file already. Pass DTB_CHECK should be okay.

Frank
>
> >
> > >
> > > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > >
> > > ---
> > > v2 changes:
> > > new patch
> > > v3 changes:
> > > 1. Rename the subject
> > > 2. Remove nxp,netc-timer property and use ptp-timer in the example
> > > ---
> > > .../devicetree/bindings/net/fsl,enetc.yaml | 15 +++++++++++++++
> > > 1 file changed, 15 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > index ca70f0050171..a545b54c9e5d 100644
> > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > @@ -86,3 +86,18 @@ examples:
> > > };
> > > };
> > > };
> > > + - |
> > > + pcie {
> > > + #address-cells = <3>;
> > > + #size-cells = <2>;
> > > +
> > > + ethernet@0,0 {
> > > + compatible = "pci1131,e101";
> > > + reg = <0x000000 0 0 0 0>;
> > > + clocks = <&scmi_clk 102>;
> > > + clock-names = "ref";
> > > + phy-handle = <&ethphy0>;
> > > + phy-mode = "rgmii-id";
> > > + ptp-timer = <&netc_timer>;
> > > + };
> > > + };
> > > --
> > > 2.34.1
> > >