From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A4822701CC for ; Thu, 21 Aug 2025 15:20:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755789617; cv=none; b=HTOTTF+MepttUxUFQWXHZ9qpdf883rqt8TQfm2w/ejAZluhLJqFYxv6ASV1/vdaqIBj9CnRs5bU8GXPivU5sFBDj7Wam9+EqBGBzXI4HOZAloB6POpc+Ohx8HHkukrCc6UJqseVJMB6M7IM5Vq0BPg1KndCd7BaqG010Y1oU6No= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755789617; c=relaxed/simple; bh=F/EjgN8PLsBzT6JEQmm+8aj3BN2j2mJJkwSmhkAXh0I=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=meXSISGT++Ih18/BtifnZ7Ji9EyAQFg1AQFUf3WHJ7VPQIXuVl/uQZe4g9dYaSFGgjSxLkUyKgv+Ka4gKAFMR5i0Suoa+3L0t24t1tlAm+AcfGAlSyyb2Wr6naQVto38h9u63RmqfG+IJBRujdWrWuMgTDDJOa6HYt6RgZsSqeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dDcO1J2S; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dDcO1J2S" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-3b9dc52c430so826377f8f.0 for ; Thu, 21 Aug 2025 08:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1755789613; x=1756394413; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=xNeH8jwIaMIahWPVnKl5loQQejVbwxs7rBb60S32DBI=; b=dDcO1J2Sw9jvCB6JCNEkNmbqBmhGzvnkmZi2po8Yyp7odu3Wvb39Oh7V5Q9nVPVBa8 OMDf21pkw+c6hIBWwnzgAubteTV8449tt+wSXY84hzK57qhMz5aWDuURuJfdCOODKbmr jB/wtQltgD4pWle0zAf+fXQQM5SmHyCckKFLeQJmHhLoi6F90wdiM0cQqczQww1TrL6n HRogoYhTXEs3jWXMJH10dL4xikiGzOBTbLF+bdaaUWdi3lGQqtZSOpvNTRx/dkfEQOno SmsykhptCJrk7813Ygs57sbu+ef+DXlTEeb5hDPTUAUwFher+CwM2l/mWiP2cpHg8jxQ U+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755789613; x=1756394413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xNeH8jwIaMIahWPVnKl5loQQejVbwxs7rBb60S32DBI=; b=b5IdZ5VPDlQ+xfbZL2oWGB8dsnG8wWVpl7RKW9BcB6c8xLklEz7UMi5S5vGPPn6/4L TlDLo2M+kb6fvz67KX/jWASWtlKl3uta47AUlFuhOVxFBNgnef7sY1bGjweUNjtktW5i aqZ0hUv/VGqfSH9sT8vZXMvN52Z8u6m1C71J0MQURRSrGRhXCo8pGSvD3B9iSx7yG97A psSLmFEF++qG6iOFTagwQEsLYlQ5bA65BRPvFkTcLhmEi/3kkjzlv6X0yIUD+p6BPcL8 QLCjPCe3yL1NCCNjdltuhfzMcyBxmANT0VRz0hFQvKZzP3rIGH4own5GtoPlUuOvcr3q j32g== X-Forwarded-Encrypted: i=1; AJvYcCXDGyhK4bc6h35JJirFKY1HQP6WeqWXnZEI59cpUoOsqT2/rFFccTv2wEWuoG2e/RxaSh+gJmzBVjKg@vger.kernel.org X-Gm-Message-State: AOJu0YzCTNqDlWzEICEZCEP9YSsAZk+TnInqKd71W5AVGqMsAERcdVb/ sZI0FhK1LwEoJQWqLMnbaX/6oEqMcmEpZsH+eeM4ZYegKhUVE/3H76VUN8XcN8FpITk= X-Gm-Gg: ASbGnctrztM58a8ze4BWJUvQtDW+kUDvNEXZM/DxlILRcdlh4EG9+P5HHf/gbkrmXkn Zfpq0IKdVFN9u5Igu8+8Qlo4YhHa7MadcWw1qREEKEe/0GuoC4jSkRN9zJRSHSSTc2V+dtgSNLZ RuZfQT7QQn/2tpnXqQQZhxiZ2rJI9xKJ58pjiAgtU1ly7wRjmZKIBFJv+Vlw8ymtklAEthTwnUa 9xwJeeLH3sjDnrFLi3USEbFpa1JLDbG3ZtMT56T7OVfeoq2KeAa7DiZ9r4QYbjyuMYRzZom5tLv MaH/RGyzrXQb99yaxrX678deVi6ll731KcREj5NetpvmMsb6JASaRbkP2V2k6ap2557ZqQspPg6 s0Um+1aUfMVzjJOYAK3cd0ePO1hj2BHD+F/4KiGBeCyUDIQozPa7EtSb+QdeLof9G8QMd4wY= X-Google-Smtp-Source: AGHT+IHDN8OczdJt+JNi7lF2guoFhCWb2f4SvtjNNXIrg4sA//TwST6NTNw7zh3uRT3ZYvRmUOk3qA== X-Received: by 2002:a05:6000:288b:b0:3b8:893f:a17d with SMTP id ffacd0b85a97d-3c497274347mr2450727f8f.49.1755789613394; Thu, 21 Aug 2025 08:20:13 -0700 (PDT) Received: from localhost (host-79-36-0-44.retail.telecomitalia.it. [79.36.0.44]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70ba9077520sm105918256d6.21.2025.08.21.08.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 08:20:12 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 21 Aug 2025 17:22:04 +0200 To: Krzysztof Kozlowski Cc: Andrea della Porta , Jim Quinlan , Florian Fainelli , Broadcom internal kernel review list , Bjorn Helgaas , Lorenzo Pieralisi , kwilczynski@kernel.org, Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iivanov@suse.de, svarbanov@suse.de, mbrugger@suse.com, Jonathan Bell , Phil Elwell , kernel test robot Subject: Re: [PATCH] dt-bindings: pci: brcmstb: Add rp1-nexus node to fix DTC warning Message-ID: References: <20250812085037.13517-1-andrea.porta@suse.com> <4fee3870-f9d5-48e3-a5be-6df581d3e296@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4fee3870-f9d5-48e3-a5be-6df581d3e296@kernel.org> Hi Krzysztof, On 10:55 Tue 12 Aug , Krzysztof Kozlowski wrote: > On 12/08/2025 10:50, Andrea della Porta wrote: > > The devicetree compiler is complaining as follows: > > > > arch/arm64/boot/dts/broadcom/rp1-nexus.dtsi:3.11-14.3: Warning (unit_address_vs_reg): /axi/pcie@1000120000/rp1_nexus: node has a reg or ranges property, but no unit name > > /home/andrea/linux-torvalds/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@1000120000: Unevaluated properties are not allowed ('rp1_nexus' was unexpected) > > Please trim the paths. Ack. > > > > > Add the optional node that fix this to the DT binding. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202506041952.baJDYBT4-lkp@intel.com/ > > Signed-off-by: Andrea della Porta > > --- > > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > index 812ef5957cfc..7d8ba920b652 100644 > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > @@ -126,6 +126,15 @@ required: > > allOf: > > - $ref: /schemas/pci/pci-host-bridge.yaml# > > - $ref: /schemas/interrupt-controller/msi-controller.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: brcm,bcm2712-pcie > > + then: > > + properties: > > + rp1_nexus: > > No, you cannot document post-factum... This does not follow DTS coding > style. I think I didn't catch what you mean here: would that mean that we cannot resolve that warning since we cannot add anything to the binding? Regarding rp1_nexus, you're right I guess it should be rp1-nexus as per DTS coding style. > > Also: > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation In this case it could be difficult: we need to search for a DT node starting from the DT root and using generic names like pci@0,0 or dev@0,0 could possibly led to conflicts with other peripherals. That's why I chose a specific name. Many thanks, Andrea > > ... and nodes should be anyway defined in top-level and only customized > per variant. I am surprised that DTS patch carries a reviewed tag, > because it was never checked/tested :/ > > > + $ref: /schemas/misc/pci1de4,1.yaml > > - if: > > properties: > > compatible: > > > Best regards, > Krzysztof