From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8DD42ECE95 for ; Mon, 8 Sep 2025 09:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757325436; cv=none; b=tB/JcIrOee2SjzWoko4Cv7EnBTUfm/YkYCOChc4+PhxZpK/JxqAWjgkefO106vT3MLdrTgXGXhbSOBLcH4RiHXBik67iB4fW4/AF0HhVWhA+vsOQpyM1hMnXMDUPgJi75uRpmC/am9YfU+9Edz7zc2IcABDNKgxkr+DkrmMFmss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757325436; c=relaxed/simple; bh=ykDwW2zeFPOxeLSt8zP2A70oe7r13xxaM+2jTS0GedI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l+NISsw8RReJuaKpF7WFkZzO4nYUmvK4SixSSC2H5wSfgCHXb78kArqZTKPFDPqLMNKIKZ6KWlFz1L1UucLHiQrD+ZsJZ1J98e0gHgEU+8FdlKA0Ue0O0KGV5Ueu+K2fBZ/qgVSh3wlUxYPK8VU2/8RIreL7TqcEAfemP/th5hY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BXiHg55P; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BXiHg55P" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b0415e03e25so584198166b.0 for ; Mon, 08 Sep 2025 02:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757325433; x=1757930233; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=haIepL/P0jz30Rbxjb0+O92cxvQz/NbDyzEigt7PcCU=; b=BXiHg55PXsd7pKl2UP/uL6qEdKOPNWomPgRlOWdq2sS0g9aXM2fTiSn0EVHCrFIjuT TKX9YtprnB4Zi1G7REEYpu+RoJMlguPrKiWZb0E2zUHQR3mwEpLOsglb4Fu9slNugeba nIH6SZJ/1aiw8pM1ZDda6ofh5RrFs1mFXsk+AdNnisyllcnx2uDngEwDQYnvsdL5AoJ8 iSuNnVpnSSRqjnJZDo0mfPuEAOAjB6xXKuxB6oQ7WifUVnvD4ZOLH0gDpERWr1Z4uPqm 2Bg84/j9cidiKwf/Rzk5yOUTbKt6HR4bh6oeT6Y87OoVaRR6Tin4bCS5Hbl+iYHyLTq4 tYQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757325433; x=1757930233; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=haIepL/P0jz30Rbxjb0+O92cxvQz/NbDyzEigt7PcCU=; b=C4RzMEfrfjnmXPr6xiRBCDrjU/jGQOf+6ED/Dg0cuukK0LWVAxS6CkXJXZkU5VJC5c VaycrP3VtWDCPhzk0WvbVxXeH22xxaM62u4cfCri6ilUnwGjR50ZugSuGeAl+NaYFMbu 9Y+QaDxkVCb883BYeo4+4yobGz0/0tmDMJFKzkDFFsD/oUxyImkBZAMfehu8Nc5DxODy JXciLaIyQtXk1Blv4yFmOInVXksbbjriQ0A4gBrMG17triY6XfeWEFyk6JOfgmQAHWJ1 nAcKZ/E6eHUJlEKL5IrgoF37mRJGq6dJGeKr0UnW4Pej780CbiJSPahNy3mIjTHCXkzH 3RoA== X-Forwarded-Encrypted: i=1; AJvYcCVlzADfd6oX4W2O9Vq1V8jjtqvgANV7pWnOjeJSM6AaETyKsr6wk4x/u0RiC6nCfIgnfgd5cRNuvawk@vger.kernel.org X-Gm-Message-State: AOJu0Yy00+Pk/y6rDVGgcoKF19lBxDdSS/m8THuvNOl9wVWnu62QJ50a rphPSWQ4gvQk4rSmyqrqQq3i/h1Fe49dPbdZ2E1DADfpMxFAWsyjiEnMwErwJjLjK10= X-Gm-Gg: ASbGncvbTkhzOxwC0Sd6m+O9c8E9x9hEDnnsp9nRIA90ObtKyyTkKhslDDrsZ0CSOYe /YetOTOCWTjIX5AiFdMNKwF+7fKejoTiJtkPhjMX1VBafgPr3W6dLJjn8rvLgsyRVYmbDEz2xBx dO1TSeAP1hIJDK4fr8XcVH/KpEM1RJYvUCaaKAYJCWcJ3FXfOCLf/qXSgF4yEIT9Y6IarR1rVZX iZoajNtljctKJEQS1fC5UJp9+gm8qJkxlNz9cW0pdM+QhtiI4o91Nr5kISZL9JaE5YhB5TrGKDN I/GHNCgDdlxYMQGVhloq2OKwhb3fXihWbTuuIO+9V/sitOX95ompR1zeqznkGsFPIFZgRjpK846 ep1lqoHO17NIwJh/ncx7Z7mvnDciTa2fQ X-Google-Smtp-Source: AGHT+IFYq6V5J5rXx5QgUvWRFIgmg8psdjbRgWhuE+b5PuhIMU45skzaKalA52LZGkVjQ1Apw2J66A== X-Received: by 2002:a17:906:d554:b0:b04:48c5:340 with SMTP id a640c23a62f3a-b04b13cd56amr710023166b.9.1757325432564; Mon, 08 Sep 2025 02:57:12 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:30:1f60:42e1:1e1b:d240]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b042523ee7bsm1959154266b.109.2025.09.08.02.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 02:57:12 -0700 (PDT) Date: Mon, 8 Sep 2025 11:57:07 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Konrad Dybcio , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Loic Poulain , Robert Foss , Andi Shyti , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH 4/5] i2c: qcom-cci: Add OPP table support and enforce FAST_PLUS requirements Message-ID: References: <20250904-topic-cci_updates-v1-0-d38559692703@oss.qualcomm.com> <20250904-topic-cci_updates-v1-4-d38559692703@oss.qualcomm.com> <5178a6b1-1b5a-40d9-af40-68ee13975509@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5178a6b1-1b5a-40d9-af40-68ee13975509@oss.qualcomm.com> On Mon, Sep 08, 2025 at 11:49:52AM +0200, Konrad Dybcio wrote: > On 9/8/25 10:46 AM, Stephan Gerhold wrote: > > On Mon, Sep 08, 2025 at 10:43:50AM +0200, Konrad Dybcio wrote: > >> On 9/8/25 10:36 AM, Stephan Gerhold wrote: > >>> On Thu, Sep 04, 2025 at 04:31:23PM +0200, Konrad Dybcio wrote: > >>>> From: Konrad Dybcio > >>>> > >>>> The CCI clock has voltage requirements, which need to be described > >>>> through an OPP table. > >>>> > >>>> The 1 MHz FAST_PLUS mode requires the CCI core clock runs at 37,5 MHz > >>>> (which is a value common across all SoCs), since it's not possible to > >>>> reach the required timings with the default 19.2 MHz rate. > >>>> > >>>> Address both issues by introducing an OPP table and using it to vote > >>>> for the faster rate. > >>>> > >>>> Signed-off-by: Konrad Dybcio > >>> > >>> Using an OPP table for a single static rate that remains the same over > >>> the whole lifetime of the driver feels like overkill to me. Couldn't you > >>> just put the "required-opps" directly into the device node so that it is > >>> automatically applied when the device goes in/out of runtime suspend? > >>> > >>> And since you need to make DT additions anyway, couldn't you just use > >>> "assigned-clock-rates" to avoid the need for a driver patch entirely? We > >>> use that for e.g. USB clocks as well. > >> > >> This is futureproofing, in case someone invents FastMode++ with a higher > >> dvfs requirement or for when the driver adds presets for a 19.2 MHz CCI > >> clock which would (marginally) decrease power consumption > >> > > > > If 19.2 MHz CCI clock is feasible and has lower voltage requirements, > > then I would expect a separate entry for 19.2 MHz in the OPP table of > > PATCH 5/5? The DT is unrelated to what functionality you implement in > > the driver, and that would make the OPP table look less useless. :-) > > The frequency plan for 8280 does not recommend any rate != 37.5 MHz > > For x1e80100 however, the lovsvs_d1 corner is recommended to be 30 > (yes, thirty) MHz, sourced from CAM_PLL8 for $reasons > The 37.5 MHz rate still exists on X1E I presume, or are you saying we need more changes to support those odd 30 MHz? Personally, I'm not fully convinced there is ever going to be a use case of someone using a "non-standard" frequency. Even if "FastMode++" is invented most devices will probably want to use it. And the voltage requirements we're currently talking about here like "low svs" during camera use cases are kind of negligible compared to others too. But I'm fine with either solution, just wanted to mention it. :D Thanks, Stephan