From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9D372FE04C for ; Mon, 1 Sep 2025 08:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756716493; cv=none; b=AqSre7TJ/dS910yoATJN6h1bQB3L3Hnr+Mpd70uoYx9D/vl936OlqqZoT3J03trBoLS4esoPlckhHLwj+4lipHE4j+5xYU/puJ/u+Bc1TB+1DPP2DW5h8iQvDZAM8j4hdLsII/r5a4bMSFguqI9XNmc9PAau3UExG/J2mwcN2Xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756716493; c=relaxed/simple; bh=neeT00/mxDswioH9iJwGYH9YEmmlx3hZdCS21iYzw3g=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dEkSL3r+M1BOt1vuaqejg+zIzSAfi2hPk5oGDmf/pWJAESiCav5X2xyDQvo1F5PFYriyXpy68IlA+e45+7xGcAdtenp9r5Od+di09VFoUU7hmC9/zguDFYITUYiFBG3ML+gUQ3/npUbxHsbTlkdkEkjgNiaABgd0spriY4OfvXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gOXNZahq; arc=none smtp.client-ip=209.85.208.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gOXNZahq" Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-61cc281171cso7004901a12.0 for ; Mon, 01 Sep 2025 01:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1756716490; x=1757321290; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=cPLbjAvQn0E2rMIx0xgjNyYjUFJLwi35g9A0s0bGBYk=; b=gOXNZahqc4/88gy+ti8ZsBT/gDP8IScW79A02vQySTEvTkgkWhboJ0UZhgwtGhkHCS +WXyPOxgv629OG/nV4FVSm2s1exIb85VgKs8eVp2mFOyLlVKjSJAu0LAv/7fzRP6IP8b GNN0CGGM1n+gwaBUfsVoCXszehz8TgkwXUnBe0AtjCwq+yflBoI1Y6LryduMoyv3Tw6U lGa1JusV4S+vJOdNl43twFNhlysjC91np9qSQiMgNYBE+L2D0rM1W7okfwjpnZvDFdiK 1BuImbzS1qJY5A3TIpRGmXtYMnebz0ZGrDzDeBOMFyO/U8S9zCol584WWBEMvVNtEhMt TqCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756716490; x=1757321290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cPLbjAvQn0E2rMIx0xgjNyYjUFJLwi35g9A0s0bGBYk=; b=iHdY3eU4RTx0pIB1lYv4GHO3B0dUQ5+zQ3tGk/hH+lM5f+DxDzSE3uDl+UCuVJSHYY 9lOcHCy72x8nMnhDh4CScaxmj59ak6IVhgCkCyPOXYahtjkiYZ6T4gcWKD5edcAAv7IO P83NgbDLcY8pADOeFFamWqGydKu8Q4VnJZQ9q1By608anfNNXyX0r84HFIMs4Z0b8dT5 IUwOmo8hqekUiw7JUA8//Iu/Dh/7Azjsa7R/7gcjuQK9vvDdIuW27f7ORi0GSLyT55Fj An5AEehLBwfrMnVVA8bnlgg/UX3sbdiROs8d3wpTFdCf9xvv2hJ3z/6gQkp/25Qa58oo /zjg== X-Forwarded-Encrypted: i=1; AJvYcCXmdUccD0dmLZT2livmFhpXZ/+yDX34yRWoZkblQ9wGI8jutXPTU8oUj/npgN/KBodvx5g76BKJOQDu@vger.kernel.org X-Gm-Message-State: AOJu0YwNpGSrjMw6uNp9duakBBFwn7a0yicJcV6fU0xSsBxsOI3+RCyH Bt3YWkcdRRp4MecMLhyMaZap7LvuLhf1hM/ibOinAeRTbvBIztPLNdvaiarvnSZBZPQ= X-Gm-Gg: ASbGnctIrPNoBVSjk7cPYs2GmGIHjgQglPkvIgztNaP/Mi5kKRq694IDYrY7p9jWpoe /y973cZ3j/v4eYFXxXK3S6ZjWq3za+KJNbc1ifXZ5epNZek9zmptE6Cv4Yo+8oKawhCjCW2IPaN NZaH8JBICYPxiLj4PTqgfVnfWZlkbi+ZiMiVou2OGzWS3zKmRWrQYxFoen67OEJw4BQO4u7RicQ qcoFzNnJYXghuLVbQzsxNaqOelcMAPMYdx/7mfZzrgM2F2MUrhBTNCdqC9MVuM7RC/34GKq2Tg8 ooiWjpIELXhFxrohEztwdZSp1omPE1x9AvMvaDRv74O2GZs9blbsVo2rT5Fde3kW2nVofqM2m0A IUfGNCkKqgszJIpEhaCcwcsam/mI3Row0fCSZwbwaY2qvLjPq2nD3FH8KyP4pf1fnQZH2XrbdDu kjVJnx0EfrSdpunN+A6xIj4boQ63o= X-Google-Smtp-Source: AGHT+IEQBUXzLByR1LDYkZW1JXKHq8+bGwyDWqHROpCdMH+jh7ytpsNxmNwRf7WbZfZJa0YLFDJJBA== X-Received: by 2002:a17:906:7d9:b0:b04:1b84:923c with SMTP id a640c23a62f3a-b041b85025emr362763666b.51.1756716490047; Mon, 01 Sep 2025 01:48:10 -0700 (PDT) Received: from localhost (host-79-36-0-44.retail.telecomitalia.it. [79.36.0.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b04189de5b5sm345647166b.10.2025.09.01.01.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 01:48:09 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 1 Sep 2025 10:50:05 +0200 To: Krzysztof Kozlowski Cc: Andrea della Porta , Jim Quinlan , Florian Fainelli , Broadcom internal kernel review list , Bjorn Helgaas , Lorenzo Pieralisi , kwilczynski@kernel.org, Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iivanov@suse.de, svarbanov@suse.de, mbrugger@suse.com, Jonathan Bell , Phil Elwell , kernel test robot Subject: Re: [PATCH] dt-bindings: pci: brcmstb: Add rp1-nexus node to fix DTC warning Message-ID: References: <20250812085037.13517-1-andrea.porta@suse.com> <4fee3870-f9d5-48e3-a5be-6df581d3e296@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Krzysztof, On 08:50 Fri 22 Aug , Krzysztof Kozlowski wrote: > On 21/08/2025 17:22, Andrea della Porta wrote: > > Hi Krzysztof, > > > > On 10:55 Tue 12 Aug , Krzysztof Kozlowski wrote: > >> On 12/08/2025 10:50, Andrea della Porta wrote: > >>> The devicetree compiler is complaining as follows: > >>> > >>> arch/arm64/boot/dts/broadcom/rp1-nexus.dtsi:3.11-14.3: Warning (unit_address_vs_reg): /axi/pcie@1000120000/rp1_nexus: node has a reg or ranges property, but no unit name > >>> /home/andrea/linux-torvalds/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@1000120000: Unevaluated properties are not allowed ('rp1_nexus' was unexpected) > >> > >> Please trim the paths. > > > > Ack. > > > >> > >>> > >>> Add the optional node that fix this to the DT binding. > >>> > >>> Reported-by: kernel test robot > >>> Closes: https://lore.kernel.org/oe-kbuild-all/202506041952.baJDYBT4-lkp@intel.com/ > >>> Signed-off-by: Andrea della Porta > >>> --- > >>> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++ > >>> 1 file changed, 9 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > >>> index 812ef5957cfc..7d8ba920b652 100644 > >>> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > >>> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > >>> @@ -126,6 +126,15 @@ required: > >>> allOf: > >>> - $ref: /schemas/pci/pci-host-bridge.yaml# > >>> - $ref: /schemas/interrupt-controller/msi-controller.yaml# > >>> + - if: > >>> + properties: > >>> + compatible: > >>> + contains: > >>> + const: brcm,bcm2712-pcie > >>> + then: > >>> + properties: > >>> + rp1_nexus: > >> > >> No, you cannot document post-factum... This does not follow DTS coding > >> style. > > > > I think I didn't catch what you mean here: would that mean that > > we cannot resolve that warning since we cannot add anything to the > > binding? > > I meant, you cannot use a warning from the code you recently introduced > as a reason to use incorrect style. > > Fixing warning is of course fine and correct, but for the code recently > introduced and which bypassed ABI review it is basically like new review > of new ABI. > > This needs standard review practice, so you need to document WHY you > need such node. Warning is not the reason here why you are doing. If > this was part of original patchset, like it should have been, you would > not use some imaginary warning as reason, right? > > So provide reason why you need here this dedicated child, what is that > child representing. Ack. > > Otherwise I can suggest: drop the child and DTSO, this also solves the > warning... This would not fix the issue: it's the non overlay that needs the specific node. But I got the point, and we have a solution for that (see below). > > > > > Regarding rp1_nexus, you're right I guess it should be > > rp1-nexus as per DTS coding style. > > > >> > >> Also: > >> > >> Node names should be generic. See also an explanation and list of > >> examples (not exhaustive) in DT specification: > >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > > > In this case it could be difficult: we need to search for a DT node > > Search like in driver? That's wrong, you should be searching by compatible. Thanks for the hint. Searching by compatble is the solution. > > > starting from the DT root and using generic names like pci@0,0 or > > dev@0,0 could possibly led to conflicts with other peripherals. > > That's why I chose a specific name. > > Dunno, depends what can be there, but you do not get a specific > (non-generic) device node name for a generic PCI device or endpoint. I would use 'port' instead of rp1-nexus. Would it work for you? Many thanks, Andrea > > > > Best regards, > Krzysztof