From: Yao Zi <ziyao@disroot.org>
To: Maud Spierings <maud_spierings@hotmail.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org,
aou@eecs.berkeley.edu, alex@ghiti.fr, fustini@kernel.org,
gaohan@iscas.ac.cn, rabenda.cn@gmail.com,
linux-kernel@vger.kernel.org, palmer@dabbelt.com,
guoren@kernel.org, p.zabel@pengutronix.de,
paul.walmsley@sifive.com, m.wilczynski@samsung.com,
krzk+dt@kernel.org, linux-riscv@lists.infradead.org,
wefu@redhat.com
Subject: Re: [PATCH 3/4] reset: th1520: Support reset controllers in more subsystems
Date: Wed, 3 Sep 2025 00:44:25 +0000 [thread overview]
Message-ID: <aLePaQSMLgiGsbf_@pie> (raw)
In-Reply-To: <AM7P189MB100965809B3DE48A90A15415E306A@AM7P189MB1009.EURP189.PROD.OUTLOOK.COM>
On Tue, Sep 02, 2025 at 04:15:08PM +0200, Maud Spierings wrote:
> Hi Yao,
>
> > Introduce reset controllers for AP, MISC, VI, VP and DSP subsystems and
> > add their reset signal mappings.
> >
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > ---
>
> /* snip */
>
> > static const struct of_device_id th1520_reset_match[] = {
> > + { .compatible = "thead,th1520-reset-ap", .data = &th1520_ap_reset_data },
> > + { .compatible = "thead,th1520-reset-misc", .data = &th1520_misc_reset_data },
> > + { .compatible = "thead,th1520-reset-vi", .data = &th1520_vi_reset_data },
> > { .compatible = "thead,th1520-reset", .data = &th1520_reset_data },
> > + { .compatible = "thead,th1520-reset-vp", .data = &th1520_vp_reset_data },
> > + { .compatible = "thead,th1520-reset-dsp", .data = &th1520_dsp_reset_data },
>
> I believe these should be alphabetically sorted on compatible name.
This is sorted according to the order they appear in the TRM, but yeah
sorting them alphabetically makes more sense. I'll do this in v2.
Thanks,
Yao Zi
> > { /* sentinel */ }
> > };
> > MODULE_DEVICE_TABLE(of, th1520_reset_match);
> > --
> > 2.50.1
>
> Kind regards,
> Maud
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-09-03 0:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 4:23 [PATCH 0/4] Add reset controllers for other TH1520 subsystems Yao Zi
2025-09-01 4:23 ` [PATCH 1/4] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys Yao Zi
2025-09-02 8:27 ` Krzysztof Kozlowski
2025-09-02 9:04 ` Yao Zi
2025-09-02 13:44 ` Krzysztof Kozlowski
2025-09-02 13:57 ` Philipp Zabel
2025-09-02 15:43 ` Krzysztof Kozlowski
2025-09-02 13:57 ` Philipp Zabel
2025-09-03 0:41 ` Yao Zi
2025-09-01 4:23 ` [PATCH 2/4] reset: th1520: Prepare for supporting multiple controllers Yao Zi
2025-09-01 4:23 ` [PATCH 3/4] reset: th1520: Support reset controllers in more subsystems Yao Zi
2025-09-02 10:50 ` kernel test robot
2025-09-02 14:15 ` Maud Spierings
2025-09-03 0:44 ` Yao Zi [this message]
2025-09-01 4:23 ` [PATCH 4/4] riscv: dts: thead: Add reset controllers of more subsystems for TH1520 Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLePaQSMLgiGsbf_@pie \
--to=ziyao@disroot.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=gaohan@iscas.ac.cn \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.wilczynski@samsung.com \
--cc=maud_spierings@hotmail.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rabenda.cn@gmail.com \
--cc=robh@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox