Re: [PATCH v6 1/2] dt-bindings: clock: add TI CDCE6214 binding

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Sep 04, 2025 at 11:43:53AM +0200, Krzysztof Kozlowski wrote:
> On 04/09/2025 09:34, Sascha Hauer wrote:
> > On Thu, Sep 04, 2025 at 09:18:13AM +0200, Krzysztof Kozlowski wrote:
> >> On Wed, Sep 03, 2025 at 03:55:45PM +0200, Sascha Hauer wrote:
> >>> Add device tree binding for the CDCE6214, an Ultra-Low Power Clock
> >>> Generator With One PLL, Four Differential Outputs, Two Inputs, and
> >>> Internal EEPROM.
> >>>
> >>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >>> ---
> >>>  .../devicetree/bindings/clock/ti,cdce6214.yaml     | 198 +++++++++++++++++++++
> >>>  include/dt-bindings/clock/ti,cdce6214.h            |  24 +++
> >>>  2 files changed, 222 insertions(+)
> >>>
> >>
> >> I don't understand what is happening here.
> >>
> >> Patch changed in weird and unexplained way - nothing in the changelog
> >> explains dropping SPDX - and does not pass even checkpatch.
> > 
> > I removed the SPDX by accident, will add it back of course.
> > 
> > Other than that, what's weird? Changelog says I now use the pinctrl
> > subsystem to configure pins. OK, that also changes the binding, I could
> > have mentioned that explicitly, sorry for that.
> 
> There were four patches before, now there are two and changelog says
> only about pinctrl to configure pins. That's very vague and you expect
> me to decipher what changed in the bindings.

In v5 I tried splitting the driver/bindings up into a basic part which
and a part which added the pin config stuff in the hope that the first
two patches could be applied first. This was not very well received, so
I merged it back.

I am aware that the binding looks quite different now, but this really
goes down to using the pinctrl bindings now.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |