Re: [PATCH 1/2] arm64: dts: broadcom: rp1: Add USB nodes

[Andrea della Porta <andrea.porta@suse.com>]

Hi Stanimir,

On 13:46 Thu 04 Sep     , Stanimir Varbanov wrote:
> Hi Andrea,
> 
> Thank you for the patch!
> 
> On 8/28/25 4:50 PM, Andrea della Porta wrote:
> > The RaspberryPi 5 has RP1 chipset containing two USB host controller,
> > while presenting two USB 2.0 and two USB 3.0 ports to the outside.
> > 
> > Add the relevant USB nodes to the devicetree.
> > 
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> >  arch/arm64/boot/dts/broadcom/rp1-common.dtsi | 28 ++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/broadcom/rp1-common.dtsi b/arch/arm64/boot/dts/broadcom/rp1-common.dtsi
> > index 5002a375eb0b..116617fcb1eb 100644
> > --- a/arch/arm64/boot/dts/broadcom/rp1-common.dtsi
> > +++ b/arch/arm64/boot/dts/broadcom/rp1-common.dtsi
> > @@ -39,4 +39,32 @@ rp1_gpio: pinctrl@400d0000 {
> >  			     <1 IRQ_TYPE_LEVEL_HIGH>,
> >  			     <2 IRQ_TYPE_LEVEL_HIGH>;
> >  	};
> > +
> > +	rp1_usb0: usb@40200000 {
> > +		reg = <0x00 0x40200000  0x0 0x100000>;
> > +		compatible = "snps,dwc3";
> > +		dr_mode = "host";
> > +		interrupts = <31 IRQ_TYPE_EDGE_RISING>;
> > +		usb3-lpm-capable;
> > +		snps,dis_rxdet_inp3_quirk;
> > +		snps,parkmode-disable-ss-quirk;
> > +		snps,parkmode-disable-hs-quirk;
> > +		snps,tx-max-burst = /bits/ 8 <8>;
> > +		snps,tx-thr-num-pkt = /bits/ 8 <2>;
> > +		status = "disabled";
> > +	};
> > +
> 
> I'd order the generic properties first and then vendor specific.
> Something like this:
> 
> rp1_usb0: usb@40200000 {
> 	compatible = "snps,dwc3";
> 	reg = <0x00 0x40200000 0x0 0x100000>;
> 	interrupts = <31 IRQ_TYPE_EDGE_RISING>;
> 	dr_mode = "host";
>         ....
> }

Ack.

Many thanks,
Andrea

> 
> > +	rp1_usb1: usb@40300000 {
> > +		reg = <0x00 0x40300000  0x0 0x100000>;
> > +		compatible = "snps,dwc3";
> > +		dr_mode = "host";
> > +		interrupts = <36 IRQ_TYPE_EDGE_RISING>;
> > +		usb3-lpm-capable;
> > +		snps,dis_rxdet_inp3_quirk;
> > +		snps,parkmode-disable-ss-quirk;
> > +		snps,parkmode-disable-hs-quirk;
> > +		snps,tx-max-burst = /bits/ 8 <8>;
> > +		snps,tx-thr-num-pkt = /bits/ 8 <2>;
> > +		status = "disabled";
> > +	};
> >  };
>