From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: "Herve Codina (Schneider Electric)" <herve.codina@bootlin.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Hoan Tran <hoan@os.amperecomputing.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Saravana Kannan <saravanak@google.com>,
Serge Semin <fancer.lancer@gmail.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Pascal Eberhard <pascal.eberhard@se.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 6/8] dt-bindings: soc: renesas: Add the Renesas RZ/N1 GPIO Interrupt Multiplexer
Date: Fri, 19 Sep 2025 11:34:51 +0200 [thread overview]
Message-ID: <aM0ju74JJbjliQAl@ninjato> (raw)
In-Reply-To: <20250918104009.94754-7-herve.codina@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
> + interrupt-map:
> + description:
> + Specifies the mapping from external GPIO interrupt lines to the output
> + interrupts. The array items have to be ordered with the first item
> + related to the output line 0 (IRQ 103), the next one to the output line 1
> + (IRQ 104) and so on up to the output line 8 (IRQ 110).
maxItems 8?
> + /*
> + * The child interrupt number is computed using the following formula:
> + * gpio_bank * 32 + gpio_number
> + *
> + * with:
> + * - gpio_bank: The GPIO bank number
> + * - 0 for GPIO0A,
> + * - 1 for GPIO1A,
> + * - 2 for GPIO2A
> + * - gpio_number: Number of the gpio in the bank (0..31)
> + */
I wonder if this comment wouldn't be better in the interrupt-map
description above?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-09-19 9:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 10:39 [PATCH v3 0/8] gpio: renesas: Add support for GPIO and related interrupts in RZ/N1 SoC Herve Codina (Schneider Electric)
2025-09-18 10:39 ` [PATCH v3 1/8] of/irq: Introduce for_each_of_imap_item Herve Codina (Schneider Electric)
2025-09-18 10:40 ` [PATCH v3 2/8] of: unittest: Add a test case for for_each_of_imap_item iterator Herve Codina (Schneider Electric)
2025-09-18 10:40 ` [PATCH v3 3/8] irqchip/ls-extirq: Use " Herve Codina (Schneider Electric)
2025-09-18 10:40 ` [PATCH v3 4/8] irqchip/renesas-rza1: " Herve Codina (Schneider Electric)
2025-09-18 10:40 ` [PATCH v3 5/8] ARM: dts: r9a06g032: Add GPIO controllers Herve Codina (Schneider Electric)
2025-09-19 10:03 ` Wolfram Sang
2025-09-22 14:22 ` Bartosz Golaszewski
2025-09-22 15:31 ` Herve Codina
2025-09-22 15:33 ` Bartosz Golaszewski
2025-09-22 16:08 ` Herve Codina
2025-09-18 10:40 ` [PATCH v3 6/8] dt-bindings: soc: renesas: Add the Renesas RZ/N1 GPIO Interrupt Multiplexer Herve Codina (Schneider Electric)
2025-09-18 15:06 ` Conor Dooley
2025-09-18 15:15 ` Herve Codina
2025-09-18 15:26 ` Conor Dooley
2025-09-18 15:39 ` Herve Codina
2025-09-18 15:44 ` Conor Dooley
2025-09-19 17:33 ` Rob Herring
2025-09-19 9:34 ` Wolfram Sang [this message]
2025-09-19 12:39 ` Herve Codina
2025-09-18 10:40 ` [PATCH v3 7/8] soc: renesas: Add support for " Herve Codina (Schneider Electric)
2025-09-19 9:41 ` Wolfram Sang
2025-09-19 13:14 ` Herve Codina
2025-09-19 14:40 ` Wolfram Sang
2025-09-19 15:30 ` Herve Codina
2025-09-19 15:47 ` Wolfram Sang
2025-10-14 13:19 ` Geert Uytterhoeven
2025-10-14 14:11 ` Wolfram Sang
2025-10-14 14:58 ` Geert Uytterhoeven
2025-09-18 10:40 ` [PATCH v3 8/8] ARM: dts: r9a06g032: Add support for GPIO interrupts Herve Codina (Schneider Electric)
2025-09-19 9:42 ` Wolfram Sang
2025-09-19 13:59 ` Herve Codina
2025-09-19 14:41 ` Wolfram Sang
2025-09-19 17:12 ` Herve Codina
2025-09-22 14:16 ` Herve Codina
2025-09-22 14:29 ` Wolfram Sang
2025-09-18 15:37 ` [PATCH v3 0/8] gpio: renesas: Add support for GPIO and related interrupts in RZ/N1 SoC Conor Dooley
2025-09-18 15:57 ` Herve Codina
2025-09-19 5:41 ` Wolfram Sang
2025-09-19 9:43 ` Wolfram Sang
2025-09-19 9:54 ` Wolfram Sang
2025-09-19 15:48 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aM0ju74JJbjliQAl@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=hoan@os.amperecomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=pascal.eberhard@se.com \
--cc=phil.edworthy@renesas.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).