From: Yao Zi <ziyao@disroot.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: bhelgaas@google.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, heiko@sntech.de, jonas@kwiboo.se,
krzk+dt@kernel.org, kwilczynski@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-rockchip@lists.infradead.org, lpieralisi@kernel.org,
mani@kernel.org, robh@kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Enable PCIe controller on Radxa E20C
Date: Thu, 11 Sep 2025 08:10:36 +0000 [thread overview]
Message-ID: <aMKD_LhjdFNNu62B@pie> (raw)
In-Reply-To: <20250909130009.2555706-1-amadeus@jmu.edu.cn>
On Tue, Sep 09, 2025 at 09:00:09PM +0800, Chukun Pan wrote:
> Hi,
>
> > +&pcie {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pciem1_pins>, <&pcie_reset_g>;
>
> The pciem1_pins contains PCIE20_PERSTn_M1 (GPIO1_A2)
> This will cause conflicts, "pinctrl-0 = <&pciem1_pins>" is enough.
>
> [ 0.115608] rockchip-pinctrl pinctrl: not freeing pin 34 (gpio1-2) as part of deactivating group pciem1-pins - it is already used for some other setting
> [ 0.191042] rockchip-pinctrl pinctrl: pin gpio1-2 already requeste by pll_gpll; cannot claim for 140000000.pcie
> [ 0.191949] rockchip-pinctrl pinctrl: error -EINVAL: pin-34 (140000000.pcie)
> [ 0.192570] rockchip-pinctrl pinctrl: error -EINVAL: could not request pin 34 (gpio1-2) from group pciem1-pins on device rockchip-pinctrl
>
> > + reset-gpios = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>;
>
> Missing supply: "vpcie3v3-supply = <&vcc_3v3>;"
>
> > + status = "okay";
> > +};
> > +
Will fix them in v2, thanks.
> Thanks,
> Chukun
Best regards,
Yao Zi
prev parent reply other threads:[~2025-09-11 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 13:52 [PATCH 0/3] Add PCIe Gen2x1 controller support for RK3528 Yao Zi
2025-09-06 13:52 ` [PATCH 1/3] dt-bindings: PCI: dwc: rockchip: Add RK3528 variant Yao Zi
2025-09-09 0:47 ` Rob Herring (Arm)
2025-09-06 13:52 ` [PATCH 2/3] arm64: dts: rockchip: Add PCIe Gen2x1 controller for RK3528 Yao Zi
2025-09-09 12:50 ` Chukun Pan
2025-09-11 8:09 ` Yao Zi
2025-09-10 21:29 ` Jonas Karlman
2025-09-11 7:56 ` Yao Zi
2025-09-11 8:44 ` Jonas Karlman
2025-09-06 13:52 ` [PATCH 3/3] arm64: dts: rockchip: Enable PCIe controller on Radxa E20C Yao Zi
2025-09-09 13:00 ` Chukun Pan
2025-09-11 8:10 ` Yao Zi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMKD_LhjdFNNu62B@pie \
--to=ziyao@disroot.org \
--cc=amadeus@jmu.edu.cn \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).