From: Yao Zi <ziyao@disroot.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: bhelgaas@google.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, heiko@sntech.de, jonas@kwiboo.se,
krzk+dt@kernel.org, kwilczynski@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-rockchip@lists.infradead.org, lpieralisi@kernel.org,
mani@kernel.org, robh@kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Add PCIe Gen2x1 controller for RK3528
Date: Thu, 11 Sep 2025 08:09:33 +0000 [thread overview]
Message-ID: <aMKDvcbJ2T-QNYxw@pie> (raw)
In-Reply-To: <20250909125029.2553286-1-amadeus@jmu.edu.cn>
On Tue, Sep 09, 2025 at 08:50:29PM +0800, Chukun Pan wrote:
> Hi,
>
> > + reg = <0x1 0x40000000 0x0 0x400000>,
> > + <0x0 0xfe4f0000 0x0 0x10000>,
> > + <0x0 0xfc000000 0x0 0x100000>;
>
> Aligning the address for reg and ranges will look better:
>
> reg = <0x1 0x40000000 0x0 0x400000>,
> <0x0 0xfe4f0000 0x0 0x010000>,
> <0x0 0xfc000000 0x0 0x100000>;
Thanks, this makes sense.
> BTW do we possibly need this?
> https://github.com/rockchip-linux/kernel/commit/e9397245c4b1bd62ef929d221e20225d58467dc7
I'm still unsure its purpose, but am willing to adapt this change. See
my reply to Jonas' comment.
> > + clocks = <&cru ACLK_PCIE>, <&cru HCLK_PCIE_SLV>,
> > + <&cru HCLK_PCIE_DBI>, <&cru PCLK_PCIE>,
> > + <&cru CLK_PCIE_AUX>, <&cru PCLK_PCIE_PHY>;
>
> <&cru PCLK_PCIE_PHY> has already been defined in the combphy node,
> is it repeated here?
Yes, it should be managed by PHY instead of the controller. I'll fix it
in v2.
> Thanks,
> Chukun
Best regards,
Yao Zi
next prev parent reply other threads:[~2025-09-11 8:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 13:52 [PATCH 0/3] Add PCIe Gen2x1 controller support for RK3528 Yao Zi
2025-09-06 13:52 ` [PATCH 1/3] dt-bindings: PCI: dwc: rockchip: Add RK3528 variant Yao Zi
2025-09-09 0:47 ` Rob Herring (Arm)
2025-09-06 13:52 ` [PATCH 2/3] arm64: dts: rockchip: Add PCIe Gen2x1 controller for RK3528 Yao Zi
2025-09-09 12:50 ` Chukun Pan
2025-09-11 8:09 ` Yao Zi [this message]
2025-09-10 21:29 ` Jonas Karlman
2025-09-11 7:56 ` Yao Zi
2025-09-11 8:44 ` Jonas Karlman
2025-09-06 13:52 ` [PATCH 3/3] arm64: dts: rockchip: Enable PCIe controller on Radxa E20C Yao Zi
2025-09-09 13:00 ` Chukun Pan
2025-09-11 8:10 ` Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMKDvcbJ2T-QNYxw@pie \
--to=ziyao@disroot.org \
--cc=amadeus@jmu.edu.cn \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).