From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77E9327A10F for ; Fri, 12 Sep 2025 09:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757667620; cv=none; b=oxN6X465/26QBZ0ebfZ4QV4mU1kBikmeFHhZcG/X52wV9f6GeGyVN0oSWbNojg7YmJgvdkJoktt2B3o7CBvfdQZzKS98AuP5wED/VC7RxUoiIuW5mIEKgCC+S2Ur7LXCwBfc/o1iXNVcDJieYQFudORJ8HkWEiF46p/Ew2iDiE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757667620; c=relaxed/simple; bh=KkxRQUegu9Ld7QxiircNfbxfnOwVwrbn4bnFeCPC280=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lo45mfK9LCULbt1CcSr4p5X/0TNw7MTDLtNahHt/+dIn3zbUQ0NSd5Evk0n/2ylUQgWa6InxZvUF+itzoJsmCjAcP+4M7unZJSJXbl675X0/t1skkUCIe9Kz+LvDJrNAb/evDKYqMohms0534kHWw5aUPYm8rHYkKGLXdCFDbww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=w4JntkdN; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w4JntkdN" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b0415e03e25so211901666b.0 for ; Fri, 12 Sep 2025 02:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757667617; x=1758272417; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kqH/ZuUT/Wy0euj5Cau8Rdbvh6wWj1ajWc17fov4n94=; b=w4JntkdNSN2t7pKnaViHvAFVNxomUT6rsF0zPREN3/Ey7Xu8I5prQtkrrZNvD5rbVq E0oeEgQG0Bp85yaS6L8qeTUklfC+6UQo6SeDQ2wXRYcOW0XlypxvbAwRL+zWa++4OFtv Ri+l6K7WSN8fOlULqB/1+c0WufyF4sdqJ2OPUtCxodXVi0reocfm9P6T5Hy2NDv1ZJfg EUxMusqke0cq0UBUdBeh6YsP2/s1CZK06DPBIjKzTFD7OLG7rwY1Nu+SIU6XEq/fnqHS lW3Oafaq4+oREb/ciPhN+HgNnwjcOFidbfuroai1iMUMfB8dIDsryrSAZlPmk36q+jjb 3Ogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757667617; x=1758272417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kqH/ZuUT/Wy0euj5Cau8Rdbvh6wWj1ajWc17fov4n94=; b=FDU8vS5ylRnWbftvQh6iZ5w5dbW+7s3KIwOc3KG2JD11BkX8lA8H+5zBU10TPRSSxh t5gZggXcd+K91vlpFnFIvp94NCC5tRrtAUoxQ6zG2PeqR1PS/26YhWCaF7byi+nISsdh Tf4+mx5ce0G7rEt+sZJ+88WFCbSQrZoFvNdxwiNz1zo5GYUYTtewf4GxJSa6gaT2A75E gnNnnYv2C3R3Hsoko3f/MqcD/ds69Z7xi0uZutVGpGfG6AMHI+AG1naz9E1I10Vt9PD3 yCR4us5FCBYyiqA9G78Lp5zVGxcIKOspLgyx7Fd8gslGacE4J4pC/tUNQw7wNnufzxky s6FA== X-Forwarded-Encrypted: i=1; AJvYcCWBb+qiHawqXBT0fJGA9DL2Cn0Aw4XEMA7wMjJ1o3O9e1HWClqzqVcOdVac7ut+BBg3czGDWg08cIG9@vger.kernel.org X-Gm-Message-State: AOJu0YwCYPTLTCAoj+Mxctka3v/yeP0lTl2tmrYRtUe4geeSz88A81ax 1w7T/hhhnaGSk4OHlNTdWNT0Sd98/V59zF37lHISfhCACI+TAGfQjbQxKxumBgyDT98= X-Gm-Gg: ASbGnctk/Ix45HpQx1HiofRQFsW/gF/ix5xcwzrqPotK1t1ATDYaarNd33wdJ9LTgz4 IRMLpmzMQHWOFFQEgrUFxNRSTEqwiOt2oHMgQjpPn5ai9MWqKd8NKO22KiRxcpU9msgYbUB6wk1 mb+2Ls/CGP4krglg4KA3c5iHtPnx4dXQsdFFT95f0vUpeuPtiFOSZQBXF2Q5I4fkJhYzb54erww +BXN8SWjzToLmLmE6wFgB+edkeECYvE2hGI4xBdQ0acI1GRBlgop3oIyCxHulZfiY+SqpKiewyP 6H9Qx9GxYaqpHzGQPPoDijir524qQrK1N93giH8ZI4l0uwGKqDCN8Cb1ZqbwR0shasn0IFrWLlz r8VisFUy4rUeRzkH/tCOazvO0UC3S1FTSBNwpfyBFbQkR66nNIYpl2g== X-Google-Smtp-Source: AGHT+IG6ahhooDRjCLAr+j2YJkIYsc7o/D83Omh5S2ijH7u28U1AnCkxcq7mMhp9y7AnOYU5iezA5w== X-Received: by 2002:a17:906:d542:b0:aff:9906:e452 with SMTP id a640c23a62f3a-b07c381fdc9mr216146766b.31.1757667616760; Fri, 12 Sep 2025 02:00:16 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:30:5fc2:ee41:2050:2d49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b32f20ffsm328900866b.79.2025.09.12.02.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 02:00:16 -0700 (PDT) Date: Fri, 12 Sep 2025 11:00:11 +0200 From: Stephan Gerhold To: Yijie Yang Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board Message-ID: References: <20250910-hamoa_initial-v11-0-38ed7f2015f7@oss.qualcomm.com> <20250910-hamoa_initial-v11-4-38ed7f2015f7@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250910-hamoa_initial-v11-4-38ed7f2015f7@oss.qualcomm.com> On Wed, Sep 10, 2025 at 05:02:12PM +0800, Yijie Yang wrote: > The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of > the Hamoa IoT SoM and a carrier board. Together, they form a complete > embedded system capable of booting to UART. > > Make the following peripherals on the carrier board enabled: > - UART > - On-board regulators > - USB Type-C mux > - Pinctrl > - Embedded USB (EUSB) repeaters > - NVMe > - pmic-glink > - USB DisplayPorts > - Bluetooth > - WLAN > - Audio > > Written in collaboration with Quill Qi (Audio) , > Jie Zhang (Graphics) , Shuai Zhang (Bluetooth) > , Yingying Tang (WLAN) , > and Yongxing Mou (USB DisplayPorts) . This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags. > > Signed-off-by: Yijie Yang > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++ > 2 files changed, 1222 insertions(+) > > [...] > diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts > new file mode 100644 > index 000000000000..6eedad7e858a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts > @@ -0,0 +1,1221 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +/dts-v1/; > + > +#include "hamoa-iot-som.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. Hamoa IoT EVK"; > + compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100"; > + chassis-type = "embedded"; > + > [...] > + /* > + * TODO: These two regulators are actually part of the removable M.2 > + * card and not the CRD mainboard. Need to describe this differently. This is not a CRD, I think? > + * Functionally it works correctly, because all we need to do is to > + * turn on the actual 3.3V supply above. > + */ > + vreg_wcn_0p95: regulator-wcn-0p95 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_WCN_0P95"; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <950000>; > + > + vin-supply = <&vreg_wcn_3p3>; > + }; > + > + vreg_wcn_1p9: regulator-wcn-1p9 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_WCN_1P9"; > + regulator-min-microvolt = <1900000>; > + regulator-max-microvolt = <1900000>; > + > + vin-supply = <&vreg_wcn_3p3>; > + }; > + > + vreg_wcn_3p3: regulator-wcn-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_WCN_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&wcn_sw_en>; > + pinctrl-names = "default"; > + regulator-boot-on? > + regulator-always-on; > + }; > + > [...] > +}; > + > [...] > +&mdss { > + status = "okay"; > +}; > + > +&mdss_dp0 { > + status = "okay"; > +}; > + > +&mdss_dp0_out { > + data-lanes = <0 1>; This is unneeded unless you really want to limit this to just 2 lanes. x1e80100.dtsi specifies 4 lanes by default. > + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; > +}; > + > +&mdss_dp1 { > + status = "okay"; > +}; > + > +&mdss_dp1_out { > + data-lanes = <0 1>; Same here. > + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; > +}; > + > +&mdss_dp2 { > + status = "okay"; > +}; > + > +&mdss_dp2_out { > + data-lanes = <0 1>; And here. > + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; > +}; > + > +&mdss_dp3 { > + /delete-property/ #sound-dai-cells; You need to define pinctrl for the HPD pin here. Thanks, Stephan