Re: [PATCH v8 2/3] arm64: dts: qcom: x1-hp-x14: Unify HP Omnibook X14 device tree structure

[Stephan Gerhold <stephan.gerhold@linaro.org>]

On Tue, Sep 09, 2025 at 07:02:34PM +0200, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 
> Extract common elements into a shared .dtsi file for HP Omnibook X14 to
> support both Hamoa (x1e*/x1p6*) and Purwa (x1p4*/x1*) variants.
> Required because the device trees are not compatible.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> ---
>  ...hp-omnibook-x14.dts => x1-hp-omnibook-x14.dtsi} |   48 +-
>  .../boot/dts/qcom/x1e80100-hp-omnibook-x14.dts     | 1606 +-------------------
>  2 files changed, 48 insertions(+), 1606 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
> similarity index 97%
> copy from arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> copy to arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
> index 716205b437df55489cfb7d29846cdaf8e403cf72..e6851dbaba121029bde926310616169e319cf5e3 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> +++ b/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
> [...]
> @@ -1028,6 +1015,7 @@ &mdss_dp0 {
>  };
>  
>  &mdss_dp0_out {
> +	data-lanes = <0 1>;
>  	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
>  };
>  
> @@ -1036,15 +1024,13 @@ &mdss_dp1 {
>  };
>  
>  &mdss_dp1_out {
> +	data-lanes = <0 1>;
>  	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
>  };
>  
>  &mdss_dp3 {
>  	/delete-property/ #sound-dai-cells;
>  
> -	pinctrl-0 = <&edp0_hpd_default>;
> -	pinctrl-names = "default";
> -
>  	status = "okay";
>  
>  	aux-bus {
> @@ -1061,13 +1047,19 @@ edp_panel_in: endpoint {
>  			};
>  		};
>  	};
> -};
>  
> -&mdss_dp3_out {
> -	data-lanes = <0 1 2 3>;
> -	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> +	ports {
> +		port@1 {
> +			reg = <1>;
> +
> +			mdss_dp3_out: endpoint {
> +				data-lanes = <0 1 2 3>;
> +				link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
>  
> -	remote-endpoint = <&edp_panel_in>;
> +				remote-endpoint = <&edp_panel_in>;
> +			};
> +		};
> +	};
>  };
>  
>  &mdss_dp3_phy {

Please review the resulting diff carefully when you rebase changes with
conflicts. You're reverting other changes (4 lane DP, eDP HPD pinctrl)
here. :-)

Thanks,
Stephan