From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hall.aurel32.net (hall.aurel32.net [195.154.113.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B16D819994F; Mon, 22 Sep 2025 21:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.154.113.88 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758574826; cv=none; b=BMODDPocrskQHp6tzrF2J9eALaK+QiEihulAd/dDRiBPISbENC0VZwfX7Er+6ljfw5F/8vIVraMTz5jKyNsCTMaln0CQrDLmqSdjEcU0zgFMK+sAXyvDUlBuMhCU0ewMX10ZA6maWeQVJshQjJn7Mc6FHv/jgAhamQvEF7WXK2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758574826; c=relaxed/simple; bh=lVR1JNWr0UqoHEys8ULYA1yMquKH3xNGi3XVd2uTi6M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rv0w5BLS2INk8IVRWIPP4QVUeQX5JByt2xOtyXbmn2pzBRfUgb8+nSQEjLinwBtv2hON8MVvoqxZ594OJjNCHvQx7IaK7IguDQ2kv2PEAiGw7S0+TC76/2Qu/EyWatfVdrrmHiHWM3jXcAVEuLSxAVtBW1WejFNEyPzVXqX3JBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net; spf=pass smtp.mailfrom=aurel32.net; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b=tFnEbDmr; arc=none smtp.client-ip=195.154.113.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aurel32.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b="tFnEbDmr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=asyNZP9neHNXj+Sf6k7sPwKgT9c0m2eBv/rMLNDCtys=; b=tFnEbDmrs/NXUJ6T83/sGy/b1t Kz+6rhz0J1rz8uFgGchadwf5BXSxN4p/Pe4DS9blqRMtj98sPJC3c9Bd5Oiy2P3GfNnt+dVGzTvpA 1bBafaJfnfCSnvIGffRmpqC8Lz426hpYMpk3oUetrXLlRQPKe9fMwTjXyATJCc89WKLXoNR8wOPLs VKEnHU5r55IwqRskbiZ9c4dFneKFhIMIvEMI8rQjf2h5mDdodOsL9dn5TgP5+vycrluTcxkqww0En mBvDRkte5i9AZdJLflXdVN6pxpuxZzmDG9arg932xgY6sWlzorOBvctN+zdstdd+oCNQqABjm8Hnt 9TL4GIzA==; Received: from [2a01:e34:ec5d:a741:1ee1:92ff:feb4:5ec0] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v0ndz-00AlmZ-0j; Mon, 22 Sep 2025 23:00:19 +0200 Date: Mon, 22 Sep 2025 23:00:18 +0200 From: Aurelien Jarno To: Yixun Lan Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V ARCHITECTURE" , "open list:RISC-V SPACEMIT SoC Support" Subject: Re: [PATCH 2/3] riscv: dts: spacemit: add 24c02 eeprom on BPI-F3 Message-ID: Mail-Followup-To: Yixun Lan , linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V ARCHITECTURE" , "open list:RISC-V SPACEMIT SoC Support" References: <20250921210237.943370-1-aurelien@aurel32.net> <20250921210237.943370-3-aurelien@aurel32.net> <20250922032158-GYA1291757@gentoo.org> <20250922080105-GYB1291757@gentoo.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250922080105-GYB1291757@gentoo.org> User-Agent: Mutt/2.2.13 (2024-03-09) On 2025-09-22 16:01, Yixun Lan wrote: > Hi Aurelien, > > On 06:49 Mon 22 Sep , Aurelien Jarno wrote: > > Hi, > > > > On 2025-09-22 11:21, Yixun Lan wrote: > > > Hi Aurelien, > > > > > > On 23:01 Sun 21 Sep , Aurelien Jarno wrote: > > > > The BPI-F3 contains a 24c02 eeprom, that contains among other things the > > > > MAC addresses of the two network interfaces. For this reason, mark it as > > > > read-only. > > > > > > > > Signed-off-by: Aurelien Jarno > > > > --- > > > > arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 11 ++++++++++- > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > > > > index 3b6e4f52e9aad..574d10fdf9b82 100644 > > > > --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > > > > +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > > > > @@ -115,6 +115,15 @@ &i2c2 { > > > > pinctrl-0 = <&i2c2_0_cfg>; > > > > pinctrl-names = "default"; > > > > status = "okay"; > > > > + > > > > + eeprom@50 { > > > > + compatible = "atmel,24c02"; > > > > + reg = <0x50>; > > > > + vcc-supply = <&vcc1v8_sys>; > > > > + pagesize = <16>; > > > .. > > > > + read-only; > > > so you're sure there is no demand to write data to eeprom? > > > (update info at linux env) > > > > It seems to only contains board infos (mac addresses), but if there are > > other use cases, that can indeed be dropped. > > > On my second thought, I'm ok with it being "read-only", as we flash these > infos during firmware burning stage, then never alter them later. > > > > > + size = <256>; > > > > + }; > > > > }; > > > > > > > > &i2c8 { > > > > @@ -143,7 +152,7 @@ buck2 { > > > > regulator-always-on; > > > > }; > > > > > > > > - buck3 { > > > > + vcc1v8_sys: buck3 { > > > I'm not sure if adding an alias here is a good idea, it occurs buck3 > > > serve the suppy for many devices, besides, to me it's more proper to > > > name it as eeprom_vcc1v8 for the eeprom according to schematics in > > > this case.. > > > > We need to add a label to be able to reference it for the eeprom > > vcc-supply, but we'll have to also reference it for other devices (e.g. > > emmc, wifi, phys, etc... It tried to choose a common name, ie the right > > most one on the schematics. Another option could be to call it buck3, > > but other name suggestions are welcome. > how about simply making it "buck3_1v8", then probably add a comment > later in the eeprom node? to mapping to the shecmatics > vcc-supply = <&buck3_1v8>; /* EEPROM_VCC1V8 */ Thanks that sounds good. I'll send an updated patchset with that change. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net