From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4C631158A; Tue, 23 Sep 2025 07:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.255.230.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758612133; cv=none; b=IUWaBoK94Ccq0EW1te+N+1ny6S+wJ6664fa+MrZoab0ljtRxQx4tWohCaYZwOAeJs+UL5tRa7EZ9D1K8K2qu9inYN7t+i8z4Yo9ZvgWjrthWCdwBUYQBENbqqE3aVyf8bxyzG5vsPketDQWmVb18wUJoLvve1Z/1BxRWFThnM+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758612133; c=relaxed/simple; bh=UXWIhJQT0UWxMfY/+J9fpbJB9h4hs4LLSoJ3ohNFBv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=smcRhb2ZtNw0nYSwmiN8CWyg2+6olJtj2jOFEaPQd49rMSfP7utWJO+Z/AD0sZVj+N21Idylc+9xH4YxDjcdTJH295CosSjiZxYq6XfES6FmQKNHZzuoyS7lgIsnRtW5mirur3QNZKBNI4gdD3QJ9EDvv7xHEOfRILcT3yKridw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ucw.cz; spf=pass smtp.mailfrom=ucw.cz; dkim=pass (1024-bit key) header.d=ucw.cz header.i=@ucw.cz header.b=sTTBQf/a; arc=none smtp.client-ip=46.255.230.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ucw.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ucw.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ucw.cz header.i=@ucw.cz header.b="sTTBQf/a" Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 0CBDD1C01D7; Tue, 23 Sep 2025 09:22:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1758612127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hwzWkQrBN4TucShSte7+gBBGke3z5o+Bkhkg05nMEo4=; b=sTTBQf/a2nzDFGyFnuAvY+ZoWD8Hosb9TzAxDaZiDAvOEHBXFt2Ry+MnJvCHTHajjKDe30 +6esiaJNy6v6yDUz49gjYVaUeMw3Eoiy4/0gLL1s/YKgW31/ZpI0TrH8W7O7EFLug/Kc3m TK/E85C8luh+gvffde677ZQ3AhTp++0= Date: Tue, 23 Sep 2025 09:22:06 +0200 From: Pavel Machek To: barnabas.czeman@mainlining.org Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Otto =?iso-8859-1?Q?Pfl=FCger?= , Linus Walleij , Lee Jones , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov , Adam Skladowski , Sireesh Kodali , Rob Clark , Abhinav Kumar , Jessica Zhang , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Konrad Dybcio Subject: Re: [PATCH v7 6/6] arm64: dts: qcom: Add Xiaomi Redmi 3S Message-ID: References: <20250831-msm8937-v7-0-232a9fb19ab7@mainlining.org> <20250831-msm8937-v7-6-232a9fb19ab7@mainlining.org> <97ee369f6ffbe42c72c57ebd72887b23@mainlining.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iO6C/R28FEPs1Luw" Content-Disposition: inline In-Reply-To: <97ee369f6ffbe42c72c57ebd72887b23@mainlining.org> --iO6C/R28FEPs1Luw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Hi! > >=20 > > > + led-controller@45 { > > > + compatible =3D "awinic,aw2013"; > > > + reg =3D <0x45>; > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + vcc-supply =3D <&pm8937_l10>; > > > + vio-supply =3D <&pm8937_l5>; > > > + > > > + led@0 { > > > + reg =3D <0>; > > > + function =3D LED_FUNCTION_STATUS; > > > + led-max-microamp =3D <5000>; > > > + color =3D ; > > > + }; > > > + > > > + led@1 { > > > + reg =3D <1>; > > > + function =3D LED_FUNCTION_STATUS; > > > + led-max-microamp =3D <5000>; > > > + color =3D ; > > > + }; > > > + > > > + led@2 { > > > + reg =3D <2>; > > > + function =3D LED_FUNCTION_STATUS; > > > + led-max-microamp =3D <5000>; > > > + color =3D ; > > > + }; > > > + }; > > > +}; > >=20 > > That's single, 3-color LED, right? Please see LED multicolor support. > As far as i know aw2013 driver does not have multicolor support. > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/= Documentation/devicetree/bindings/leds/leds-aw2013.yaml I believe that needs to be fixed before more bugs are added on top to work around that problem... =2E..and before that bug is cemented in the ABI. Best regards, Pavel --=20 I don't work for Nazis and criminals, and neither should you. Boycott Putin, Trump, Netanyahu and Musk! --iO6C/R28FEPs1Luw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCaNJKngAKCRAw5/Bqldv6 8rwwAKCAEqvmxyif1M2EfR+OkPL1Yc+kKACfXIQxtdTTJxoVlwLVcRR2GW3coKg= =tPlv -----END PGP SIGNATURE----- --iO6C/R28FEPs1Luw--