From: Johan Hovold <johan@kernel.org>
To: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
krzk+dt@kernel.org, conor+dt@kernel.org, kishon@kernel.org,
vkoul@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 2/9] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible
Date: Tue, 23 Sep 2025 09:27:17 +0200 [thread overview]
Message-ID: <aNJL1YEXx6IabTos@hovoldconsulting.com> (raw)
In-Reply-To: <4116b593-d36d-df10-6101-4e3539b8b812@oss.qualcomm.com>
On Mon, Sep 22, 2025 at 06:00:04PM -0700, Wesley Cheng wrote:
>
>
> On 9/20/2025 8:22 AM, Dmitry Baryshkov wrote:
> > On Fri, Sep 19, 2025 at 08:21:01PM -0700, Wesley Cheng wrote:
> >> The Glymur USB subsystem contains a multiport controller, which utilizes
>
>> two QMP UNI PHYs. Add the proper compatible string for the Glymur SoC.
> >> @@ -16,6 +16,7 @@ description:
> >> properties:
> >> compatible:
> >> enum:
> >> + - qcom,glymur-qmp-usb3-uni-phy
Odd indentation?
> >> - qcom,ipq5424-qmp-usb3-phy
> >> - qcom,ipq6018-qmp-usb3-phy
> >> - qcom,ipq8074-qmp-usb3-phy
> >> @@ -62,6 +63,8 @@ properties:
> >>
> >> vdda-pll-supply: true
> >>
> >> + refgen-supply: true
> >
> > You've added it, but it's not referenced as required. Why is it so?
> The refgen clock isn't always required on each and every platform unlike
> the .9v and 1.2v rail/supply, which directly power the QMP PHY. It only
> really depends on how the refclk/CXO network is built for that
> particular chipset. The refgen ensures that we're properly voting for
> the supply that is powering our CXO buffer.
I thought we discussed this before and concluded that this is not an
accurate description of the hardware (even if you now call this supply
refgen instead of qref):
https://lore.kernel.org/lkml/aEBfV2M-ZqDF7aRz@hovoldconsulting.com/
Given your description above this still looks wrong (at least after a
quick look).
Johan
next prev parent reply other threads:[~2025-09-23 7:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 3:20 [PATCH 0/9] Introduce Glymur USB support Wesley Cheng
2025-09-20 3:21 ` [PATCH 1/9] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible Wesley Cheng
2025-09-20 15:18 ` Dmitry Baryshkov
2025-09-22 20:52 ` Wesley Cheng
2025-09-24 12:31 ` Konrad Dybcio
2025-09-20 3:21 ` [PATCH 2/9] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible Wesley Cheng
2025-09-20 15:22 ` Dmitry Baryshkov
2025-09-23 1:00 ` Wesley Cheng
2025-09-23 3:40 ` Dmitry Baryshkov
2025-09-23 19:36 ` Wesley Cheng
2025-09-23 7:27 ` Johan Hovold [this message]
2025-09-23 21:51 ` Wesley Cheng
2025-09-20 3:21 ` [PATCH 3/9] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible Wesley Cheng
2025-09-22 20:14 ` Rob Herring
2025-09-23 1:02 ` Wesley Cheng
2025-09-24 1:00 ` Wesley Cheng
2025-09-20 3:21 ` [PATCH 4/9] dt-bindings: usb: qcom,snps-dwc3: " Wesley Cheng
2025-09-20 3:21 ` [PATCH 5/9] phy: qualcomm: Update the QMP clamp register for V6 Wesley Cheng
2025-09-20 15:28 ` Dmitry Baryshkov
2025-09-20 3:21 ` [PATCH 6/9] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings Wesley Cheng
2025-09-20 15:31 ` Dmitry Baryshkov
2025-09-20 17:12 ` kernel test robot
2025-09-20 3:21 ` [PATCH 7/9] phy: qualcomm: qmp-usb: Add support for Glymur USB UNI PHY Wesley Cheng
2025-09-20 3:21 ` [PATCH 8/9] phy: qualcomm: m31-eusb2: Make clkref an optional resource Wesley Cheng
2025-09-20 15:33 ` Dmitry Baryshkov
2025-09-20 3:21 ` [PATCH 9/9] phy: qualcomm: m31-eusb2: Make USB repeater optional Wesley Cheng
2025-09-20 15:42 ` Dmitry Baryshkov
2025-09-23 1:03 ` Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNJL1YEXx6IabTos@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=wesley.cheng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).