Re: [PATCH 1/3] riscv: dts: spacemit: enable the i2c2 adapter on BPI-F3

[Aurelien Jarno <aurelien@aurel32.net>]

Hi Troy,

Thanks for the review.

On 2025-09-23 09:32, Troy Mitchell wrote:
> On Sun, Sep 21, 2025 at 11:01:41PM +0200, Aurelien Jarno wrote:
> > Define properties for the I2C adapter, and enable it on the BPI-F3. It
> > will be used by the 24c02 eeprom.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > @@ -92,6 +92,13 @@ gmac1-pins {
> >  		};
> >  	};
> >  
> > +	i2c2_0_cfg: i2c2-0-cfg {
> Should this be i2c2_4_cfg here?
> From what I see, in the initial version the second cell was meant
> to be the function number rather than the serial index.

Ok, I wasn't aware of that convention, I just reused the same numbering 
of the downstream 6.6 kernel. I'll fix that and use i2c2_4_cfg.

> It looks like the pwm part is also incorrect.

Yes, and also the submitted PCIE patches.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net