From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Jonas Jelonek <jelonek.jonas@gmail.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-i2c@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Markus Stockhausen <markus.stockhausen@gmx.de>,
Sven Eckelmann <sven@narfation.org>,
Harshal Gohel <hg@simonwunderlich.de>
Subject: Re: [PATCH v7 04/12] i2c: rtl9300: use regmap fields and API for registers
Date: Thu, 25 Sep 2025 23:30:54 +0200 [thread overview]
Message-ID: <aNW0jiJQHcS-FKwr@shikoro> (raw)
In-Reply-To: <20250831100457.3114-5-jelonek.jonas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On Sun, Aug 31, 2025 at 10:04:49AM +0000, Jonas Jelonek wrote:
> Adapt the RTL9300 I2C controller driver to use more of the regmap
> API, especially make use of reg_field and regmap_field instead of macros
> to represent registers. Most register operations are performed through
> regmap_field_* API then.
>
> Handle SCL selection using separate chip-specific functions since this
> is already known to differ between the Realtek SoC families in such a
> way that this cannot be properly handled using just a different
> reg_field.
>
> This makes it easier to add support for newer generations or to handle
> differences between specific revisions within a series. Just by
> defining a separate driver data structure with the corresponding
> register field definitions and linking it to a new compatible.
>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
> Tested-by: Sven Eckelmann <sven@narfation.org>
> Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Tested-by: Chris Packham <chris.packham@alliedtelesis.co.nz> # On RTL9302C based board
> Tested-by: Markus Stockhausen <markus.stockhausen@gmx.de>
I wanted to apply the rest of this series but applying fails. Can you
kindly rebase it to 6.17-rc5 or later?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-09-25 21:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 10:04 [PATCH v7 00/12] i2c: fix, rework and extend RTL9300 I2C driver Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 01/12] i2c: rtl9300: fix channel number bound check Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 02/12] i2c: rtl9300: ensure data length is within supported range Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 03/12] i2c: rtl9300: remove broken SMBus Quick operation support Jonas Jelonek
2025-09-03 22:59 ` Andi Shyti
2025-09-05 10:12 ` Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 04/12] i2c: rtl9300: use regmap fields and API for registers Jonas Jelonek
2025-09-25 21:30 ` Wolfram Sang [this message]
2025-09-25 21:46 ` Jonas Jelonek
2025-09-26 6:47 ` Wolfram Sang
2025-09-26 8:04 ` Jonas Jelonek
2025-09-26 8:18 ` Wolfram Sang
2025-08-31 10:04 ` [PATCH v7 05/12] dt-bindings: i2c: realtek,rtl9301-i2c: fix wording and typos Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 06/12] i2c: rtl9300: rename internal sda_pin to sda_num Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 07/12] i2c: rtl9300: move setting SCL frequency to config_io Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 08/12] i2c: rtl9300: do not set read mode on every transfer Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 09/12] i2c: rtl9300: separate xfer configuration and execution Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 10/12] i2c: rtl9300: use scoped guard instead of explicit lock/unlock Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 11/12] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support Jonas Jelonek
2025-08-31 10:04 ` [PATCH v7 12/12] i2c: rtl9300: add support for RTL9310 I2C controller Jonas Jelonek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNW0jiJQHcS-FKwr@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hg@simonwunderlich.de \
--cc=jelonek.jonas@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.stockhausen@gmx.de \
--cc=robh@kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox