From: "Otto Pflüger" <otto.pflueger@abscue.de>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>, Lee Jones <lee@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] power: reset: sc27xx: Add support for SC2730 and OF match table
Date: Tue, 14 Oct 2025 08:10:57 +0200 [thread overview]
Message-ID: <aO3pcRCZN1qYEDW6@abscue.de> (raw)
In-Reply-To: <982105c4-9dbd-47dc-bfc3-ef37a390a14c@linux.alibaba.com>
On Tue, Oct 14, 2025 at 09:44:15AM +0800, Baolin Wang wrote:
> [...]
> >
> > The driver was hard-coded to use registers 0xc2c and 0xdf0. SC2730 has
> > different registers, which were added to the downstream version of the
> > driver in [1]. I have tested this with a UMS9230 phone which has an
> > SC2730 PMIC according to the device tree.
> >
> > [1]: https://github.com/MotorolaMobilityLLC/kernel-sprd/commit/6165e1afe3eba33089fecc86767d47af9ab176d6
>
> OK. Thanks.
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Please note that due to the feedback about the use of empty device tree
nodes, I have switched to a different approach and sent an alternative
patch as a follow-up to this one:
https://lore.kernel.org/all/20251007-sc27xx-mfd-poweroff-v1-0-89a2f919b731@abscue.de/
next prev parent reply other threads:[~2025-10-14 6:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 16:23 [PATCH 0/5] power: reset: sc27xx: Add SC2730 and reboot support Otto Pflüger
2025-09-26 16:23 ` [PATCH 1/5] dt-bindings: power: reset: Add SC27xx series PMIC poweroff Otto Pflüger
2025-09-26 16:23 ` [PATCH 2/5] dt-bindings: mfd: sc2731: Reference sprd,sc2731-poweroff Otto Pflüger
2025-10-02 2:53 ` Rob Herring
2025-09-26 16:23 ` [PATCH 3/5] power: reset: sc27xx: Use devm_register_sys_off_handler Otto Pflüger
2025-09-30 3:23 ` Baolin Wang
2025-09-26 16:23 ` [PATCH 4/5] power: reset: sc27xx: Add support for SC2730 and OF match table Otto Pflüger
2025-09-30 3:30 ` Baolin Wang
2025-09-30 5:30 ` Otto Pflüger
2025-10-14 1:44 ` Baolin Wang
2025-10-14 6:10 ` Otto Pflüger [this message]
2025-09-26 16:23 ` [PATCH 5/5] power: reset: sc27xx: Add reboot support for SC2730 Otto Pflüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO3pcRCZN1qYEDW6@abscue.de \
--to=otto.pflueger@abscue.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).