Re: [PATCH] dt-bindings: ipmi: Convert nuvoton,npcm750-kcs-bmc to DT schema

[Corey Minyard <corey@minyard.net>]

On Tue, Oct 14, 2025 at 10:29:34AM -0500, Rob Herring (Arm) wrote:
> Convert the nuvoton,npcm750-kcs-bmc binding to DT schema format. It's a
> straight-forward conversion.

I have queued this for 6.19, but I would like a review from the people
that worked on this file previously.

Thanks,

-corey

> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/ipmi/npcm7xx-kcs-bmc.txt         | 40 --------------
>  .../ipmi/nuvoton,npcm750-kcs-bmc.yaml         | 55 +++++++++++++++++++
>  2 files changed, 55 insertions(+), 40 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
>  create mode 100644 Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> deleted file mode 100644
> index 4fda76e63396..000000000000
> --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -* Nuvoton NPCM KCS (Keyboard Controller Style) IPMI interface
> -
> -The Nuvoton SOCs (NPCM) are commonly used as BMCs
> -(Baseboard Management Controllers) and the KCS interface can be
> -used to perform in-band IPMI communication with their host.
> -
> -Required properties:
> -- compatible : should be one of
> -    "nuvoton,npcm750-kcs-bmc"
> -    "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
> -- interrupts : interrupt generated by the controller
> -- kcs_chan : The KCS channel number in the controller
> -
> -Example:
> -
> -    lpc_kcs: lpc_kcs@f0007000 {
> -        compatible = "nuvoton,npcm750-lpc-kcs", "simple-mfd", "syscon";
> -        reg = <0xf0007000 0x40>;
> -        reg-io-width = <1>;
> -
> -        #address-cells = <1>;
> -        #size-cells = <1>;
> -        ranges = <0x0 0xf0007000 0x40>;
> -
> -        kcs1: kcs1@0 {
> -            compatible = "nuvoton,npcm750-kcs-bmc";
> -            reg = <0x0 0x40>;
> -            interrupts = <0 9 4>;
> -            kcs_chan = <1>;
> -            status = "disabled";
> -        };
> -
> -        kcs2: kcs2@0 {
> -            compatible = "nuvoton,npcm750-kcs-bmc";
> -            reg = <0x0 0x40>;
> -            interrupts = <0 9 4>;
> -            kcs_chan = <2>;
> -            status = "disabled";
> -        };
> -    };
> diff --git a/Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml
> new file mode 100644
> index 000000000000..fc5df1c5e3bc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ipmi/nuvoton,npcm750-kcs-bmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM KCS BMC
> +
> +maintainers:
> +  - Avi Fishman <avifishman70@gmail.com>
> +  - Tomer Maimon <tmaimon77@gmail.com>
> +  - Tali Perry <tali.perry1@gmail.com>
> +
> +description:
> +  The Nuvoton SOCs (NPCM) are commonly used as BMCs (Baseboard Management
> +  Controllers) and the KCS interface can be used to perform in-band IPMI
> +  communication with their host.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: nuvoton,npcm750-kcs-bmc
> +      - items:
> +          - enum:
> +              - nuvoton,npcm845-kcs-bmc
> +          - const: nuvoton,npcm750-kcs-bmc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  kcs_chan:
> +    description: The KCS channel number in the controller
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1
> +    maximum: 3
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - kcs_chan
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    kcs@0 {
> +        compatible = "nuvoton,npcm750-kcs-bmc";
> +        reg = <0x0 0x40>;
> +        interrupts = <9 4>;
> +        kcs_chan = <1>;
> +    };
> -- 
> 2.51.0
>