From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37B501DB122 for ; Tue, 14 Oct 2025 23:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760484260; cv=none; b=Z4aeCd0MUYFewXgK8eQj/ukXUK7t3hWjq+NpZBUMxmGBeAPduPtW79jqSJPAcSwp+bM+xXYL/wKOuM1b32zFSdXnLskmh2rZOgSudWClUcv4B6gBJIRHCbsU9Db3DBoo64AXxxuFhPoNJzOtKNNaQdGojYk3SlvPI4X8MvsxGhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760484260; c=relaxed/simple; bh=nykKmIGlqeNKSHIOK9cArsnp9F/dsxRBsg7SOi+yUbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=id1vzNvoeMi7NtHhNgTdS5beT0XlFxoGBOW2wLnTrYoYsgyAIDw1Zf/Nbo4pRwYQcxkiGMwJWw1JgO297W40/Aqh0RdNAL8M2OV4Vz40qhqMPXxuGi+eJ0eY0RD7dtmKnYzhLm/bLjBMv+ZWou7XxtSq02aAe9U7lFzTOIC/rd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net; spf=none smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b=Kjqrto23; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b="Kjqrto23" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7b4f7a856acso2282751a34.3 for ; Tue, 14 Oct 2025 16:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard-net.20230601.gappssmtp.com; s=20230601; t=1760484258; x=1761089058; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EzbA3h2diXeHnSi6hUxLmW4I+M7NlNe4WP1JAxxHucA=; b=Kjqrto23zqmr3P2FoZz2EC9uq3n7JEDSkPAHVD2D1wGiJN7/w6hxngwkml4pgpsu5E ZmD3EMyt86+4w8vtqAFnLY4uyDLxdh2bAa+Rn6MPluYrHRwHYIAqNNHQrHVD31UPzICt cvMMDg/8mUiG41hOSoL+wYtFyYkpV1D7GtV8SXQczW3XJuYObA0YZDmyT4+6pW/6aV0i NwYPhukIaqGhnLBsmKQnqrl/ItMmlJXBDTX6SdxwB7Wq1OMCKKK6Oz6hTadbIMZypXvc hdOV7WbjpBwOse7JldMIg/SvllLxKHWj+J18h0o/eXdTbOpi+LsF3S1FWuEJYnVW84WH WyPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760484258; x=1761089058; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EzbA3h2diXeHnSi6hUxLmW4I+M7NlNe4WP1JAxxHucA=; b=cSrr0+XICdQiGVCntIU2OfohaKrPrGsTSXbZqELJrLGMmetSI/MWBtGFegl5a3q/nD OUVeG5Y2mVUAHPluCwHo1R+jyCBIcO7+TufIDbKkx3qEf32/7K+37lq8d+ggTa+uTbJp spQxvOFHfdguJLAz8NyryBaNzp0T3tGgqA3Hju499wzBIhl3g/0PxHpKktZ9QNQbTbM6 9ziVaSFPG0gOhQ5AZtIcTyA37XzKPpCuS2TetADxfeVuPqJaR5pzlyvkxDu7wDG1JYZC 85RBG21khgADws7N0JA2yLM45/w0tGALdGwdlRbBafMSdeIpGnywD810ocRy3LGcTMSH 4xYw== X-Forwarded-Encrypted: i=1; AJvYcCUx6qWnyMuE9Fu0IvrT1KbjJB/stzMz5lQbZNDdlryQ7/EzQ2ISyW7GAR+twPIlppXyW5ICOhc4qbQW@vger.kernel.org X-Gm-Message-State: AOJu0YwzqfuxrKc7N7PqO8EIgFQNTvCZGlgrEE7hLlD22lPhYPpgbuPs jgzT/KMrCF4ju9dls/yi8FT1H4HFt65ZmBGUAs9ycsWcV0KfyrygMK9Hxl62OoEg3r8= X-Gm-Gg: ASbGncsivxOevLbSApVhgkdliJFH2Eg066CtRKVzBSUU/yIJp3DwIpnEFJH7HSctXS5 ZB2uIRsU8UUr61QRYQmtK/5omDAbLZeUpg+u//YcRnFdXRbelwcCgP5L/GTil3M51EREEhMCh4O pJs5zBg1QlVfxFKtPu+NlES/I/cyIoO1E3AY/BrqurPJimfQzOYKSaHILEjcZKh74lN/hDmqFyn /xZC/VJMGkSRAlMeo33Wo+QQGI88ryLRWG8FLVQ/UJy0n5AmecH5D+OA+z+MD+i8HzZdOB8qrf8 KpzfzJmlywHCM8b2Jq8RMz99Dj97HKzkoaYBw6RU82tvHjc7BhuGBiNu3f6iNDT9vwSfX6WcoJ/ NTtDK0z9z5/0/EiExR+UzKG0XQrr4r7WTCBLBL0Rr0LN9yrzFF7wvCao= X-Google-Smtp-Source: AGHT+IFQc/e1ZbUnpoFVWuijFM2zvD8w2iyi9D7yf/z3QjAKE+FCW90DUZ0U3/TgiDPhnHf198NIsA== X-Received: by 2002:a05:6830:641b:b0:74a:1f03:db5a with SMTP id 46e09a7af769-7c0df71bb2cmr14506181a34.3.1760484258480; Tue, 14 Oct 2025 16:24:18 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:ad63:63fb:ee1c:2ee9]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c0f9067d80sm4859579a34.11.2025.10.14.16.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 16:24:17 -0700 (PDT) Date: Tue, 14 Oct 2025 18:24:12 -0500 From: Corey Minyard To: "Rob Herring (Arm)" Cc: Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Krzysztof Kozlowski , Conor Dooley , openbmc@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: ipmi: Convert nuvoton,npcm750-kcs-bmc to DT schema Message-ID: Reply-To: corey@minyard.net References: <20251014152935.3782463-1-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251014152935.3782463-1-robh@kernel.org> On Tue, Oct 14, 2025 at 10:29:34AM -0500, Rob Herring (Arm) wrote: > Convert the nuvoton,npcm750-kcs-bmc binding to DT schema format. It's a > straight-forward conversion. I have queued this for 6.19, but I would like a review from the people that worked on this file previously. Thanks, -corey > > Signed-off-by: Rob Herring (Arm) > --- > .../bindings/ipmi/npcm7xx-kcs-bmc.txt | 40 -------------- > .../ipmi/nuvoton,npcm750-kcs-bmc.yaml | 55 +++++++++++++++++++ > 2 files changed, 55 insertions(+), 40 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > create mode 100644 Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml > > diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > deleted file mode 100644 > index 4fda76e63396..000000000000 > --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > +++ /dev/null > @@ -1,40 +0,0 @@ > -* Nuvoton NPCM KCS (Keyboard Controller Style) IPMI interface > - > -The Nuvoton SOCs (NPCM) are commonly used as BMCs > -(Baseboard Management Controllers) and the KCS interface can be > -used to perform in-band IPMI communication with their host. > - > -Required properties: > -- compatible : should be one of > - "nuvoton,npcm750-kcs-bmc" > - "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc" > -- interrupts : interrupt generated by the controller > -- kcs_chan : The KCS channel number in the controller > - > -Example: > - > - lpc_kcs: lpc_kcs@f0007000 { > - compatible = "nuvoton,npcm750-lpc-kcs", "simple-mfd", "syscon"; > - reg = <0xf0007000 0x40>; > - reg-io-width = <1>; > - > - #address-cells = <1>; > - #size-cells = <1>; > - ranges = <0x0 0xf0007000 0x40>; > - > - kcs1: kcs1@0 { > - compatible = "nuvoton,npcm750-kcs-bmc"; > - reg = <0x0 0x40>; > - interrupts = <0 9 4>; > - kcs_chan = <1>; > - status = "disabled"; > - }; > - > - kcs2: kcs2@0 { > - compatible = "nuvoton,npcm750-kcs-bmc"; > - reg = <0x0 0x40>; > - interrupts = <0 9 4>; > - kcs_chan = <2>; > - status = "disabled"; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml > new file mode 100644 > index 000000000000..fc5df1c5e3bc > --- /dev/null > +++ b/Documentation/devicetree/bindings/ipmi/nuvoton,npcm750-kcs-bmc.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ipmi/nuvoton,npcm750-kcs-bmc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton NPCM KCS BMC > + > +maintainers: > + - Avi Fishman > + - Tomer Maimon > + - Tali Perry > + > +description: > + The Nuvoton SOCs (NPCM) are commonly used as BMCs (Baseboard Management > + Controllers) and the KCS interface can be used to perform in-band IPMI > + communication with their host. > + > +properties: > + compatible: > + oneOf: > + - const: nuvoton,npcm750-kcs-bmc > + - items: > + - enum: > + - nuvoton,npcm845-kcs-bmc > + - const: nuvoton,npcm750-kcs-bmc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + kcs_chan: > + description: The KCS channel number in the controller > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 3 > + > +required: > + - compatible > + - reg > + - interrupts > + - kcs_chan > + > +additionalProperties: false > + > +examples: > + - | > + kcs@0 { > + compatible = "nuvoton,npcm750-kcs-bmc"; > + reg = <0x0 0x40>; > + interrupts = <9 4>; > + kcs_chan = <1>; > + }; > -- > 2.51.0 >