[PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Wolfram Sang]

Allow additional properties to enable devices attached to the bus.
Fixes warnings like these:

arch/arm/boot/dts/renesas/sh73a0-kzm9g.dtb: bus@fec10000 (renesas,bsc-sh73a0): Unevaluated properties are not allowed ('ethernet@10000000' was unexpected)
arch/arm/boot/dts/renesas/r8a73a4-ape6evm.dtb: bus@fec10000 (renesas,bsc-r8a73a4): Unevaluated properties are not allowed ('ethernet@8000000', 'flash@0' were unexpected)

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Copied this from 'bus/allwinner,sun50i-a64-de2.yaml' which seemed to me
like the most specific patternProperties for a bus.

Passes dt_binding_check and fixes the above warnings without regressing.

 .../devicetree/bindings/bus/renesas,bsc.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/bus/renesas,bsc.yaml b/Documentation/devicetree/bindings/bus/renesas,bsc.yaml
index f53a37785413..24732c5e24e1 100644
--- a/Documentation/devicetree/bindings/bus/renesas,bsc.yaml
+++ b/Documentation/devicetree/bindings/bus/renesas,bsc.yaml
@@ -41,6 +41,18 @@ properties:
   interrupts:
     maxItems: 1
 
+patternProperties:
+  # All other properties should be child nodes with unit-address and 'reg'
+  "^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+$":
+    type: object
+    additionalProperties: true
+    properties:
+      reg:
+        maxItems: 1
+
+    required:
+      - reg
+
 required:
   - reg
 
-- 
2.47.2

Re: [PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Geert Uytterhoeven]

Hi Wolfram,

On Tue, 7 Oct 2025 at 05:22, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Allow additional properties to enable devices attached to the bus.
> Fixes warnings like these:
>
> arch/arm/boot/dts/renesas/sh73a0-kzm9g.dtb: bus@fec10000 (renesas,bsc-sh73a0): Unevaluated properties are not allowed ('ethernet@10000000' was unexpected)
> arch/arm/boot/dts/renesas/r8a73a4-ape6evm.dtb: bus@fec10000 (renesas,bsc-r8a73a4): Unevaluated properties are not allowed ('ethernet@8000000', 'flash@0' were unexpected)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> index f53a37785413..24732c5e24e1 100644
> --- a/Documentation/devicetree/bindings/bus/renesas,bsc.yaml
> +++ b/Documentation/devicetree/bindings/bus/renesas,bsc.yaml
> @@ -41,6 +41,18 @@ properties:
>    interrupts:
>      maxItems: 1
>
> +patternProperties:
> +  # All other properties should be child nodes with unit-address and 'reg'
> +  "^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+$":

I take it the "\\-" means escaped dash, to avoid it being interpreted
as a range? I usually put the dash at the end, so it needs no escaping,
but I am not sure that would work in yaml.

I would drop the "A-F", as upper-case hex in unit addresses is very
rare, and non-existent in *upstream) Renesas DTS files.

> +    type: object
> +    additionalProperties: true
> +    properties:
> +      reg:
> +        maxItems: 1
> +
> +    required:
> +      - reg
> +
>  required:
>    - reg

I guess we can indeed have no child nodes without reg properties.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

Hi Geert,

> > +patternProperties:
> > +  # All other properties should be child nodes with unit-address and 'reg'
> > +  "^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+$":
> 
> I take it the "\\-" means escaped dash, to avoid it being interpreted
> as a range? I usually put the dash at the end, so it needs no escaping,
> but I am not sure that would work in yaml.
> 
> I would drop the "A-F", as upper-case hex in unit addresses is very
> rare, and non-existent in *upstream) Renesas DTS files.

As said, I copied this from 'bus/allwinner,sun50i-a64-de2.yaml', so this
got reviewed already. I have no strong opinions on your suggestions
above. But whatever we agree on, it should be reused for all busses, I'd
say. So, we should put it where it can be referenced?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Geert Uytterhoeven]

Hi Wolfram,

On Tue, 7 Oct 2025 at 23:30, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > > +patternProperties:
> > > +  # All other properties should be child nodes with unit-address and 'reg'
> > > +  "^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+$":
> >
> > I take it the "\\-" means escaped dash, to avoid it being interpreted
> > as a range? I usually put the dash at the end, so it needs no escaping,
> > but I am not sure that would work in yaml.
> >
> > I would drop the "A-F", as upper-case hex in unit addresses is very
> > rare, and non-existent in *upstream) Renesas DTS files.
>
> As said, I copied this from 'bus/allwinner,sun50i-a64-de2.yaml', so this
> got reviewed already. I have no strong opinions on your suggestions
> above. But whatever we agree on, it should be reused for all busses, I'd
> say. So, we should put it where it can be referenced?

In my defense, this is a DT bindings file for Renesas BSC, so we can
(and IMHO should) add restrictions.

If you want to go the fully generic way: as per the device tree
specification, a unit-address can take all characters from the same
set as a node name...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]


> > As said, I copied this from 'bus/allwinner,sun50i-a64-de2.yaml', so this
> > got reviewed already. I have no strong opinions on your suggestions
> > above. But whatever we agree on, it should be reused for all busses, I'd
> > say. So, we should put it where it can be referenced?
> 
> In my defense, this is a DT bindings file for Renesas BSC, so we can
> (and IMHO should) add restrictions.
> 
> If you want to go the fully generic way: as per the device tree
> specification, a unit-address can take all characters from the same
> set as a node name...

Well, I think consistency makes sense, but I don't even have a strong
opinion on that. If DT maintainers are fine with having multiple
patternProperties for busses, I will include the restriction you
suggested.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Rob Herring]

On Wed, Oct 08, 2025 at 12:02:29PM +0200, Wolfram Sang wrote:
> 
> > > As said, I copied this from 'bus/allwinner,sun50i-a64-de2.yaml', so this
> > > got reviewed already. I have no strong opinions on your suggestions
> > > above. But whatever we agree on, it should be reused for all busses, I'd
> > > say. So, we should put it where it can be referenced?
> > 
> > In my defense, this is a DT bindings file for Renesas BSC, so we can
> > (and IMHO should) add restrictions.
> > 
> > If you want to go the fully generic way: as per the device tree
> > specification, a unit-address can take all characters from the same
> > set as a node name...
> 
> Well, I think consistency makes sense, but I don't even have a strong
> opinion on that. If DT maintainers are fine with having multiple
> patternProperties for busses, I will include the restriction you
> suggested.
> 

There's always examples not to follow...

Adding back context:

> +  "^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+$":                                                

The node name pattern before the '@' is just what's a valid node name. 
That is checked by the core schema on *every* node already. Even ',', 
'.', '+', and '_' are allowed which have long been deprecated. (Do you 
know how long it took to get QCom to stop with the 'qcom,' node name 
prefixes...).

The unit-address is the only part a bus schema should define. And there, 
lowercase hex is standard unless you have distinct fields (e.g. chip 
select and offset).

Rob

Re: [PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hi Rob,

> There's always examples not to follow...

Sure. The good thing is that I could fix the bad examples, once I learnt
how to do it properly.

> The unit-address is the only part a bus schema should define. And there, 
> lowercase hex is standard unless you have distinct fields (e.g. chip 
> select and offset).

Okay, so, the proper pattern is: ""^.*@[0-9a-f]+$"" which is what most
busses are using. Will fix.

Thanks and happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: bus: renesas-bsc: allow additional properties

[Rob Herring]

On Thu, Oct 9, 2025 at 1:43 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Hi Rob,
>
> > There's always examples not to follow...
>
> Sure. The good thing is that I could fix the bad examples, once I learnt
> how to do it properly.

Much appreciated.

> > The unit-address is the only part a bus schema should define. And there,
> > lowercase hex is standard unless you have distinct fields (e.g. chip
> > select and offset).
>
> Okay, so, the proper pattern is: ""^.*@[0-9a-f]+$"" which is what most
> busses are using. Will fix.

You can drop the '^.*' part. We have a mixture of both though...

Rob