devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: imx8-ss-img: Avoid gpio0_mipi_csi GPIOs being deferred
@ 2025-10-14 12:56 João Paulo Gonçalves
  2025-10-14 15:18 ` Frank Li
  2025-10-27  5:58 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: João Paulo Gonçalves @ 2025-10-14 12:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Frank Li
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel,
	João Paulo Gonçalves

From: João Paulo Gonçalves <joao.goncalves@toradex.com>

The gpio0_mipi_csi DT nodes are enabled by default, but they are
dependent on the irqsteer_csi nodes, which are not enabled. This causes
the gpio0_mipi_csi GPIOs to be probe deferred. Since these GPIOs can be
used independently of the CSI controller, enable irqsteer_csi by default
too to prevent them from being deferred and to ensure they work out of
the box.

Fixes: 2217f8243714 ("arm64: dts: imx8: add capture controller for i.MX8's img subsystem")
Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
---
 arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
index 2cf0f7208350a416d77b11140279d2f66f41498f..a72b2f1c4a1b2ef26196c810b33ecfdebdbc1675 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
@@ -67,7 +67,6 @@ irqsteer_csi0: irqsteer@58220000 {
 		power-domains = <&pd IMX_SC_R_CSI_0>;
 		fsl,channel = <0>;
 		fsl,num-irqs = <32>;
-		status = "disabled";
 	};
 
 	gpio0_mipi_csi0: gpio@58222000 {
@@ -144,7 +143,6 @@ irqsteer_csi1: irqsteer@58240000 {
 		power-domains = <&pd IMX_SC_R_CSI_1>;
 		fsl,channel = <0>;
 		fsl,num-irqs = <32>;
-		status = "disabled";
 	};
 
 	gpio0_mipi_csi1: gpio@58242000 {

---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251009-imx8-gpio-csi-deferred-probe-eef6c56a35aa

Best regards,
-- 
João Paulo Gonçalves <joao.goncalves@toradex.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] arm64: dts: imx8-ss-img: Avoid gpio0_mipi_csi GPIOs being deferred
  2025-10-14 12:56 [PATCH v1] arm64: dts: imx8-ss-img: Avoid gpio0_mipi_csi GPIOs being deferred João Paulo Gonçalves
@ 2025-10-14 15:18 ` Frank Li
  2025-10-27  5:58 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-10-14 15:18 UTC (permalink / raw)
  To: João Paulo Gonçalves
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, linux-arm-kernel, linux-kernel,
	João Paulo Gonçalves

On Tue, Oct 14, 2025 at 09:56:43AM -0300, João Paulo Gonçalves wrote:
> From: João Paulo Gonçalves <joao.goncalves@toradex.com>
>
> The gpio0_mipi_csi DT nodes are enabled by default, but they are
> dependent on the irqsteer_csi nodes, which are not enabled. This causes
> the gpio0_mipi_csi GPIOs to be probe deferred. Since these GPIOs can be
> used independently of the CSI controller, enable irqsteer_csi by default
> too to prevent them from being deferred and to ensure they work out of
> the box.

If enable irqsteer_csi[0,1] default, all &irqsteer_csi in board file can
be cleanup.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
> Fixes: 2217f8243714 ("arm64: dts: imx8: add capture controller for i.MX8's img subsystem")
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
> index 2cf0f7208350a416d77b11140279d2f66f41498f..a72b2f1c4a1b2ef26196c810b33ecfdebdbc1675 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
> @@ -67,7 +67,6 @@ irqsteer_csi0: irqsteer@58220000 {
>  		power-domains = <&pd IMX_SC_R_CSI_0>;
>  		fsl,channel = <0>;
>  		fsl,num-irqs = <32>;
> -		status = "disabled";
>  	};
>
>  	gpio0_mipi_csi0: gpio@58222000 {
> @@ -144,7 +143,6 @@ irqsteer_csi1: irqsteer@58240000 {
>  		power-domains = <&pd IMX_SC_R_CSI_1>;
>  		fsl,channel = <0>;
>  		fsl,num-irqs = <32>;
> -		status = "disabled";
>  	};
>
>  	gpio0_mipi_csi1: gpio@58242000 {
>
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251009-imx8-gpio-csi-deferred-probe-eef6c56a35aa
>
> Best regards,
> --
> João Paulo Gonçalves <joao.goncalves@toradex.com>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] arm64: dts: imx8-ss-img: Avoid gpio0_mipi_csi GPIOs being deferred
  2025-10-14 12:56 [PATCH v1] arm64: dts: imx8-ss-img: Avoid gpio0_mipi_csi GPIOs being deferred João Paulo Gonçalves
  2025-10-14 15:18 ` Frank Li
@ 2025-10-27  5:58 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2025-10-27  5:58 UTC (permalink / raw)
  To: João Paulo Gonçalves
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Frank Li,
	devicetree, imx, linux-arm-kernel, linux-kernel,
	João Paulo Gonçalves

On Tue, Oct 14, 2025 at 09:56:43AM -0300, João Paulo Gonçalves wrote:
> From: João Paulo Gonçalves <joao.goncalves@toradex.com>
> 
> The gpio0_mipi_csi DT nodes are enabled by default, but they are
> dependent on the irqsteer_csi nodes, which are not enabled. This causes
> the gpio0_mipi_csi GPIOs to be probe deferred. Since these GPIOs can be
> used independently of the CSI controller, enable irqsteer_csi by default
> too to prevent them from being deferred and to ensure they work out of
> the box.
> 
> Fixes: 2217f8243714 ("arm64: dts: imx8: add capture controller for i.MX8's img subsystem")
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-27  5:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 12:56 [PATCH v1] arm64: dts: imx8-ss-img: Avoid gpio0_mipi_csi GPIOs being deferred João Paulo Gonçalves
2025-10-14 15:18 ` Frank Li
2025-10-27  5:58 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).