From: Shawn Guo <shawnguo2@yeah.net>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Shawn Guo <shawnguo@kernel.org>,
Michael Walle <mwalle@kernel.org>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v6 2/9] dt-bindings: fsl,fpga-qixis-i2c: add support for LX2160ARDB FPGA
Date: Mon, 27 Oct 2025 14:23:49 +0800 [thread overview]
Message-ID: <aP8P9bUcVki_wIbG@dragon> (raw)
In-Reply-To: <20251014155358.3885805-3-ioana.ciornei@nxp.com>
On Tue, Oct 14, 2025 at 06:53:51PM +0300, Ioana Ciornei wrote:
> Extend the list of supported compatible strings with fsl,lx2160ardb-fpga.
>
> Since the register map exposed by the LX2160ARDB's FPGA also contains
> two GPIO controllers, accept the necessary GPIO pattern property.
> At the same time, add the #address-cells and #size-cells properties as
> valid ones so that the child nodes of the fsl,lx2160ardb-fpga node are
> addressable.
>
> This is necessary because when defining child devices such as the GPIO
> controller described in the added example, the child device needs a the
> reg property to properly identify its register location in the parent
> I2C device address space.
>
> Impose this restriction for the new compatible through an if-statement.
>
> The feature set exposed by these QIXIS FPGA devices is highly dependent
> on the board type, meaning that even though the FPGA found on the
> LX2160AQDS board (fsl,lx2160aqds-fpga) works in the same way in terms of
> access over I2C as the one found on the LX2160ARDB (fsl,lx2160ardb-fpga
> added here), the register map inside the device space is different since
> there are different on-board devices to be controlled.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied, thanks!
next prev parent reply other threads:[~2025-10-27 6:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 15:53 [PATCH v6 0/9] drivers: gpio: and the QIXIS FPGA GPIO controller Ioana Ciornei
2025-10-14 15:53 ` [PATCH v6 1/9] dt-bindings: gpio: add QIXIS FPGA based " Ioana Ciornei
2025-10-14 15:53 ` [PATCH v6 2/9] dt-bindings: fsl,fpga-qixis-i2c: add support for LX2160ARDB FPGA Ioana Ciornei
2025-10-27 6:23 ` Shawn Guo [this message]
2025-10-14 15:53 ` [PATCH v6 3/9] dt-bindings: fsl,fpga-qixis: describe the gpio child node found on LS1046AQDS Ioana Ciornei
2025-10-27 6:24 ` Shawn Guo
2025-10-14 15:53 ` [PATCH v6 4/9] gpio: regmap: add the .fixed_direction_output configuration parameter Ioana Ciornei
2025-10-14 15:53 ` [PATCH v6 5/9] gpio: add QIXIS FPGA GPIO controller Ioana Ciornei
2025-10-14 15:53 ` [PATCH v6 6/9] arm64: dts: lx2160a-rdb: describe the QIXIS FPGA and two child GPIO controllers Ioana Ciornei
2025-10-27 6:26 ` Shawn Guo
2025-10-14 15:53 ` [PATCH v6 7/9] arm64: dts: ls1046a-qds: describe the FPGA based GPIO controller Ioana Ciornei
2025-10-27 6:27 ` Shawn Guo
2025-10-14 15:53 ` [PATCH v6 8/9] arm64: dts: lx2160a-rdb: fully describe the two SFP+ cages Ioana Ciornei
2025-10-27 6:29 ` Shawn Guo
2025-10-14 15:53 ` [PATCH v6 9/9] arm64: dts: ls1046a-qds: describe the two on-board " Ioana Ciornei
2025-10-27 6:29 ` Shawn Guo
2025-10-16 10:05 ` (subset) [PATCH v6 0/9] drivers: gpio: and the QIXIS FPGA GPIO controller Bartosz Golaszewski
2025-10-16 13:25 ` Ioana Ciornei
2025-10-16 13:47 ` Bartosz Golaszewski
2025-10-16 14:45 ` Frank Li
2025-10-23 7:39 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aP8P9bUcVki_wIbG@dragon \
--to=shawnguo2@yeah.net \
--cc=Frank.Li@nxp.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwalle@kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).