devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Frank Li <Frank.li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/11] ARM: dts: imx6: rename touch-thermal0 to touch-0-thermal
Date: Wed, 15 Oct 2025 22:26:54 +0100	[thread overview]
Message-ID: <aPARnldAwAYvT0YQ@shell.armlinux.org.uk> (raw)
In-Reply-To: <aPAFWuJCfvTcK8hz@lizhi-Precision-Tower-5810>

On Wed, Oct 15, 2025 at 04:34:34PM -0400, Frank Li wrote:
> On Wed, Oct 15, 2025 at 09:00:15PM +0100, Russell King (Oracle) wrote:
> > On Wed, Oct 15, 2025 at 12:44:27PM -0400, Frank Li wrote:
> > > -		touch-thermal0 {
> > > +		touch0-thermal {
> > ...
> > > -		touch-thermal1 {
> > > +		touch1-thermal {
> > ...
> > > -		touch-thermal0 {
> > > +		touch-0-thermal {
> > ...
> > > -		touch-thermal1 {
> > > +		touch-1-thermal {
> > ...
> > > -		touch-thermal0 {
> > > +		touch-0-thermal {
> > ...
> > > -		touch-thermal1 {
> > > +		touch-1-thermal {
> >
> > Is it touch-N-thermal or touchN-thermal?
> 
> What's difference? I suppose both naming should be okay.

Surely you'd want to be consistent with the node naming? Otherwise
state in the commit message why you're using two different names
where the originals had the same name.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-10-15 21:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 16:44 [PATCH v2 00/11] ARM: dts: imx6: trivial change to clean up some DTB warnings Frank Li
2025-10-15 16:44 ` [PATCH v2 01/11] ARM: dts: imx6: rename stmpgpio to gpio Frank Li
2025-10-15 16:44 ` [PATCH v2 02/11] ARM: dts: imx6: rename touch-thermal0 to touch-0-thermal Frank Li
2025-10-15 20:00   ` Russell King (Oracle)
2025-10-15 20:34     ` Frank Li
2025-10-15 21:26       ` Russell King (Oracle) [this message]
2025-10-15 16:44 ` [PATCH v2 03/11] ARM: dts: imx6: rename m95m02 to eeprom Frank Li
2025-10-15 16:44 ` [PATCH v2 04/11] ARM: dts: imx6qdl-ts4900: rename ngpio to ngpios Frank Li
2025-10-15 16:44 ` [PATCH v2 05/11] ARM: dts: imx6: remove gpio suffix for regulator Frank Li
2025-10-15 16:44 ` [PATCH v2 06/11] ARM: dts: imx6: change voltage-divider's io-channel-cells to 1 Frank Li
2025-10-15 16:44 ` [PATCH v2 07/11] ARM: dts: imx6: remove pinctrl-name if pinctrl-0 doesn't exist Frank Li
2025-10-15 16:44 ` [PATCH v2 08/11] ARM: dts: imx6-tbs2910: rename ir_recv to ir-receiver Frank Li
2025-10-15 16:44 ` [PATCH v2 09/11] ARM: dts: imx6q-utilite-pro: add missing required property for pci Frank Li
2025-10-15 16:44 ` [PATCH v2 10/11] ARM: dts: imx6ull-phytec-tauri: remove extra space before jedec,spi-nor Frank Li
2025-10-15 16:44 ` [PATCH v2 11/11] ARM: dts: imx6qdl-nitrogen6_max: rename i2c<n>mux to i2c Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPARnldAwAYvT0YQ@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).