From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 187D034AAFB for ; Fri, 17 Oct 2025 11:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760700876; cv=none; b=O+0QCjNv+kJXyiQCSYalj5FEqN22lwV41ZlRyqeU5qrEkWPFHpr+8bYamr01xwvJGGFHXf23O7AlGqdYwy2u/96W4VhfX1YmnaK8oyoUEWAh6AmzVdtQBd87cPMqa7762DeeOOfcLpnzd6Bq+1oO+4NlyCHtUgeIVNALeQCMbHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760700876; c=relaxed/simple; bh=xPKudPe20LVyFE+p3IxJr16x4wx/uGvtSa6tEowpGec=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KiaetbrzXn5wYU27ZZEoEJ/RXN8svVpk+3heXGdvP2a0u3vUyFqUvBv5yVOeDHDm/iBFY6OWl4g/+V/Xhnn4VB5nA66Nnz33J1FUS2hC8AcLIgqexIv0fFbE8Zk6Y59Bm2YQM6MwT7Cm9xp7hDHQRmW9Ml1MvLF3TygMDlbl8uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ReV0lAbr; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ReV0lAbr" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-33badfbbc48so2380282a91.2 for ; Fri, 17 Oct 2025 04:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760700874; x=1761305674; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fYfAPtHB/RHiXWE9XxOgOmtRX2AfdTu8oaK5y1u+j8I=; b=ReV0lAbrEXLoA7ZSlXmh6jSMZz275urgTCRGceEXFqCRCX0VQT54AfF3hsM8TWVFtr FFXpYDARFTcKsWF9Jqn2rfqav0xnJb+eIQwEKp1IKncxnIF188wMUgG5m1EX/uS7Xq4W hYvJsZDQUbAsm4D/IXCsoQ+K4sBPGluodtQvePY7YDwv/TD+m20/Tn4qVIzNkuEUn3WS dmpJZDIauzCUvz4hJYTEDIf2tvp4fL7JroMNGwYZk2+QAcIPxuw5cygFMnlJAjgNwVAY fbcTtt71NozCqFaxE5dyUaGqEcOI1flztoB0QmBLxxC1+xgJwi9U6UM0okiiHHsQws9P ZcKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760700874; x=1761305674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fYfAPtHB/RHiXWE9XxOgOmtRX2AfdTu8oaK5y1u+j8I=; b=fMDWxrUOOCLUKKiBcKuzNzhnORxVDisaHzq9hft8ci2bMGCymyLrWDvYJE8W4sKfRB jkSaIJ5DoQo1nU/5Gn/kbK66+DxbQ0mPR3uKx0qu1APS2M6sF6dcIioWg7be/thOCOtM ixeIRzUoQXVChYkjOxwO+WQUhB0RkIfv3qDp+bimXA3EJjEmrf0dJmeFTNiJnmfTs8OZ lEn9fuP+5FjZ/m8Wcaqh+ZgzZ2TvPqshBdsUY08LRrZA+UVpKmgLGP84UPCyZO/LB775 PeErmiw/fg5iUgXd/s5wjtMdEDUzRpCWq00TXsDUAqmWdFCPp4PwwiiZDc/Jmg13MjPb ijGA== X-Forwarded-Encrypted: i=1; AJvYcCWzEHQbqEAW/9w6ZV8zFYmhpJhY5vnATAbe6Ivv5MAdsOhS56U7F5ll+htNlZUKe2XR58DGnlaghCJR@vger.kernel.org X-Gm-Message-State: AOJu0Yx25gOvy/4w3my8mmcPoYWAeap9Ure0N/QjvrjcCDMdiEC+TYrg DlYc6VCoEoQVoeMsYyBaJwo4SY27uJw8WhfAr2epsyck6oa6kaGgBR0E X-Gm-Gg: ASbGncsgE6BnHaENR1N7uYnpKjOcwWYQ8flmtrlanrpKKGxhE5p0O5rSTxm1NI4I+dv oPSYJXoYZu+Dcr0Rc6DyS4POsRelIMhuH9HCc4GvCwBCKfu+T6C4uMG8m/aVM0bYk7d83ZTGUai hpgPU+QoOBaJTZmY6f4rpWY1jdfp05F1zE30XYWE0h2ldwh5N8uyZDNnDde4scqKUnLNuMYjoD0 rLoFzcvOYJw7cwO5pZfnWMKxsgPjDjqhgAZEnBTj8PGgGuOr3ukp5YfUVaRuxvn8BHXYsIqGCPd B49IMDI6nHI0SEEwqpmajTJq1yH8dzUee9O+l9Ys7YtRPzoxdyawyOBg3voQmTY00xwZyoP8xPk J+fGzIG2Q14D/QblBPycquc4qb1OMD8+yjptVzSF7YfOolfjqAlWvhhqsABxgbToBZ3QADeIujv OPDX7pq07bpA== X-Google-Smtp-Source: AGHT+IFWkL4x7nbwb+9Uvguh+3df9cfdWGeCUM99KzCsQewGs4kLcYRtKcEcc6/or/fk3QS39PWIIA== X-Received: by 2002:a17:90b:2f8e:b0:33b:c5f6:40ec with SMTP id 98e67ed59e1d1-33bcf914840mr3603295a91.30.1760700874068; Fri, 17 Oct 2025 04:34:34 -0700 (PDT) Received: from localhost ([2804:30c:402b:1a00:ec78:db53:a246:207a]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-7992bc13543sm25483583b3a.35.2025.10.17.04.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 04:34:33 -0700 (PDT) Date: Fri, 17 Oct 2025 08:35:38 -0300 From: Marcelo Schmitt To: David Lechner Cc: Marcelo Schmitt , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, jic23@kernel.org, michael.hennerich@analog.com, nuno.sa@analog.com, eblanc@baylibre.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net, Trevor Gamblin , Axel Haslam Subject: Re: [PATCH v5 5/7] iio: adc: ad4030: Add SPI offload support Message-ID: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 10/16, David Lechner wrote: > On 10/14/25 5:22 PM, Marcelo Schmitt wrote: > > AD4030 and similar ADCs can capture data at sample rates up to 2 mega > > samples per second (MSPS). Not all SPI controllers are able to achieve such > > high throughputs and even when the controller is fast enough to run > > transfers at the required speed, it may be costly to the CPU to handle > > transfer data at such high sample rates. Add SPI offload support for AD4030 > > and similar ADCs to enable data capture at maximum sample rates. > > > > Co-developed-by: Trevor Gamblin > > Signed-off-by: Trevor Gamblin > > Co-developed-by: Axel Haslam > > Signed-off-by: Axel Haslam > > Signed-off-by: Marcelo Schmitt > > --- > > Change log v4 -> v5 > > - Made Kconfig entry depend on PWM and select other features. > > - Reused ad4030_exit_config_mode() in ad4030_offload_buffer_postenable(). > > - Dropped common-mode voltage support on SPI offload setup. > > Curious why you chose this. I guess it will be fine to add it later > if anyone ever actually needs it. > I had coded that in a way I think would work for the dual channel devices, but it didn't really work for single-channel adaq4216. And yes, if anyone asks for offload with common-mode data, we shall probably be able to it that later. > > - Adjusted offload trigger period calculation. > > - No longer setting data frame mode from ad4030_set_avg_frame_len(). > > - Rearranged code to reduce patch diff. > > > > drivers/iio/adc/Kconfig | 5 + > > drivers/iio/adc/ad4030.c | 425 +++++++++++++++++++++++++++++++++++++-- > > 2 files changed, 416 insertions(+), 14 deletions(-) > > > > ... > > > @@ -512,11 +643,30 @@ static int ad4030_set_avg_frame_len(struct iio_dev *dev, int avg_val) > > struct ad4030_state *st = iio_priv(dev); > > unsigned int avg_log2 = ilog2(avg_val); > > unsigned int last_avg_idx = ARRAY_SIZE(ad4030_average_modes) - 1; > > + int freq_hz; > > int ret; > > > > if (avg_val < 0 || avg_val > ad4030_average_modes[last_avg_idx]) > > return -EINVAL; > > > > + if (st->offload_trigger) { > > + /* > > + * The sample averaging and sampling frequency configurations > > + * are mutually dependent one from another. That's because the > > s/one from another/on each other/ > > "one from another" makes it sound like they are independent rather than > dependent. Ack. > > > + * effective data sample rate is fCNV / 2^N, where N is the > > + * number of samples being averaged. > > + * > > + * When SPI offload is supported and we have control over the > > + * sample rate, the conversion start signal (CNV) and the SPI > > + * offload trigger frequencies must be re-evaluated so data is > > + * fetched only after 'avg_val' conversions. > > + */ > > + ad4030_get_sampling_freq(st, &freq_hz); > > + ret = ad4030_update_conversion_rate(st, freq_hz, avg_log2); > > + if (ret) > > + return ret; > > + } > > + > LGTM. > > Reviewed-by: David Lechner > Thanks, Marcelo