devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux
@ 2025-09-10 23:34 Fabio Estevam
  2025-09-11  1:14 ` Frank Li
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2025-09-10 23:34 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, devicetree, imx, linux-arm-kernel,
	frank.li, Fabio Estevam

On i.MX6Q/6DL the following subnodes exist to describe the CSI port muxing:

- ipu1_csi0_mux
- ipu1_csi1_mux
- ipu2_csi0_mux
- ipu2_csi1_mux

As they were not documented, dt-schema emits warnings like:

  'ipu1_csi0_mux', 'ipu1_csi1_mux' do not match any of the regexes:
  '^pinctrl-[0-9]+$'

Add a top-level patternProperties entry for these CSI mux subnodes
and restrict it to i.MX6Q.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Restrict it to i.MX6Q (Frank).

 .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml     | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
index 8451cb4dd87c..719de0489002 100644
--- a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
@@ -50,6 +50,22 @@ properties:
     type: object
     $ref: /schemas/mux/reg-mux.yaml
 
+patternProperties:
+  "^ipu[12]_csi[01]_mux$":
+    type: object
+    $ref: /schemas/media/video-mux.yaml
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              const: fsl,imx6q-iomuxc-gpr
+    then:
+      patternProperties:
+        '^ipu[12]_csi[01]_mux$': false
+
 additionalProperties: false
 
 required:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux
  2025-09-10 23:34 [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux Fabio Estevam
@ 2025-09-11  1:14 ` Frank Li
  2025-09-15  0:31 ` Rob Herring (Arm)
  2025-10-20 11:58 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2025-09-11  1:14 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh, krzk+dt, conor+dt, devicetree, imx,
	linux-arm-kernel

On Wed, Sep 10, 2025 at 08:34:02PM -0300, Fabio Estevam wrote:
> On i.MX6Q/6DL the following subnodes exist to describe the CSI port muxing:
>
> - ipu1_csi0_mux
> - ipu1_csi1_mux
> - ipu2_csi0_mux
> - ipu2_csi1_mux
>
> As they were not documented, dt-schema emits warnings like:
>
>   'ipu1_csi0_mux', 'ipu1_csi1_mux' do not match any of the regexes:
>   '^pinctrl-[0-9]+$'
>
> Add a top-level patternProperties entry for these CSI mux subnodes
> and restrict it to i.MX6Q.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> Changes since v1:
> - Restrict it to i.MX6Q (Frank).
>
>  .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml     | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> index 8451cb4dd87c..719de0489002 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> @@ -50,6 +50,22 @@ properties:
>      type: object
>      $ref: /schemas/mux/reg-mux.yaml
>
> +patternProperties:
> +  "^ipu[12]_csi[01]_mux$":
> +    type: object
> +    $ref: /schemas/media/video-mux.yaml
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          not:
> +            contains:
> +              const: fsl,imx6q-iomuxc-gpr
> +    then:
> +      patternProperties:
> +        '^ipu[12]_csi[01]_mux$': false
> +
>  additionalProperties: false
>
>  required:
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux
  2025-09-10 23:34 [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux Fabio Estevam
  2025-09-11  1:14 ` Frank Li
@ 2025-09-15  0:31 ` Rob Herring (Arm)
  2025-10-20 11:58 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-09-15  0:31 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: imx, conor+dt, shawnguo, krzk+dt, linux-arm-kernel, frank.li,
	devicetree


On Wed, 10 Sep 2025 20:34:02 -0300, Fabio Estevam wrote:
> On i.MX6Q/6DL the following subnodes exist to describe the CSI port muxing:
> 
> - ipu1_csi0_mux
> - ipu1_csi1_mux
> - ipu2_csi0_mux
> - ipu2_csi1_mux
> 
> As they were not documented, dt-schema emits warnings like:
> 
>   'ipu1_csi0_mux', 'ipu1_csi1_mux' do not match any of the regexes:
>   '^pinctrl-[0-9]+$'
> 
> Add a top-level patternProperties entry for these CSI mux subnodes
> and restrict it to i.MX6Q.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Restrict it to i.MX6Q (Frank).
> 
>  .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml     | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux
  2025-09-10 23:34 [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux Fabio Estevam
  2025-09-11  1:14 ` Frank Li
  2025-09-15  0:31 ` Rob Herring (Arm)
@ 2025-10-20 11:58 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2025-10-20 11:58 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh, krzk+dt, conor+dt, devicetree, imx,
	linux-arm-kernel, frank.li

On Wed, Sep 10, 2025 at 08:34:02PM -0300, Fabio Estevam wrote:
> On i.MX6Q/6DL the following subnodes exist to describe the CSI port muxing:
> 
> - ipu1_csi0_mux
> - ipu1_csi1_mux
> - ipu2_csi0_mux
> - ipu2_csi1_mux
> 
> As they were not documented, dt-schema emits warnings like:
> 
>   'ipu1_csi0_mux', 'ipu1_csi1_mux' do not match any of the regexes:
>   '^pinctrl-[0-9]+$'
> 
> Add a top-level patternProperties entry for these CSI mux subnodes
> and restrict it to i.MX6Q.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-10-20 11:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 23:34 [PATCH v2] dt-bindings: soc: imx-iomuxc-gpr: Document the CSI mux Fabio Estevam
2025-09-11  1:14 ` Frank Li
2025-09-15  0:31 ` Rob Herring (Arm)
2025-10-20 11:58 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).