* [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
@ 2025-08-27 19:49 Frank Li
2025-08-28 14:53 ` Vladimir Zapolskiy
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Frank Li @ 2025-08-27 19:49 UTC (permalink / raw)
To: Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
additionalProperties with unevaluatedProperties to allow use common
properties.
Fix below CHECK_DTBS warnings:
arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
index 634d3b821b8c7..ec5c40684b6bd 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
@@ -58,7 +58,7 @@ properties:
properties:
endpoint:
$ref: /schemas/media/video-interfaces.yaml#
- additionalProperties: false
+ unevaluatedProperties: false
properties:
link-frequencies: true
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
@ 2025-08-28 14:53 ` Vladimir Zapolskiy
2025-08-28 18:36 ` Rui Miguel Silva
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Vladimir Zapolskiy @ 2025-08-28 14:53 UTC (permalink / raw)
To: Frank Li, Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 8/27/25 22:49, Frank Li wrote:
> The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> additionalProperties with unevaluatedProperties to allow use common
> properties.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> index 634d3b821b8c7..ec5c40684b6bd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> @@ -58,7 +58,7 @@ properties:
> properties:
> endpoint:
> $ref: /schemas/media/video-interfaces.yaml#
> - additionalProperties: false
> + unevaluatedProperties: false
>
> properties:
> link-frequencies: true
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
2025-08-28 14:53 ` Vladimir Zapolskiy
@ 2025-08-28 18:36 ` Rui Miguel Silva
2025-08-29 16:52 ` Rob Herring (Arm)
2025-10-21 9:00 ` Sakari Ailus
3 siblings, 0 replies; 7+ messages in thread
From: Rui Miguel Silva @ 2025-08-28 18:36 UTC (permalink / raw)
To: Frank Li, Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Hi Frank,
Thanks for the patch.
On Wed Aug 27, 2025 at 8:49 PM WEST, Frank Li wrote:
> The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> additionalProperties with unevaluatedProperties to allow use common
> properties.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
LGTM.
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Cheers,
Rui
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> index 634d3b821b8c7..ec5c40684b6bd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> @@ -58,7 +58,7 @@ properties:
> properties:
> endpoint:
> $ref: /schemas/media/video-interfaces.yaml#
> - additionalProperties: false
> + unevaluatedProperties: false
>
> properties:
> link-frequencies: true
> --
> 2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
2025-08-28 14:53 ` Vladimir Zapolskiy
2025-08-28 18:36 ` Rui Miguel Silva
@ 2025-08-29 16:52 ` Rob Herring (Arm)
2025-10-21 9:00 ` Sakari Ailus
3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring (Arm) @ 2025-08-29 16:52 UTC (permalink / raw)
To: Frank Li
Cc: Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
Rui Miguel Silva, devicetree, Hans de Goede, imx, linux-kernel,
linux-media
On Wed, 27 Aug 2025 15:49:18 -0400, Frank Li wrote:
> The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> additionalProperties with unevaluatedProperties to allow use common
> properties.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
` (2 preceding siblings ...)
2025-08-29 16:52 ` Rob Herring (Arm)
@ 2025-10-21 9:00 ` Sakari Ailus
2025-10-21 15:39 ` Frank Li
3 siblings, 1 reply; 7+ messages in thread
From: Sakari Ailus @ 2025-10-21 9:00 UTC (permalink / raw)
To: Frank Li
Cc: Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
Hi Frank,
On Wed, Aug 27, 2025 at 03:49:18PM -0400, Frank Li wrote:
> The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> additionalProperties with unevaluatedProperties to allow use common
> properties.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> index 634d3b821b8c7..ec5c40684b6bd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> @@ -58,7 +58,7 @@ properties:
> properties:
> endpoint:
> $ref: /schemas/media/video-interfaces.yaml#
> - additionalProperties: false
> + unevaluatedProperties: false
There are a lot more than just data-lanes in video-interfaces.yaml.
Could you instead drop data-lanes and clock-lanes from the bindings? They
are redundant.
>
> properties:
> link-frequencies: true
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-10-21 9:00 ` Sakari Ailus
@ 2025-10-21 15:39 ` Frank Li
2025-10-22 6:59 ` Sakari Ailus
0 siblings, 1 reply; 7+ messages in thread
From: Frank Li @ 2025-10-21 15:39 UTC (permalink / raw)
To: Sakari Ailus
Cc: Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Tue, Oct 21, 2025 at 12:00:09PM +0300, Sakari Ailus wrote:
> Hi Frank,
>
> On Wed, Aug 27, 2025 at 03:49:18PM -0400, Frank Li wrote:
> > The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> > additionalProperties with unevaluatedProperties to allow use common
> > properties.
> >
> > Fix below CHECK_DTBS warnings:
> > arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> > from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > index 634d3b821b8c7..ec5c40684b6bd 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > @@ -58,7 +58,7 @@ properties:
> > properties:
> > endpoint:
> > $ref: /schemas/media/video-interfaces.yaml#
> > - additionalProperties: false
> > + unevaluatedProperties: false
>
> There are a lot more than just data-lanes in video-interfaces.yaml.
>
> Could you instead drop data-lanes and clock-lanes from the bindings? They
> are redundant.
What's your means? drop data-lanes and clock-lanes from the dts file?
The board design may use less data-lanes, why it is reduntant?
Frank
>
> >
> > properties:
> > link-frequencies: true
>
> --
> Kind regards,
>
> Sakari Ailus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-10-21 15:39 ` Frank Li
@ 2025-10-22 6:59 ` Sakari Ailus
0 siblings, 0 replies; 7+ messages in thread
From: Sakari Ailus @ 2025-10-22 6:59 UTC (permalink / raw)
To: Frank Li
Cc: Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
Hi Frank,
On Tue, Oct 21, 2025 at 11:39:49AM -0400, Frank Li wrote:
> On Tue, Oct 21, 2025 at 12:00:09PM +0300, Sakari Ailus wrote:
> > Hi Frank,
> >
> > On Wed, Aug 27, 2025 at 03:49:18PM -0400, Frank Li wrote:
> > > The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> > > additionalProperties with unevaluatedProperties to allow use common
> > > properties.
> > >
> > > Fix below CHECK_DTBS warnings:
> > > arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> > > from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > > index 634d3b821b8c7..ec5c40684b6bd 100644
> > > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> > > @@ -58,7 +58,7 @@ properties:
> > > properties:
> > > endpoint:
> > > $ref: /schemas/media/video-interfaces.yaml#
> > > - additionalProperties: false
> > > + unevaluatedProperties: false
> >
> > There are a lot more than just data-lanes in video-interfaces.yaml.
> >
> > Could you instead drop data-lanes and clock-lanes from the bindings? They
> > are redundant.
>
> What's your means? drop data-lanes and clock-lanes from the dts file?
>
> The board design may use less data-lanes, why it is reduntant?
That would be no data lanes at all then. The sensor supports a single lane
only, which is why data-lanes isn't listed as a property in bindings.
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-10-22 6:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
2025-08-28 14:53 ` Vladimir Zapolskiy
2025-08-28 18:36 ` Rui Miguel Silva
2025-08-29 16:52 ` Rob Herring (Arm)
2025-10-21 9:00 ` Sakari Ailus
2025-10-21 15:39 ` Frank Li
2025-10-22 6:59 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).