From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] media: i2c: add Samsung S5KJN1 image sensor device driver
Date: Tue, 21 Oct 2025 12:25:43 +0300 [thread overview]
Message-ID: <aPdRlygxV1TCCUU3@kekkonen.localdomain> (raw)
In-Reply-To: <20251016020419.2137290-3-vladimir.zapolskiy@linaro.org>
Hi Vladimir,
On Thu, Oct 16, 2025 at 05:04:19AM +0300, Vladimir Zapolskiy wrote:
> + { S5KJN1_REG_X_ADDR_START, 0x0000 },
> + { S5KJN1_REG_Y_ADDR_START, 0x0000 },
> + { S5KJN1_REG_X_ADDR_END, 0x1fff },
> + { S5KJN1_REG_Y_ADDR_END, 0x181f },
> + { S5KJN1_REG_X_OUTPUT_SIZE, 0x0ff0 },
> + { S5KJN1_REG_Y_OUTPUT_SIZE, 0x0c00 },
> + { CCI_REG16(0x0350), 0x0008 },
> + { CCI_REG16(0x0352), 0x0008 },
> + { CCI_REG16(0x0900), 0x0122 },
> + { CCI_REG16(0x0380), 0x0002 },
> + { CCI_REG16(0x0382), 0x0002 },
> + { CCI_REG16(0x0384), 0x0002 },
> + { CCI_REG16(0x0386), 0x0002 },
> + { CCI_REG16(0x0110), 0x1002 },
> + { CCI_REG16(0x0114), 0x0301 },
> + { CCI_REG16(0x0116), 0x3000 },
> +
> + /* Clock settings */
> + { CCI_REG16(0x0136), 0x1800 },
> + { CCI_REG16(0x013e), 0x0000 },
> + { CCI_REG16(0x0300), 0x0006 },
> + { CCI_REG16(0x0302), 0x0001 },
> + { CCI_REG16(0x0304), 0x0004 },
> + { CCI_REG16(0x0306), 0x008c },
> + { CCI_REG16(0x0308), 0x0008 },
> + { CCI_REG16(0x030a), 0x0001 },
> + { CCI_REG16(0x030c), 0x0000 },
> + { CCI_REG16(0x030e), 0x0004 },
> + { CCI_REG16(0x0310), 0x0092 },
> + { CCI_REG16(0x0312), 0x0000 },
> +
> + { CCI_REG16(0x080e), 0x0000 },
> + { S5KJN1_REG_VTS, 0x10c0 },
> + { S5KJN1_REG_HTS, 0x1100 },
> + { CCI_REG16(0x0702), 0x0000 },
> + { S5KJN1_REG_EXPOSURE, 0x0100 },
> + { CCI_REG16(0x0200), 0x0100 },
> + { CCI_REG16(0x0d00), 0x0101 },
> + { CCI_REG16(0x0d02), 0x0101 },
> + { CCI_REG16(0x0d04), 0x0102 },
> + { CCI_REG16(0x6226), 0x0000 },
> + { CCI_REG16(0x0816), 0x1c00 },
This looks interestingly CCS compliant. It might be worth taking the MSRs
and trying with the CCS driver.
Where is this sensor found?
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2025-10-21 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 2:04 [PATCH v2 0/2] media: i2c: add Samsung S5KJN1 image sensor device driver Vladimir Zapolskiy
2025-10-16 2:04 ` [PATCH v2 1/2] dt-bindings: media: i2c: Add Samsung S5KJN1 image sensor Vladimir Zapolskiy
2025-10-20 20:23 ` Sakari Ailus
2025-10-21 8:00 ` Vladimir Zapolskiy
2025-10-21 9:10 ` Sakari Ailus
2025-10-21 10:23 ` Vladimir Zapolskiy
2025-10-22 8:32 ` Sakari Ailus
2025-10-16 2:04 ` [PATCH v2 2/2] media: i2c: add Samsung S5KJN1 image sensor device driver Vladimir Zapolskiy
2025-10-21 9:25 ` Sakari Ailus [this message]
2025-10-21 10:16 ` Vladimir Zapolskiy
2025-10-22 8:31 ` Sakari Ailus
2025-10-22 8:45 ` Sakari Ailus
2025-10-23 0:13 ` Vladimir Zapolskiy
2025-10-23 11:43 ` Sakari Ailus
2025-10-23 15:54 ` [PATCH v2 0/2] " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPdRlygxV1TCCUU3@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=hverkuil@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox