From: Pavel Machek <pavel@ucw.cz>
To: guptarud@gmail.com
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys
Date: Wed, 22 Oct 2025 13:13:18 +0200 [thread overview]
Message-ID: <aPi8TsoarXJXvKuz@duo.ucw.cz> (raw)
In-Reply-To: <20250929-ppp_light_accel_mag_vol-down-v4-4-6598f22d3451@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
Hi!
> From: Ondrej Jirman <megi@xff.cz>
>
> Previously sometimes pressing the volume-down button would register as
> a volume-up button. Match the thresholds as shown in the Pinephone Pro
> schematic.
>
> Tests:
>
> ~ $ evtest
> // Mashed the volume down ~100 times with varying intensity
> Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1
> Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0
> // Mashed the volume up ~100 times with varying intensity
> Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 1
> Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 0
>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
BR,
Pavel
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2025-10-22 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 7:35 [PATCH v4 0/4] Upstreaming Pinephone Pro Patches Rudraksha Gupta via B4 Relay
2025-09-29 7:35 ` [PATCH v4 1/4] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support Rudraksha Gupta via B4 Relay
2025-09-29 9:57 ` Diederik de Haas
2025-10-07 5:59 ` Rudraksha Gupta
2025-09-29 7:35 ` [PATCH v4 2/4] arm64: dts: rk3399-pinephone-pro: Add accelerometer " Rudraksha Gupta via B4 Relay
2025-10-22 11:11 ` Pavel Machek
2025-09-29 7:35 ` [PATCH v4 3/4] arm64: dts: rk3399-pinephone-pro: Add magnetometer " Rudraksha Gupta via B4 Relay
2025-10-22 11:12 ` Pavel Machek
2025-09-29 7:35 ` [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys Rudraksha Gupta via B4 Relay
2025-10-22 11:13 ` Pavel Machek [this message]
2025-09-29 8:32 ` [PATCH v4 0/4] Upstreaming Pinephone Pro Patches Dragan Simic
2025-09-29 15:39 ` Heiko Stuebner
2025-10-07 5:56 ` Rudraksha Gupta
2025-10-22 11:09 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPi8TsoarXJXvKuz@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=megi@xff.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).