From: Johan Hovold <johan@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Richard Genoud" <richard.genoud@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Wentao Liang" <vulab@iscas.ac.cn>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/15] mtd: rawnand: sunxi: introduce reg_user_data in sunxi_nfc_caps
Date: Wed, 22 Oct 2025 11:07:35 +0200 [thread overview]
Message-ID: <aPie167O32Jc6BHw@hovoldconsulting.com> (raw)
In-Reply-To: <87y0p3tiz9.fsf@bootlin.com>
On Wed, Oct 22, 2025 at 10:54:02AM +0200, Miquel Raynal wrote:
> On 20/10/2025 at 12:13:00 +02, Richard Genoud <richard.genoud@bootlin.com> wrote:
> > @@ -723,8 +726,8 @@ static void sunxi_nfc_hw_ecc_get_prot_oob_bytes(struct nand_chip *nand, u8 *oob,
> > {
> > struct sunxi_nfc *nfc = to_sunxi_nfc(nand->controller);
> >
> > - sunxi_nfc_user_data_to_buf(readl(nfc->regs + NFC_REG_USER_DATA(step)),
> > - oob);
> > + sunxi_nfc_user_data_to_buf(readl(nfc->regs +
> > + NFC_REG_USER_DATA(nfc, step)),
> > oob);
>
> Minor nit, column limit is 100 now, so typically for this kind of
> situation everything would fit on a single line.
Just a drive-by comment:
The preferred limit is still 80 chars, unless exceeding it significantly
increases readability.
I guess here such an exception may be warranted.
Johan
next prev parent reply other threads:[~2025-10-22 9:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 10:12 [PATCH v3 00/15] Introduce Allwinner H6/H616 NAND controller support Richard Genoud
2025-10-20 10:12 ` [PATCH v3 01/15] mtd: rawnand: sunxi: Remove superfluous register readings Richard Genoud
2025-10-20 10:12 ` [PATCH v3 02/15] mtd: rawnand: sunxi: move ECC strenghts in sunxi_nfc_caps Richard Genoud
2025-10-20 10:12 ` [PATCH v3 03/15] mtd: rawnand: sunxi: introduce reg_ecc_err_cnt " Richard Genoud
2025-10-20 10:13 ` [PATCH v3 04/15] mtd: rawnand: sunxi: introduce reg_user_data " Richard Genoud
2025-10-22 8:54 ` Miquel Raynal
2025-10-22 9:07 ` Johan Hovold [this message]
2025-10-24 7:20 ` Richard GENOUD
2025-10-20 10:13 ` [PATCH v3 05/15] mtd: rawnand: sunxi: rework pattern found registers Richard Genoud
2025-10-22 9:02 ` Miquel Raynal
2025-10-22 10:05 ` Geert Uytterhoeven
2025-10-20 10:13 ` [PATCH v3 06/15] mtd: rawnand: sunxi: add has_ecc_block_512 capability Richard Genoud
2025-10-20 10:13 ` [PATCH v3 07/15] mtd: rawnand: sunxi: introduce ecc_mode_mask in sunxi_nfc_caps Richard Genoud
2025-10-22 9:05 ` Miquel Raynal
2025-10-24 7:52 ` Richard GENOUD
2025-10-20 10:13 ` [PATCH v3 08/15] mtd: rawnand: sunxi: introduce random en/dir " Richard Genoud
2025-10-20 10:13 ` [PATCH v3 09/15] mtd: rawnand: sunxi: introduce reg_pat_id " Richard Genoud
2025-10-20 10:13 ` [PATCH v3 10/15] mtd: rawnand: sunxi: introduce reg_spare_area " Richard Genoud
2025-10-20 10:13 ` [PATCH v3 11/15] mtd: rawnand: sunxi: introduce ecc_err_mask " Richard Genoud
2025-10-20 10:13 ` [PATCH v3 12/15] mtd: rawnand: sunxi: introduce sram_size " Richard Genoud
2025-10-20 10:13 ` [PATCH v3 13/15] mtd: rawnand: sunxi: Add support for H616 nand controller Richard Genoud
2025-10-22 9:18 ` Miquel Raynal
2025-10-28 7:30 ` Richard GENOUD
2025-10-20 10:13 ` [PATCH v3 14/15] dt-bindings: mtd: sunxi: Add H616 compatible Richard Genoud
2025-10-20 17:18 ` Conor Dooley
2025-10-22 9:20 ` Miquel Raynal
2025-10-24 9:08 ` Richard GENOUD
2025-10-20 10:13 ` [PATCH v3 15/15] arm64: dts: allwinner: h616: add NAND controller Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPie167O32Jc6BHw@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=richard.genoud@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vigneshr@ti.com \
--cc=vulab@iscas.ac.cn \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).