From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 771142D9784; Thu, 23 Oct 2025 09:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761212679; cv=none; b=oSAh7KXHU3+QRJjIM8wC11b4NipnuluNqEUQ7oT2VKr7SVj+ULRtxprkeVkIeL5VlF76BHlq+joPGoYEqLNkmSTB594vYLLMk27c3nulmlED6OeBBmQmDXZG6j3zU0pYnR9Sld/IRevp64eEgEgTwGp54p/QkH8w6chCXn5tSfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761212679; c=relaxed/simple; bh=5x8jLsSxghG7IaRrLPPl0lFfXXLzEE7sGy+TAsSxs/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XvLOsxvChgbUIWQUfEFQ3SyBUW2fOkyF9++MLfA005BH2Ca41R9NF4hhQDTBbmw3K3k01wP32wu07DViBFR+YJ4rw5wf5yP0NJY54bwPN8V2bh14Q39fkAZ5/0EPnCUiM5+mUdA7/Nj3YIGxFtV4pgvU4Vpnn5GGbKv+GVNVqJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D7gMHjC9; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D7gMHjC9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761212678; x=1792748678; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5x8jLsSxghG7IaRrLPPl0lFfXXLzEE7sGy+TAsSxs/Y=; b=D7gMHjC9QJZkPcEehLGajenWIKg6nz5fvJkCe0o/A/t+xl7cTZSXv0uv TNaudOoNaGKGS7nrOz9ndqWD3rwcYuXoVgpjH9Extp0V9acpUTk4hUPTd 54458aO7kXVQUK71hIf8j+qmjonPXacFJ7V96ttwO+W+32Q56zV+aH678 FhchFn2Z06RiG+8m0vsx6OreKu7VmvQB8irNKaIR8ZjfSJ8oRd5yeLLti S011ul0n+gtBiKKmbVAVclfI8KiRltrZZJA3tdcm0VlN7amijzgL4fY0c hHI+tObYrdVed1qJ+o1kr7vdj5GUPQLVYuOJRBTOIdU/fWKXVoDU6T9YK Q==; X-CSE-ConnectionGUID: 2ijdlID+T5+Q0WxjEdYI3w== X-CSE-MsgGUID: +X843B9VQK6plg2J0Yat7w== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="80814390" X-IronPort-AV: E=Sophos;i="6.19,249,1754982000"; d="scan'208";a="80814390" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2025 02:44:37 -0700 X-CSE-ConnectionGUID: iLOeuevISgC6L9OMMBEeEA== X-CSE-MsgGUID: YhP6hwNSQqC/F6AV1drOTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,249,1754982000"; d="scan'208";a="221305921" Received: from bkammerd-mobl.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.221.165]) by orviesa001.jf.intel.com with SMTP; 23 Oct 2025 02:44:26 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 23 Oct 2025 12:44:25 +0300 Date: Thu, 23 Oct 2025 12:44:25 +0300 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions Message-ID: References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Oct 23, 2025 at 12:04:44PM +0300, Heikki Krogerus wrote: > On Thu, Oct 23, 2025 at 11:10:20AM +0300, Heikki Krogerus wrote: > > Hi, > > > > > diff --git a/include/linux/usb/typec_notify.h b/include/linux/usb/typec_notify.h > > > new file mode 100644 > > > index 000000000000..a3f1f3b3ae47 > > > --- /dev/null > > > +++ b/include/linux/usb/typec_notify.h > > > @@ -0,0 +1,17 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > + > > > +#ifndef __USB_TYPEC_NOTIFY > > > +#define __USB_TYPEC_NOTIFY > > > + > > > +#include > > > + > > > +enum usb_typec_event { > > > + TYPEC_ALTMODE_REGISTERED > > > +}; > > > > Don't you need to know when the altmode is removed? > > I noticed that you don't because drm_dp_hpd_bridge_register() is > always resource managed. But I think you could still send an event > also when the altmode is removed already now. That way it does not > need to be separately added if and when it is needed. Hold on! Every bus has already a notifier chain. That's the one that we should also use. Sorry for not noticing that earlier. So let's just export the bus type in this patch - you can then use bus_register_notifier() in your driver: diff --git a/drivers/usb/typec/bus.c b/drivers/usb/typec/bus.c index a884cec9ab7e..65ded9e3cdaa 100644 --- a/drivers/usb/typec/bus.c +++ b/drivers/usb/typec/bus.c @@ -547,3 +547,4 @@ const struct bus_type typec_bus = { .probe = typec_probe, .remove = typec_remove, }; +EXPORT_SYMBOL_GPL(typec_bus); diff --git a/drivers/usb/typec/bus.h b/drivers/usb/typec/bus.h index 643b8c81786d..af9edb3db9d0 100644 --- a/drivers/usb/typec/bus.h +++ b/drivers/usb/typec/bus.h @@ -5,7 +5,6 @@ #include -struct bus_type; struct typec_mux; struct typec_retimer; @@ -28,7 +27,6 @@ struct altmode { #define to_altmode(d) container_of(d, struct altmode, adev) -extern const struct bus_type typec_bus; extern const struct device_type typec_altmode_dev_type; #define is_typec_altmode(_dev_) (_dev_->type == &typec_altmode_dev_type) diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h index 309251572e2e..c6fd46902fce 100644 --- a/include/linux/usb/typec.h +++ b/include/linux/usb/typec.h @@ -20,12 +20,15 @@ struct typec_port; struct typec_altmode_ops; struct typec_cable_ops; +struct bus_type; struct fwnode_handle; struct device; struct usb_power_delivery; struct usb_power_delivery_desc; +extern const struct bus_type typec_bus; + enum typec_port_type { TYPEC_PORT_SRC, TYPEC_PORT_SNK, thanks, -- heikki