From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A4E2EBBAD; Fri, 24 Oct 2025 07:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761291834; cv=none; b=C8cJrCzn10tpfT7VX3BjQ42uXzFIKWTuLd608kdtZMZ2aqFtFekIkDzpkM29T9jkbnB1mO9Kr+sm7/O0vChs25p/K5yjf732kevclQ0fN2pJHGwh/bV66XP+l55Fm+OedlwMm58sM5ItDre0nZp8hpy8NRHmNWYE6RA9SO0GqLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761291834; c=relaxed/simple; bh=7zI+yHusBy8iTPtjWgljU0yIp25yZuoATyi6HBS0Rz0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tS5DtIj0Ij7Uh3SZ0wUNW5fy37E5QrmLj37seC8nXs+sEuJr4v1ZBUwnuJXX0JHV/afjAilRs0FuxgmjKMn1VyI93sipEv0+wQNOSJdPAx7x+apxaszyfBmP52clLAh+MboBMlD3PeIFOqYr1A0OKpTnil0N0zZVI6B9r8J98A8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MYVxx0a2; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MYVxx0a2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761291834; x=1792827834; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=7zI+yHusBy8iTPtjWgljU0yIp25yZuoATyi6HBS0Rz0=; b=MYVxx0a2OQpZWdBgpo9e4Cef7zbGfhKHW/ahkUajssE8TrJaNZxvLMsz iYFLWZBwiMCS5IQK24S9kX0fuxK4grlriS5k4oh/YvGlMfvSZeVniHfCm WGBrkeGyTRFKz/iXpJCKJWbzapyEMy9Q72lb/+AvlHVJwOAeTBlpsy+E2 uzGo0XJNeyokcxfa3c0PEEPbSyqdGckAh3KHorzIr+zfhumOYqG474YEe Qhg75s9elFXKSVjFg/jws3bCtfrtDm7yTGTNGojhuxHOT1wcDIpgqnu0e 8UfkqJ8W0uicwU6cj9c6F6cumcAiTvUnbOXcWpwW4r6PWOaRpw3pnuPFa Q==; X-CSE-ConnectionGUID: 0b45EmyKSsGExL3d20I2mA== X-CSE-MsgGUID: x48DdNPRSxqXNJTYsegM6A== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="63618993" X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="63618993" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2025 00:43:53 -0700 X-CSE-ConnectionGUID: u3ao3ZWfTCKvdTwCgNOZbQ== X-CSE-MsgGUID: i6w9uVJtSDy1AqasQ83mFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="188756837" Received: from mjruhl-desk.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.221.255]) by fmviesa005.fm.intel.com with SMTP; 24 Oct 2025 00:43:42 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 24 Oct 2025 10:43:41 +0300 Date: Fri, 24 Oct 2025 10:43:41 +0300 From: Heikki Krogerus To: Chaoyi Chen Cc: Chaoyi Chen , Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions Message-ID: References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> <3a24bd7f-c247-4541-8cf5-c1e66e2af5a0@rock-chips.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3a24bd7f-c247-4541-8cf5-c1e66e2af5a0@rock-chips.com> > I noticed the following statement in typec_register_altmode(): > > ``` > >     /* The partners are bind to drivers */ >     if (is_typec_partner(parent)) >         alt->adev.dev.bus = &typec_bus; > > ``` > > If the condition is not met, the bus will not be set, which means bus_notify() > won't be able to take effect. Did I miss something? Right, that would be the condition that I was talking about. Only partner altmodes are used in the bus. Hold on! Do you need the port altmode instead of the partner altmode? If that's the case, then we can't use the bus notifier. So we'll need the separate notifier chain after all. Let me take a closer look at patch 2/9. Sorry about the hassle. -- heikki