From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
BMC-SW <BMC-SW@aspeedtech.com>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andi.shyti@kernel.org" <andi.shyti@kernel.org>,
"jk@codeconstruct.com.au" <jk@codeconstruct.com.au>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"andrew@codeconstruct.com.au" <andrew@codeconstruct.com.au>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"naresh.solanki@9elements.com" <naresh.solanki@9elements.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v21 3/4] i2c: ast2600: Add controller driver for new register layout
Date: Fri, 7 Nov 2025 11:42:39 +0200 [thread overview]
Message-ID: <aQ2_D6vs4m1brNk0@smile.fi.intel.com> (raw)
In-Reply-To: <TY2PPF5CB9A1BE64FEBCCCDC7631B355135F2C3A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
On Fri, Nov 07, 2025 at 06:26:39AM +0000, Ryan Chen wrote:
> > On 27/10/2025 07:12, Ryan Chen wrote:
...
> Add new file i2c-aspeed-core.c to do legacy probe and i2c-ast2600 probe.
>
> if (of_device_is_compatible(dev_of_node(dev), "aspeed,ast2600-i2c-bus") &&
if (device_is_compatible(dev, "aspeed,ast2600-i2c-bus") &&
> of_parse_phandle(dev_of_node(dev), "aspeed,global-regs", 0)) {
Not sure why do you need this. Isn't it as simple as
device_property_present(dev, "aspeed,global-regs", 0)) {
or something between these lines?
> ret = ast2600_i2c_probe(pdev);
> } else {
> ret = aspeed_i2c_probe(pdev);
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-07 9:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 6:12 [PATCH v21 0/4] Add ASPEED AST2600 I2C controller driver Ryan Chen
2025-10-27 6:12 ` [PATCH v21 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML Ryan Chen
2025-10-27 19:11 ` Krzysztof Kozlowski
2025-10-30 6:04 ` Jeremy Kerr
2025-11-05 7:04 ` Krzysztof Kozlowski
2025-10-27 6:12 ` [PATCH v21 2/4] dt-bindings: i2c: ast2600-i2c.yaml: Add global-regs and transfer-mode properties Ryan Chen
2025-10-27 19:14 ` Krzysztof Kozlowski
2025-10-28 7:47 ` Krzysztof Kozlowski
2025-10-29 9:25 ` Ryan Chen
2025-10-29 11:19 ` Krzysztof Kozlowski
2025-10-30 1:48 ` Ryan Chen
2025-11-05 7:05 ` Krzysztof Kozlowski
2025-11-07 6:35 ` Ryan Chen
2025-10-27 6:12 ` [PATCH v21 3/4] i2c: ast2600: Add controller driver for new register layout Ryan Chen
2025-10-27 19:24 ` Krzysztof Kozlowski
2025-11-07 6:26 ` Ryan Chen
2025-11-07 9:42 ` andriy.shevchenko [this message]
2025-11-08 3:47 ` Ryan Chen
2025-10-27 6:12 ` [PATCH v21 4/4] i2c: ast2600: Add target mode support Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ2_D6vs4m1brNk0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=BMC-SW@aspeedtech.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=benh@kernel.crashing.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).