Re: [PATCH v5 2/4] backlight: add max25014atg backlighty

Frank Li
2025-11-07T20:42:39Z

On Fri, Nov 07, 2025 at 04:22:33PM +0000, Daniel Thompson wrote:
> On Fri, Nov 07, 2025 at 10:51:11AM -0500, Frank Li wrote:
> > On Fri, Nov 07, 2025 at 01:49:59PM +0100, Maud Spierings via B4 Relay wrote:
> > > From: Maud Spierings <maudspierings@gocontroll.com>
> > >
> > > The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC
> > > with integrated boost controller.
> > >
> > > Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
>
> <snip>
>
> > > +static int max25014_probe(struct i2c_client *cl)
> > > +{
> > > + struct backlight_device *bl;
> > > + const struct i2c_device_id *id = i2c_client_get_device_id(cl);
> > > + struct max25014 *maxim;
> > > + struct backlight_properties props;
> > > + int ret;
> > > + uint32_t initial_brightness = 50;
> >
> > try keep reverise christmas order
>
> I thought reverse christmas tree order only applied to code where the
> maintainers called it out in Development/process (e.g. netdev and tip).

But, but it is small change when you update next version.

Frank
>
>
> Daniel.