From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ajith Anandhan <ajithanandhan0406@gmail.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] iio: adc: Add support for TI ADS1120 ADC
Date: Fri, 31 Oct 2025 10:37:11 +0200 [thread overview]
Message-ID: <aQR1N__AwvPm21tm@smile.fi.intel.com> (raw)
In-Reply-To: <20251030163411.236672-1-ajithanandhan0406@gmail.com>
On Thu, Oct 30, 2025 at 10:04:08PM +0530, Ajith Anandhan wrote:
> This RFC patch series adds support for the Texas Instruments ADS1120,
> a precision 16-bit delta-sigma ADC with SPI interface.
>
> The driver provides:
> - 4 single-ended voltage input channels
> - Programmable gain amplifier (1 to 128)
> - Configurable data rates (20 to 1000 SPS)
> - Single-shot conversion mode
>
> I'm looking for feedback on:
> 1. The implementation approach for single-shot conversions
> 2. Any other suggestions for improvement
>
> Datasheet: https://www.ti.com/lit/gpn/ads1120
The cover letter missed to answer the Q: Why a new driver? Have you checked the
existing drivers? Do we have a similar enough one that may be extended to
support this chip?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-31 8:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 16:34 [RFC PATCH 0/3] iio: adc: Add support for TI ADS1120 ADC Ajith Anandhan
2025-10-30 16:34 ` [RFC PATCH 1/3] dt-bindings: iio: adc: Add TI ADS1120 binding Ajith Anandhan
2025-10-30 17:12 ` Jonathan Cameron
2025-10-30 20:04 ` David Lechner
2025-11-01 12:24 ` Ajith Anandhan
2025-11-01 11:53 ` Ajith Anandhan
2025-10-30 16:34 ` [RFC PATCH 2/3] iio: adc: Add support for TI ADS1120 Ajith Anandhan
2025-10-30 17:54 ` Jonathan Cameron
2025-11-07 14:40 ` Ajith Anandhan
2025-11-09 14:02 ` Jonathan Cameron
2025-10-30 21:13 ` David Lechner
2025-11-07 15:50 ` Ajith Anandhan
2025-11-07 16:18 ` David Lechner
2025-11-09 8:45 ` Ajith Anandhan
2025-10-30 16:34 ` [RFC PATCH 3/3] MAINTAINERS: Add entry for TI ADS1120 ADC driver Ajith Anandhan
2025-10-30 17:55 ` Jonathan Cameron
2025-11-07 13:43 ` Ajith Anandhan
2025-10-30 16:40 ` [RFC PATCH 0/3] iio: adc: Add support for TI ADS1120 ADC Krzysztof Kozlowski
[not found] ` <CABPXPSKzOhGicdPLoMFy8xvd0Xx5_D2P2pduteY3QhDRV4d2Ow@mail.gmail.com>
2025-10-30 16:58 ` Ajith Anandhan
2025-10-30 17:08 ` Jonathan Cameron
2025-10-30 19:44 ` Krzysztof Kozlowski
2025-10-31 8:37 ` Andy Shevchenko [this message]
2025-11-01 11:37 ` Ajith Anandhan
2025-11-03 7:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQR1N__AwvPm21tm@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=ajithanandhan0406@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).