[PATCH v3 1/2] dt-bindings: gpu: mali-valhall-csf: Document i.MX95 support

[PATCH v3 1/2] dt-bindings: gpu: mali-valhall-csf: Document i.MX95 support

[Marek Vasut]

The instance of the GPU populated in Freescale i.MX95 is the
Mali G310, document support for this variant.

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
---
Cc: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Jiyu Yang (OSS) <jiyu.yang@oss.nxp.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Steven Price <steven.price@arm.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Xianzhong Li <xianzhong.li@nxp.com>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
---
V2: - Add RB from Frank and Alexander
    - Make resets: mandatory on i.MX95
    - Switch from fsl, to nxp, vendor prefix
V3: - Add RB from Rob
    - Drop the reset part, this is now unnecessary
---
 Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
index a5b4e00217587..b220cbd5362f4 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
@@ -18,6 +18,7 @@ properties:
     oneOf:
       - items:
           - enum:
+              - nxp,imx95-mali            # G310
               - rockchip,rk3588-mali
           - const: arm,mali-valhall-csf   # Mali Valhall GPU model/revision is fully discoverable
 
-- 
2.51.0

[PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Marek Vasut]

The instance of the GPU populated in i.MX95 is the G310, describe this
GPU in the DT. Include dummy GPU voltage regulator and OPP tables.

Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
---
Cc: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Jiyu Yang (OSS) <jiyu.yang@oss.nxp.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Steven Price <steven.price@arm.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Xianzhong Li <xianzhong.li@nxp.com>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
---
V2: - Drop regulator-{always,boot}-on from fixed-gpu-reg regulator
    - Keep the GPU and GPUMIX always enabled
    - Switch from fsl, to nxp, vendor prefix
    - Fix opp_table to opp-table
    - Describe IMX95_CLK_GPUAPB as coregroup clock
    - Sort interrupts by their names to match bindings
V3: - Drop perf power domain
    - Drop reset block controller
---
 arch/arm64/boot/dts/freescale/imx95.dtsi | 45 ++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
index 1292677cbe4eb..ad47b7f0d173a 100644
--- a/arch/arm64/boot/dts/freescale/imx95.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
@@ -250,6 +250,35 @@ dummy: clock-dummy {
 		clock-output-names = "dummy";
 	};
 
+	gpu_fixed_reg: fixed-gpu-reg {
+		compatible = "regulator-fixed";
+		regulator-min-microvolt = <920000>;
+		regulator-max-microvolt = <920000>;
+		regulator-name = "vdd_gpu";
+	};
+
+	gpu_opp_table: opp-table {
+		compatible = "operating-points-v2";
+
+		opp-500000000 {
+			opp-hz = /bits/ 64 <500000000>;
+			opp-hz-real = /bits/ 64 <500000000>;
+			opp-microvolt = <920000>;
+		};
+
+		opp-800000000 {
+			opp-hz = /bits/ 64 <800000000>;
+			opp-hz-real = /bits/ 64 <800000000>;
+			opp-microvolt = <920000>;
+		};
+
+		opp-1000000000 {
+			opp-hz = /bits/ 64 <1000000000>;
+			opp-hz-real = /bits/ 64 <1000000000>;
+			opp-microvolt = <920000>;
+		};
+	};
+
 	clk_ext1: clock-ext1 {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
@@ -2138,6 +2167,22 @@ netc_emdio: mdio@0,0 {
 			};
 		};
 
+		gpu: gpu@4d900000 {
+			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
+			reg = <0 0x4d900000 0 0x480000>;
+			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
+			clock-names = "core", "coregroup";
+			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			mali-supply = <&gpu_fixed_reg>;
+			operating-points-v2 = <&gpu_opp_table>;
+			power-domains = <&scmi_devpd IMX95_PD_GPU>;
+			#cooling-cells = <2>;
+			dynamic-power-coefficient = <1013>;
+		};
+
 		ddr-pmu@4e090dc0 {
 			compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";
 			reg = <0x0 0x4e090dc0 0x0 0x200>;
-- 
2.51.0

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Frank Li]

On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
> The instance of the GPU populated in i.MX95 is the G310, describe this
> GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> Cc: Boris Brezillon <boris.brezillon@collabora.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jiyu Yang (OSS) <jiyu.yang@oss.nxp.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Steven Price <steven.price@arm.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Xianzhong Li <xianzhong.li@nxp.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> V2: - Drop regulator-{always,boot}-on from fixed-gpu-reg regulator
>     - Keep the GPU and GPUMIX always enabled
>     - Switch from fsl, to nxp, vendor prefix
>     - Fix opp_table to opp-table
>     - Describe IMX95_CLK_GPUAPB as coregroup clock
>     - Sort interrupts by their names to match bindings
> V3: - Drop perf power domain
>     - Drop reset block controller
> ---
>  arch/arm64/boot/dts/freescale/imx95.dtsi | 45 ++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index 1292677cbe4eb..ad47b7f0d173a 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> @@ -250,6 +250,35 @@ dummy: clock-dummy {
>  		clock-output-names = "dummy";
>  	};
>
> +	gpu_fixed_reg: fixed-gpu-reg {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <920000>;
> +		regulator-max-microvolt = <920000>;
> +		regulator-name = "vdd_gpu";
> +	};
> +
> +	gpu_opp_table: opp-table {
> +		compatible = "operating-points-v2";
> +
> +		opp-500000000 {
> +			opp-hz = /bits/ 64 <500000000>;
> +			opp-hz-real = /bits/ 64 <500000000>;
> +			opp-microvolt = <920000>;
> +		};
> +
> +		opp-800000000 {
> +			opp-hz = /bits/ 64 <800000000>;
> +			opp-hz-real = /bits/ 64 <800000000>;
> +			opp-microvolt = <920000>;
> +		};
> +
> +		opp-1000000000 {
> +			opp-hz = /bits/ 64 <1000000000>;
> +			opp-hz-real = /bits/ 64 <1000000000>;
> +			opp-microvolt = <920000>;
> +		};
> +	};
> +
>  	clk_ext1: clock-ext1 {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
> @@ -2138,6 +2167,22 @@ netc_emdio: mdio@0,0 {
>  			};
>  		};
>
> +		gpu: gpu@4d900000 {
> +			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
> +			reg = <0 0x4d900000 0 0x480000>;
> +			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
> +			clock-names = "core", "coregroup";
> +			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "job", "mmu", "gpu";
> +			mali-supply = <&gpu_fixed_reg>;
> +			operating-points-v2 = <&gpu_opp_table>;
> +			power-domains = <&scmi_devpd IMX95_PD_GPU>;
> +			#cooling-cells = <2>;
> +			dynamic-power-coefficient = <1013>;
> +		};
> +
>  		ddr-pmu@4e090dc0 {
>  			compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";
>  			reg = <0x0 0x4e090dc0 0x0 0x200>;
> --
> 2.51.0
>

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Peng Fan]

Hi Marek,

On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
>The instance of the GPU populated in i.MX95 is the G310, describe this
>GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>
> 
>+		gpu: gpu@4d900000 {
>+			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
>+			reg = <0 0x4d900000 0 0x480000>;
>+			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
>+			clock-names = "core", "coregroup";
>+			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>+			interrupt-names = "job", "mmu", "gpu";
>+			mali-supply = <&gpu_fixed_reg>;
>+			operating-points-v2 = <&gpu_opp_table>;
>+			power-domains = <&scmi_devpd IMX95_PD_GPU>;
>+			#cooling-cells = <2>;
>+			dynamic-power-coefficient = <1013>;

Sorry for my ignorance, would you please share how to get the value?

Thanks,
Peng

>+		};
>+
> 		ddr-pmu@4e090dc0 {
> 			compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu";
> 			reg = <0x0 0x4e090dc0 0x0 0x200>;
>-- 
>2.51.0
>

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Marek Vasut]

On 9/26/25 7:57 AM, Peng Fan wrote:

Hello Peng,

> On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
>> The instance of the GPU populated in i.MX95 is the G310, describe this
>> GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>>
>>
>> +		gpu: gpu@4d900000 {
>> +			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
>> +			reg = <0 0x4d900000 0 0x480000>;
>> +			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
>> +			clock-names = "core", "coregroup";
>> +			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>> +			interrupt-names = "job", "mmu", "gpu";
>> +			mali-supply = <&gpu_fixed_reg>;
>> +			operating-points-v2 = <&gpu_opp_table>;
>> +			power-domains = <&scmi_devpd IMX95_PD_GPU>;
>> +			#cooling-cells = <2>;
>> +			dynamic-power-coefficient = <1013>;
> 
> Sorry for my ignorance, would you please share how to get the value?
Copy-pasted from NXP downstream kernel fork DT bindings, see:

https://github.com/nxp-imx/linux-imx.git

11495de7c24a ("MGS-7621-4 dts: gpu: update devfreq para")

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Rain Yang]

On Mon, Sep 29, 2025 at 02:23:01AM +0200, Marek Vasut wrote:
>On 9/26/25 7:57 AM, Peng Fan wrote:
>
>Hello Peng,
>
>> On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
>> > The instance of the GPU populated in i.MX95 is the G310, describe this
>> > GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>> > 
>> > 
>> > +		gpu: gpu@4d900000 {
>> > +			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
>> > +			reg = <0 0x4d900000 0 0x480000>;
>> > +			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
>> > +			clock-names = "core", "coregroup";
>> > +			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
>> > +				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
>> > +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>> > +			interrupt-names = "job", "mmu", "gpu";
>> > +			mali-supply = <&gpu_fixed_reg>;
>> > +			operating-points-v2 = <&gpu_opp_table>;
>> > +			power-domains = <&scmi_devpd IMX95_PD_GPU>;
>> > +			#cooling-cells = <2>;
>> > +			dynamic-power-coefficient = <1013>;
>> 
>> Sorry for my ignorance, would you please share how to get the value?
>Copy-pasted from NXP downstream kernel fork DT bindings, see:
>
>https://github.com/nxp-imx/linux-imx.git
>
>11495de7c24a ("MGS-7621-4 dts: gpu: update devfreq para")
Hi Marek,

1. this "mali: gpu@4d900000" label can be found in this commit you showed.
please correct this to be compatible with the downstream and upstream kernel 

2. the compatible string is different from our downstream kernel,
also you dropped the "nxp,imx95-mali" compatible patch in the panthor
driver, why?  this will impact the mali property driver too, which
has already been used in many customer project.

3. the number of frequency in opp-table is only one, but there are two clocks
in clocks property, this really make people confused.
CLK/CLK_COREGROUP/CLK_STACK in i.MX95 are from the same source
<&scmi_clk IMX95_CLK_GPU>, the other clock <&scmi_clk IMX95_CLK_GPUAPB>
is always-on APB clock, which can't be changed by A-cores, and has been removed
from clocks property in the latest release.

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Marek Vasut]

On 9/29/25 11:57 AM, Rain Yang wrote:
> On Mon, Sep 29, 2025 at 02:23:01AM +0200, Marek Vasut wrote:
>> On 9/26/25 7:57 AM, Peng Fan wrote:
>>
>> Hello Peng,
>>
>>> On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
>>>> The instance of the GPU populated in i.MX95 is the G310, describe this
>>>> GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>>>>
>>>>
>>>> +		gpu: gpu@4d900000 {
>>>> +			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
>>>> +			reg = <0 0x4d900000 0 0x480000>;
>>>> +			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
>>>> +			clock-names = "core", "coregroup";
>>>> +			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
>>>> +				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
>>>> +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>>>> +			interrupt-names = "job", "mmu", "gpu";
>>>> +			mali-supply = <&gpu_fixed_reg>;
>>>> +			operating-points-v2 = <&gpu_opp_table>;
>>>> +			power-domains = <&scmi_devpd IMX95_PD_GPU>;
>>>> +			#cooling-cells = <2>;
>>>> +			dynamic-power-coefficient = <1013>;
>>>
>>> Sorry for my ignorance, would you please share how to get the value?
>> Copy-pasted from NXP downstream kernel fork DT bindings, see:
>>
>> https://github.com/nxp-imx/linux-imx.git
>>
>> 11495de7c24a ("MGS-7621-4 dts: gpu: update devfreq para")
> Hi Marek,
> 
> 1. this "mali: gpu@4d900000" label can be found in this commit you showed.
> please correct this to be compatible with the downstream

No, sorry, that's not how it works. Upstream is not being adjusted to 
match decisions made by downstream kernel forks unless there is a good 
rationale for such a change. "Downstream does this" is not a good one. (*)

> and upstream kernel

All of imx*.dts* use gpu: or gpu2d:/gpu3d:/vpuvg: for the GPU label.
Also, variants of gpu: label seems more popular:

linux$ grep -hro '[a-z0-9_]\+: gpu@' arch/ | sort | uniq -c
       3 adreno_gpu: gpu@
       1 bb2d: gpu@
       1 gpu2d: gpu@
       1 gpu3d: gpu@
      80 gpu: gpu@
       4 gpu_2d: gpu@
       1 gpu_3d0: gpu@
       4 gpu_3d: gpu@
       6 gpu_mem: gpu@
       1 gpu_reserved: gpu@
       2 gpu_vg: gpu@
      17 mali: gpu@
       1 v3d: gpu@
       2 zap_shader_region: gpu@

> 2. the compatible string is different from our downstream kernel,

See above (*)

> also you dropped the "nxp,imx95-mali" compatible patch in the panthor
> driver, why?

Because it is unnecessary, the generic compatible string is sufficient 
for the in-tree kernel driver.

> this will impact the mali property driver too, which
> has already been used in many customer project.

See above (*)

All the more reason to focus on upstream and avoid deployment of various 
downstream components, blobs and so on. They cannot be maintained in the 
long run, they break, and cause all kinds of maintenance problems.

Upstream cannot be hindered by downstream blobs and their issues, sorry.

> 3. the number of frequency in opp-table is only one, but there are two clocks
> in clocks property, this really make people confused.
> CLK/CLK_COREGROUP/CLK_STACK in i.MX95 are from the same source
> <&scmi_clk IMX95_CLK_GPU>, the other clock <&scmi_clk IMX95_CLK_GPUAPB>
> is always-on APB clock, which can't be changed by A-cores, and has been removed
> from clocks property in the latest release.

Can the APB clock be enabled/disabled from Linux, e.g. to save power ?

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Rain Yang]

On Mon, Sep 29, 2025 at 03:09:01PM +0200, Marek Vasut wrote:
>On 9/29/25 11:57 AM, Rain Yang wrote:
>> On Mon, Sep 29, 2025 at 02:23:01AM +0200, Marek Vasut wrote:
>> > On 9/26/25 7:57 AM, Peng Fan wrote:
>> > 
>> > Hello Peng,
>> > 
>> > > On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
>> > > > The instance of the GPU populated in i.MX95 is the G310, describe this
>> > > > GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>> > > > 
>> > > > 
>> > > > +		gpu: gpu@4d900000 {
>> > > > +			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
>> > > > +			reg = <0 0x4d900000 0 0x480000>;
>> > > > +			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
>> > > > +			clock-names = "core", "coregroup";
>> > > > +			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
>> > > > +				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
>> > > > +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>> > > > +			interrupt-names = "job", "mmu", "gpu";
>> > > > +			mali-supply = <&gpu_fixed_reg>;
>> > > > +			operating-points-v2 = <&gpu_opp_table>;
>> > > > +			power-domains = <&scmi_devpd IMX95_PD_GPU>;
>> > > > +			#cooling-cells = <2>;
>> > > > +			dynamic-power-coefficient = <1013>;
>> > > 
>> > > Sorry for my ignorance, would you please share how to get the value?
>> > Copy-pasted from NXP downstream kernel fork DT bindings, see:
>> > 
>> > https://github.com/nxp-imx/linux-imx.git
>> > 
>> > 11495de7c24a ("MGS-7621-4 dts: gpu: update devfreq para")
>> Hi Marek,
>> 
>> 1. this "mali: gpu@4d900000" label can be found in this commit you showed.
>> please correct this to be compatible with the downstream
>
>No, sorry, that's not how it works. Upstream is not being adjusted to match
>decisions made by downstream kernel forks unless there is a good rationale
>for such a change. "Downstream does this" is not a good one. (*)
>
>> and upstream kernel
>
>All of imx*.dts* use gpu: or gpu2d:/gpu3d:/vpuvg: for the GPU label.
>Also, variants of gpu: label seems more popular:
>
>linux$ grep -hro '[a-z0-9_]\+: gpu@' arch/ | sort | uniq -c
>      3 adreno_gpu: gpu@
>      1 bb2d: gpu@
>      1 gpu2d: gpu@
>      1 gpu3d: gpu@
>     80 gpu: gpu@
>      4 gpu_2d: gpu@
>      1 gpu_3d0: gpu@
>      4 gpu_3d: gpu@
>      6 gpu_mem: gpu@
>      1 gpu_reserved: gpu@
>      2 gpu_vg: gpu@
>     17 mali: gpu@
>      1 v3d: gpu@
>      2 zap_shader_region: gpu@
>

Existence does not necessarily imply validity. Since a single SoC may contain
multiple GPUs, it's generally better to use the specific GPU name as a label
rather than simply using 'gpu', to avoid potential conflicts.

>> 2. the compatible string is different from our downstream kernel,
>
>See above (*)
Additionally, there are still some performance differences between the upstream
driver and the Mali property driver. If compatibility with both can be achieved,
it would allow users to choose the driver that best suits their needs.
Personally, I find it convenient to switch between the two drivers using insmod
and rmmod, which allows for quick testing and comparison.

>
>> also you dropped the "nxp,imx95-mali" compatible patch in the panthor
>> driver, why?
>
>Because it is unnecessary, the generic compatible string is sufficient for
>the in-tree kernel driver.
>
>> this will impact the mali property driver too, which
>> has already been used in many customer project.
>
>See above (*)
>
>All the more reason to focus on upstream and avoid deployment of various
>downstream components, blobs and so on. They cannot be maintained in the long
>run, they break, and cause all kinds of maintenance problems.
>
>Upstream cannot be hindered by downstream blobs and their issues, sorry.
>
>> 3. the number of frequency in opp-table is only one, but there are two clocks
>> in clocks property, this really make people confused.
>> CLK/CLK_COREGROUP/CLK_STACK in i.MX95 are from the same source
>> <&scmi_clk IMX95_CLK_GPU>, the other clock <&scmi_clk IMX95_CLK_GPUAPB>
>> is always-on APB clock, which can't be changed by A-cores, and has been removed
>> from clocks property in the latest release.
>
>Can the APB clock be enabled/disabled from Linux, e.g. to save power ?

please note that the APB clock can't be turned off on the A-core.

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Marek Vasut]

On 9/29/25 6:20 PM, Rain Yang wrote:
> On Mon, Sep 29, 2025 at 03:09:01PM +0200, Marek Vasut wrote:
>> On 9/29/25 11:57 AM, Rain Yang wrote:
>>> On Mon, Sep 29, 2025 at 02:23:01AM +0200, Marek Vasut wrote:
>>>> On 9/26/25 7:57 AM, Peng Fan wrote:
>>>>
>>>> Hello Peng,
>>>>
>>>>> On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
>>>>>> The instance of the GPU populated in i.MX95 is the G310, describe this
>>>>>> GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>>>>>>
>>>>>>
>>>>>> +		gpu: gpu@4d900000 {
>>>>>> +			compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
>>>>>> +			reg = <0 0x4d900000 0 0x480000>;
>>>>>> +			clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk IMX95_CLK_GPUAPB>;
>>>>>> +			clock-names = "core", "coregroup";
>>>>>> +			interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>>>>>> +			interrupt-names = "job", "mmu", "gpu";
>>>>>> +			mali-supply = <&gpu_fixed_reg>;
>>>>>> +			operating-points-v2 = <&gpu_opp_table>;
>>>>>> +			power-domains = <&scmi_devpd IMX95_PD_GPU>;
>>>>>> +			#cooling-cells = <2>;
>>>>>> +			dynamic-power-coefficient = <1013>;
>>>>>
>>>>> Sorry for my ignorance, would you please share how to get the value?
>>>> Copy-pasted from NXP downstream kernel fork DT bindings, see:
>>>>
>>>> https://github.com/nxp-imx/linux-imx.git
>>>>
>>>> 11495de7c24a ("MGS-7621-4 dts: gpu: update devfreq para")
>>> Hi Marek,
>>>
>>> 1. this "mali: gpu@4d900000" label can be found in this commit you showed.
>>> please correct this to be compatible with the downstream
>>
>> No, sorry, that's not how it works. Upstream is not being adjusted to match
>> decisions made by downstream kernel forks unless there is a good rationale
>> for such a change. "Downstream does this" is not a good one. (*)
>>
>>> and upstream kernel
>>
>> All of imx*.dts* use gpu: or gpu2d:/gpu3d:/vpuvg: for the GPU label.
>> Also, variants of gpu: label seems more popular:
>>
>> linux$ grep -hro '[a-z0-9_]\+: gpu@' arch/ | sort | uniq -c
>>       3 adreno_gpu: gpu@
>>       1 bb2d: gpu@
>>       1 gpu2d: gpu@
>>       1 gpu3d: gpu@
>>      80 gpu: gpu@
>>       4 gpu_2d: gpu@
>>       1 gpu_3d0: gpu@
>>       4 gpu_3d: gpu@
>>       6 gpu_mem: gpu@
>>       1 gpu_reserved: gpu@
>>       2 gpu_vg: gpu@
>>      17 mali: gpu@
>>       1 v3d: gpu@
>>       2 zap_shader_region: gpu@
>>
> 
> Existence does not necessarily imply validity. Since a single SoC may contain
> multiple GPUs, it's generally better to use the specific GPU name as a label
> rather than simply using 'gpu', to avoid potential conflicts.

Does the MX95 contain multiple GPUs ?

If no, then the statement above does not apply.

If yes, then there is the gpu/gpu2d/gpu3d option.

>>> 2. the compatible string is different from our downstream kernel,
>>
>> See above (*)
> Additionally, there are still some performance differences between the upstream
> driver and the Mali property driver. If compatibility with both can be achieved,
> it would allow users to choose the driver that best suits their needs.
> Personally, I find it convenient to switch between the two drivers using insmod
> and rmmod, which allows for quick testing and comparison.

Update the downstream fork to match upstream bindings, not the other way 
around.

>>> also you dropped the "nxp,imx95-mali" compatible patch in the panthor
>>> driver, why?
>>
>> Because it is unnecessary, the generic compatible string is sufficient for
>> the in-tree kernel driver.
>>
>>> this will impact the mali property driver too, which
>>> has already been used in many customer project.
>>
>> See above (*)
>>
>> All the more reason to focus on upstream and avoid deployment of various
>> downstream components, blobs and so on. They cannot be maintained in the long
>> run, they break, and cause all kinds of maintenance problems.
>>
>> Upstream cannot be hindered by downstream blobs and their issues, sorry.
>>
>>> 3. the number of frequency in opp-table is only one, but there are two clocks
>>> in clocks property, this really make people confused.
>>> CLK/CLK_COREGROUP/CLK_STACK in i.MX95 are from the same source
>>> <&scmi_clk IMX95_CLK_GPU>, the other clock <&scmi_clk IMX95_CLK_GPUAPB>
>>> is always-on APB clock, which can't be changed by A-cores, and has been removed
>>> from clocks property in the latest release.
>>
>> Can the APB clock be enabled/disabled from Linux, e.g. to save power ?
> 
> please note that the APB clock can't be turned off on the A-core.

I think if the clock are connected to the GPU, then they should be 
described in the DT.

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Marek Vasut]

On 9/25/25 10:38 PM, Marek Vasut wrote:
> The instance of the GPU populated in i.MX95 is the G310, describe this
> GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
Is there still anything that should be changed with this patchset, or 
can it be applied ?

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Shawn Guo]

On Sat, Oct 11, 2025 at 12:53:29PM +0200, Marek Vasut wrote:
> On 9/25/25 10:38 PM, Marek Vasut wrote:
> > The instance of the GPU populated in i.MX95 is the G310, describe this
> > GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
> Is there still anything that should be changed with this patchset, or can it
> be applied ?

I'm waiting binding change to be applied first.  Or is it already done?

Shawn

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Rain Yang]

On Mon, Oct 27, 2025 at 08:57:08AM +0800, Shawn Guo wrote:
>On Sat, Oct 11, 2025 at 12:53:29PM +0200, Marek Vasut wrote:
>> On 9/25/25 10:38 PM, Marek Vasut wrote:
>> > The instance of the GPU populated in i.MX95 is the G310, describe this
>> > GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>> Is there still anything that should be changed with this patchset, or can it
>> be applied ?
>
>I'm waiting binding change to be applied first.  Or is it already done?
>
>Shawn
>
Hi Shawn,
It might be better for Marek to remove the always-on GPUAPB clock from the DTS, given that
it's an SCMI protocol clock and the kernel expects it to be available during operations.

Also, the gpu_fix_reg appears unnecessary for the driver and could be removed[1].

[1] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a8cb5ca53690aa809f4f65e14192753073e61a71,
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=02df3543f3e0ea572e2c739605ebd6c20e1149c4

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Shawn Guo]

On Tue, Oct 28, 2025 at 04:21:05PM +0800, Rain Yang wrote:
> On Mon, Oct 27, 2025 at 08:57:08AM +0800, Shawn Guo wrote:
> >On Sat, Oct 11, 2025 at 12:53:29PM +0200, Marek Vasut wrote:
> >> On 9/25/25 10:38 PM, Marek Vasut wrote:
> >> > The instance of the GPU populated in i.MX95 is the G310, describe this
> >> > GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
> >> Is there still anything that should be changed with this patchset, or can it
> >> be applied ?
> >
> >I'm waiting binding change to be applied first.  Or is it already done?
> >
> >Shawn
> >
> Hi Shawn,
> It might be better for Marek to remove the always-on GPUAPB clock from the DTS, given that
> it's an SCMI protocol clock and the kernel expects it to be available during operations.
> 
> Also, the gpu_fix_reg appears unnecessary for the driver and could be removed[1].
> 
> [1] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a8cb5ca53690aa809f4f65e14192753073e61a71,
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=02df3543f3e0ea572e2c739605ebd6c20e1149c4

Ah, sorry! I did not know we haven't reached agreement on the change.

Shawn

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Marek Vasut]

On 10/28/25 10:08 AM, Shawn Guo wrote:
> On Tue, Oct 28, 2025 at 04:21:05PM +0800, Rain Yang wrote:
>> On Mon, Oct 27, 2025 at 08:57:08AM +0800, Shawn Guo wrote:
>>> On Sat, Oct 11, 2025 at 12:53:29PM +0200, Marek Vasut wrote:
>>>> On 9/25/25 10:38 PM, Marek Vasut wrote:
>>>>> The instance of the GPU populated in i.MX95 is the G310, describe this
>>>>> GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>>>> Is there still anything that should be changed with this patchset, or can it
>>>> be applied ?
>>>
>>> I'm waiting binding change to be applied first.  Or is it already done?
>>>
>>> Shawn
>>>
>> Hi Shawn,
>> It might be better for Marek to remove the always-on GPUAPB clock from the DTS, given that
>> it's an SCMI protocol clock and the kernel expects it to be available during operations.
>>
>> Also, the gpu_fix_reg appears unnecessary for the driver and could be removed[1].
>>
>> [1] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a8cb5ca53690aa809f4f65e14192753073e61a71,
>> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=02df3543f3e0ea572e2c739605ebd6c20e1149c4
> 
> Ah, sorry! I did not know we haven't reached agreement on the change.
The feedback above is new to me, so I am somewhat surprised too.

I'll just send a rebased V4 now.

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Rain Yang]

On Sun, Nov 02, 2025 at 05:02:37PM +0100, Marek Vasut wrote:
>On 10/28/25 10:08 AM, Shawn Guo wrote:
>> On Tue, Oct 28, 2025 at 04:21:05PM +0800, Rain Yang wrote:
>> > On Mon, Oct 27, 2025 at 08:57:08AM +0800, Shawn Guo wrote:
>> > > On Sat, Oct 11, 2025 at 12:53:29PM +0200, Marek Vasut wrote:
>> > > > On 9/25/25 10:38 PM, Marek Vasut wrote:
>> > > > > The instance of the GPU populated in i.MX95 is the G310, describe this
>> > > > > GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>> > > > Is there still anything that should be changed with this patchset, or can it
>> > > > be applied ?
>> > > 
>> > > I'm waiting binding change to be applied first.  Or is it already done?
>> > > 
>> > > Shawn
>> > > 
>> > Hi Shawn,
>> > It might be better for Marek to remove the always-on GPUAPB clock from the DTS, given that
>> > it's an SCMI protocol clock and the kernel expects it to be available during operations.
>> > 
>> > Also, the gpu_fix_reg appears unnecessary for the driver and could be removed[1].
>> > 
>> > [1] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a8cb5ca53690aa809f4f65e14192753073e61a71,
>> > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=02df3543f3e0ea572e2c739605ebd6c20e1149c4
>> 
>> Ah, sorry! I did not know we haven't reached agreement on the change.
>The feedback above is new to me, so I am somewhat surprised too.
>
>I'll just send a rebased V4 now.
Hi Marek,
thanks for your patch to make i.MX95 GPU upstreamed.
Maybe I didn't express it clearly in the previous e-mails.
the always-on GPUAPB clock must be removed, otherwise, it will result in redundant and unnecessary
function call to M33.

Re: [PATCH v3 2/2] arm64: dts: imx95: Describe Mali G310 GPU

[Marek Vasut]

On 11/3/25 8:46 AM, Rain Yang wrote:

Hello Rain,

> thanks for your patch to make i.MX95 GPU upstreamed.
> Maybe I didn't express it clearly in the previous e-mails.
> the always-on GPUAPB clock must be removed, otherwise, it will result in redundant and unnecessary
> function call to M33.

DT should describe the hardware fully, that means DT should also 
describe the clock. Why should this clock description be removed from DT 
? The SCMI clock call over SMT transport is cheap.

-- 
Best regards,
Marek Vasut