From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Frank Li <Frank.li@nxp.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-iio@vger.kernel.org,
joshua.yeong@starfivetech.com, devicetree@vger.kernel.org,
linux@roeck-us.net, "Carlos Song" <carlos.song@nxp.com>,
"Adrian Fluturel" <fluturel.adrian@gmail.com>
Subject: Re: [PATCH v9 6/6] iio: magnetometer: Add mmc5633 sensor
Date: Mon, 3 Nov 2025 20:10:51 +0200 [thread overview]
Message-ID: <aQjwK2IC1NML2w5F@smile.fi.intel.com> (raw)
In-Reply-To: <aQjQ4jsG6Gc2u3n+@lizhi-Precision-Tower-5810>
On Mon, Nov 03, 2025 at 10:57:22AM -0500, Frank Li wrote:
> On Mon, Nov 03, 2025 at 10:13:58AM +0200, Andy Shevchenko wrote:
> > On Fri, Oct 31, 2025 at 12:39:18PM -0400, Frank Li wrote:
...
> > > - 1 -> ARRAY_SIZE()
> >
> > Maybe I missed the answer, but why are the arrays to begin with?
>
> I3C/I2C transfer API required pass down one array. Keep the same coding
> style with existed one, like
>
> source/drivers/base/regmap/regmap-i3c.c
I can understand why it's done there (there are read and write and they use
different amount of items in the arrays). But here in your case IIRC there
is only one function that uses predefined arrays out of a single entry. So
I do not see a justification for having an array. OTOH it's not a big deal
and I leave it to Jonathan to decide.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-03 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 16:39 [PATCH v9 0/6] i3c: Add basic HDR mode support Frank Li
2025-10-31 16:39 ` [PATCH v9 1/6] i3c: Add HDR API support Frank Li
2025-10-31 16:39 ` [PATCH v9 2/6] i3c: Switch to use new i3c_xfer from i3c_priv_xfer Frank Li
2025-10-31 16:39 ` [PATCH v9 3/6] i3c: master: svc: Replace bool rnw with union for HDR support Frank Li
2025-10-31 16:39 ` [PATCH v9 4/6] i3c: master: svc: Add basic HDR mode support Frank Li
2025-11-03 8:03 ` Andy Shevchenko
2025-10-31 16:39 ` [PATCH v9 5/6] dt-bindings: trivial-devices: add MEMSIC 3-axis magnetometer Frank Li
2025-10-31 16:39 ` [PATCH v9 6/6] iio: magnetometer: Add mmc5633 sensor Frank Li
2025-11-03 8:13 ` Andy Shevchenko
2025-11-03 15:57 ` Frank Li
2025-11-03 18:10 ` Andy Shevchenko [this message]
2025-11-01 16:25 ` [PATCH v9 0/6] i3c: Add basic HDR mode support Jonathan Cameron
2025-11-03 8:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQjwK2IC1NML2w5F@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy@kernel.org \
--cc=carlos.song@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fluturel.adrian@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=joshua.yeong@starfivetech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miquel.raynal@bootlin.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).