From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com,
ramona.gradinariu@analog.com, antoniu.miclaus@analog.com,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH 2/2] iio: accel: adxl380: add support for ADXL318 and ADXL319
Date: Wed, 5 Nov 2025 17:11:00 +0200 [thread overview]
Message-ID: <aQtpBGJ0WyWbsQ1Q@smile.fi.intel.com> (raw)
In-Reply-To: <7d990c72acca31b2fe6c7685fd13ef5284c7646f.1762281527.git.Jonathan.Santos@analog.com>
On Wed, Nov 05, 2025 at 09:40:34AM -0300, Jonathan Santos wrote:
> The ADXL318 and ADXL319 are low noise density, low power, 3-axis
> accelerometers based on ADXL380 and ADXL382, respectively. The main
> difference between the new parts and the existing ones are the absence
> of interrupts and events like tap detection, activity/inactivity, and
> free-fall detection.
>
> Other differences in the new parts are fewer power modes, basically
> allowing only idle and measurement modes, and the removal of the 12-bit
> SAR ADC path for the 3-axis signals (known as lower signal chain),
> being excluisive for the temperature sensor in the ADXL318/319.
...
> struct adxl380_chip_info {
> const int samp_freq_tbl[3];
> const int temp_offset;
> const u16 chip_id;
> + const struct iio_info *info;
> + const bool has_low_power;
> };
You can save a few bytes here. Please, run `pahole` to see ways to improve
the layout.
Other than that, LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-05 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 12:40 [PATCH 1/2] dt-bindings: iio: accel: adxl380: add new supported parts Jonathan Santos
2025-11-05 12:40 ` [PATCH 2/2] iio: accel: adxl380: add support for ADXL318 and ADXL319 Jonathan Santos
2025-11-05 15:11 ` Andy Shevchenko [this message]
2025-11-09 16:50 ` Jonathan Cameron
2025-11-06 9:04 ` [PATCH 1/2] dt-bindings: iio: accel: adxl380: add new supported parts Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQtpBGJ0WyWbsQ1Q@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.gradinariu@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox