From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: "Andi Shyti" <andi.shyti@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Jan Dabros" <jsd@semihalf.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Clark Williams" <clrkwllms@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Dmitry Guzman" <dmitry.guzman@mobileye.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH v3 2/7] i2c: designware: Optimize flag reading in i2c_dw_read()
Date: Wed, 19 Nov 2025 22:05:13 +0200 [thread overview]
Message-ID: <aR4i-fnWPpnhBHaQ@smile.fi.intel.com> (raw)
In-Reply-To: <20251119-i2c-dw-v3-2-bc4bc2a2cbac@bootlin.com>
On Wed, Nov 19, 2025 at 04:05:31PM +0100, Benoît Monin wrote:
> Optimize the i2c_dw_read() function by reading the message flags only
> once per message, rather than for every byte.
>
> The message flags are accessed both in the outer loop and the inner loop,
> so move the declaration of the local flags variable to the outer loop.
>
> The message index is only modified by the outer loop, so reading the
> flags in the inner loop was always getting the same value.
OK.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-19 20:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 15:05 [PATCH v3 0/7] i2c: designware: Improve support of multi-messages transfer Benoît Monin
2025-11-19 15:05 ` [PATCH v3 1/7] dt-bindings: i2c: dw: Add Mobileye I2C controllers Benoît Monin
2025-11-20 7:55 ` Krzysztof Kozlowski
2025-11-19 15:05 ` [PATCH v3 2/7] i2c: designware: Optimize flag reading in i2c_dw_read() Benoît Monin
2025-11-19 20:05 ` Andy Shevchenko [this message]
2025-11-19 15:05 ` [PATCH v3 3/7] i2c: designware: Sort compatible strings in alphabetical order Benoît Monin
2025-11-19 15:05 ` [PATCH v3 4/7] i2c: designware: Use runtime PM macro for auto-cleanup Benoît Monin
2025-11-19 18:46 ` Andy Shevchenko
2025-11-20 10:34 ` Mika Westerberg
2025-11-19 15:05 ` [PATCH v3 5/7] i2c: designware: Add dedicated algorithm for AMD NAVI Benoît Monin
2025-11-19 20:04 ` Andy Shevchenko
2025-11-19 15:05 ` [PATCH v3 6/7] i2c: designware: Implement I2C_M_STOP support Benoît Monin
2025-11-19 20:03 ` Andy Shevchenko
2025-11-19 15:05 ` [PATCH v3 7/7] i2c: designware: Support of controller with IC_EMPTYFIFO_HOLD_MASTER disabled Benoît Monin
2025-11-19 20:15 ` Andy Shevchenko
2025-11-25 10:45 ` Benoît Monin
2025-11-25 11:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR4i-fnWPpnhBHaQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=benoit.monin@bootlin.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.guzman@mobileye.com \
--cc=gregory.clement@bootlin.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).