devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	Vedant Deshpande <vedantd@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	Thierry Reding <treding@nvidia.com>,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3] arm64: tegra: Add pinctrl definitions for pcie-ep nodes
Date: Tue, 11 Nov 2025 14:40:25 +0100	[thread overview]
Message-ID: <aRM8yTtKBVEMSsQK@ryzen> (raw)
In-Reply-To: <cvbvbshg4asz4ddrtsotsjc5srouwktirpxbhsjdmlxfzklytd@7sav35bkcmm3>

On Wed, Nov 05, 2025 at 02:37:33PM +0100, Thierry Reding wrote:
> On Thu, Oct 09, 2025 at 04:22:54PM +0200, Niklas Cassel wrote:
> > When the PCIe controller is running in endpoint mode, the controller
> > initialization is triggered by a PERST# (PCIe reset) GPIO deassertion.
> > 
> > The driver has configured an IRQ to trigger when the PERST# GPIO changes
> > state. Without the pinctrl definition, we do not get an IRQ when PERST#
> > is deasserted, so the PCIe controller never gets initialized.
> > 
> > Add the missing definitions, so that the controller actually gets
> > initialized.
> > 
> > Fixes: ec142c44b026 ("arm64: tegra: Add P2U and PCIe controller nodes to Tegra234 DT")
> > Fixes: 0580286d0d22 ("arm64: tegra: Add Tegra234 PCIe C4 EP definition")
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> > ---
> > Changes since v2:
> > -Add pinctrl definitions to all pcie-ep nodes, not just C4 controller.
> > 
> >  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 57 ++++++++++++++++++++++++
> >  1 file changed, 57 insertions(+)
> 
> Applied thanks. I did add blank lines between the blocks since that's
> what I prefer. I hope you don't mind.

Perfectly fine with me, you are the maintainer :)

However, I don't see this patch queued on any branch @
https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git/

Did you perhaps forget to push?


Kind regards,
Niklas

  reply	other threads:[~2025-11-11 13:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 14:22 [PATCH v3] arm64: tegra: Add pinctrl definitions for pcie-ep nodes Niklas Cassel
2025-10-15 16:38 ` Manikanta Maddireddy
2025-11-04 14:53 ` Niklas Cassel
2025-11-05 13:37 ` Thierry Reding
2025-11-11 13:40   ` Niklas Cassel [this message]
2025-11-11 16:37     ` Thierry Reding
2025-11-05 14:04 ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRM8yTtKBVEMSsQK@ryzen \
    --to=cassel@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    --cc=vedantd@nvidia.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).