Re: [PATCH v3 2/2] media: i2c: add Samsung S5KJN1 image sensor device driver

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Vladimir,

On Sat, Nov 08, 2025 at 01:00:33PM +0200, Vladimir Zapolskiy wrote:
> On 11/4/25 17:53, Bryan O'Donoghue wrote:
> > On 23/10/2025 03:53, Vladimir Zapolskiy wrote:
> > > +static int s5kjn1_check_hwcfg(struct s5kjn1 *s5kjn1)
> > > +{
> > > +	struct fwnode_handle *fwnode = dev_fwnode(s5kjn1->dev), *ep;
> > > +	struct v4l2_fwnode_endpoint bus_cfg = {
> > > +		.bus_type = V4L2_MBUS_CSI2_DPHY,
> > > +	};
> > > +	unsigned long freq_bitmap;
> > > +	int ret;
> > > +
> > > +	if (!fwnode)
> > > +		return -ENODEV;
> > > +
> > > +	ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
> > > +	if (!ep)
> > > +		return -EINVAL;
> > > +
> > > +	ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
> > > +	fwnode_handle_put(ep);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	if (bus_cfg.bus.mipi_csi2.num_data_lanes &&
> > 
> > Is !bus_cfg.bus.mipi_csi2.num_data_lanes a valid case ?
> > 
> 
> Yes, it is a valid case, because a number of data lanes is unchangeable
> and the property can be omitted like in many other similar cases.

In that case make 4 lanes the default.

-- 
Regards,

Sakari Ailus