devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alejandro Enrique <alejandroe1@geotab.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: gnss: u-blox: use open-drain reset and safeboot in example
Date: Fri, 14 Nov 2025 16:28:05 +0100	[thread overview]
Message-ID: <aRdKhWvsK7xHou0-@hovoldconsulting.com> (raw)
In-Reply-To: <20251114150335.357-1-johan@kernel.org>

On Fri, Nov 14, 2025 at 04:03:35PM +0100, Johan Hovold wrote:
> The RESET_N and SAFEBOOT_N pins should typically be left open and only
> be connected to ground in rare cases where a device is misbehaving.
> 
> Switch to using GPIO_OPEN_DRAIN in the example as this is what should
> generally be used.
>
> Note that the current Linux driver implementation depends on these pins
> being declared open-drain so that they are not driven while the main
> supply is off.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> index 9f14cfe7efd1..e8b696986bb7 100644
> --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> @@ -67,7 +67,7 @@ examples:
>              compatible = "u-blox,neo-8";
>              v-bckp-supply = <&gnss_v_bckp_reg>;
>              vcc-supply = <&gnss_vcc_reg>;
> -            reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> -            safeboot-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
> +            reset-gpios = <&gpio 1 GPIO_OPEN_DRAIN>;
> +            safeboot-gpios = <&gpio 2 GPIO_OPEN_DRAIN>;

Bah, I forgot about the ABI breakage introduced a few years ago which
means that we now need to specify both open-drain and active-low:

	https://lore.kernel.org/all/20170719131640.GA2533@localhost/

Will fix in a v2.

Johan

      reply	other threads:[~2025-11-14 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 15:03 [PATCH] dt-bindings: gnss: u-blox: use open-drain reset and safeboot in example Johan Hovold
2025-11-14 15:28 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRdKhWvsK7xHou0-@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=alejandroe1@geotab.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).