From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 162E9283FF0 for ; Sat, 15 Nov 2025 09:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763200299; cv=none; b=WAKzWw5k6K/Gia2gme5i0X+x4xrH+ECWCURV+lWPA9fN8A8VbpqNcBvBYOdf+8XQHg5zZgbcLe+Q5sJbSveTqhqQfd1Ubw2TYoefvJbbCHP+6QZ7TdUE2vXA++wtrMzVizL+75DhutY0ZaSXdoBogyzE9ADnaPB39T2nVBeqVis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763200299; c=relaxed/simple; bh=CDcBesjBeDH8HiQdDnJyVwV7463lVlwERDCq6R1p72Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uquVZ1CuezmTEbPyWNK3gihGuTp7U08yiKQtz61tt9EKDz0l1rTu1RDHmDrmurzf6pj6IlANQ8kHc8lVYdZSmCN7gPzSA/tKkZ/i2dRAxQ1i5nhi4aFJppWwxXekpEgQ0DctplOD1MTfzBzEiz84nzvMO6IH6PTCP++eAYDlO60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k9bIyFi3; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k9bIyFi3" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-29558061c68so33279055ad.0 for ; Sat, 15 Nov 2025 01:51:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763200296; x=1763805096; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7yRRIzPGF37+ZW/9QuVq1mSuHX636hF32XUa+RdwYXc=; b=k9bIyFi3ttsIsIuotUcvTVB/DpZb5VM+Jy+jtm+LjkVWVrPp+0VPzxKQ0He8Nm8Gmx yYA6PBdemeNmPwn1YuSdiinhTjlkSqwikz0r7BPWpHZSsn90B9i/HPGyM2GDZ2EH6mgE 31sRP4yASEek9bJ6Xo/eMpZME4+lDWLukT73xtBul5JrhRNT+REBkYIwwibJAsfAQgIe 1Nl+QQMNfM+Dk0qrqvhZGtk5BQc1gBI1PmRwF6+aKRaTtrfpZmdMN/pTaORKL9xJwgt6 hai2lUvW3OwTzdk18yYh7aapvusV1iE4YjAYjb0aXyUtiyO2JJvMrae7CBd7fwrsSAb3 xu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763200296; x=1763805096; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7yRRIzPGF37+ZW/9QuVq1mSuHX636hF32XUa+RdwYXc=; b=L5UByn2Rxq8F73w8kQZ7yNhcfT6EvvJ3OGXgBjI3//VY9IyqUH7DCNUm98I/AwPD5O i1lxp7FsQVPOW28GyPOPlJjDhTwk/ShDI3axoHme9LE03KCMyF69QGnkJTEzVjV+eHeM R7XcIASSaiydfM4tF6WnKW2FYhbbEbJirUcAiR97alURftgEhBHi2Vn9mHrOyvE1CMHZ zI+YsvDXhlRCkwcVgLY+3SpMbas5QRqJOYh1yne2xOh1Lx/Iz9QXz97x2k5BPczPB7h4 v7/3oo1QQ8xAYTnDjkr9lAthStOjSXpUjZWgsbqwQQF9ITW8YFjNDpiVQofGufjUP1/e 8rxQ== X-Forwarded-Encrypted: i=1; AJvYcCX1x8527ifu2RouVn/oHgYwxca5SS6RVTb7dcFtzkuEuniFiakrY+l4dwuiIDXvX1oHsT7ZLHkgCncs@vger.kernel.org X-Gm-Message-State: AOJu0Yw0dt8HMZCia4ZRGEK9oV25CqebTph2RFBcJ0MK5VYfGwXgHe38 UJJV8I2pOYkL9+1F6L4A3z7vZLmU2XKJg53oIeBFfEDBoh/RAQ2bgFSC X-Gm-Gg: ASbGncvxzo4Q29tYCP05t8rG3tRDkXhn5DyGq8wFJdlUtxmInfu/CpSGr4hZ0KYFClc 9+O4k9+7T1nVkOgAc2QHxO6DUQH/YeGU/c9F6TaQcWOBtQKh6vOLfHqwK+9T8RothKztve8zLFf K6MdCWK1quB07GHIBkU+49DhmR3snnZVsEbwaZGIJ5Na/1Ntu8j/Pp852C7J/2O5j9rPm7qPmE4 PThPjWaGLPj3om3aP6viqEjzStQPIqWjKwuLrt+HpwALq2juk6GSotD+lp/3KHS6yffPjy/7Ci7 KE1AOJl70l9n5DooVS6iN1UNtZ6wfFpN5OcjXKLT5letlqvWGXcmk4LN2GiautES70xulG/ddaB +CvUW+OLJcM2yWw4NhYD70QwRMdMQpDNpmOYMr4PxGt/ZOMvSKgvTRgqKyFaxdK2ubGCU0H4NFA == X-Google-Smtp-Source: AGHT+IHDzihlPaHj5ciPC1avrMW/DUXWk3g/TfMMzpdbx9pWLRPYDr6Bl34n8EK+fex8PZCS0cSmgg== X-Received: by 2002:a05:701b:2803:b0:119:e569:fbad with SMTP id a92af1059eb24-11b411fd316mr1430818c88.28.1763200296250; Sat, 15 Nov 2025 01:51:36 -0800 (PST) Received: from geday ([2804:7f2:800b:a121::dead:c001]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49db102f5sm16211340eec.4.2025.11.15.01.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 01:51:35 -0800 (PST) Date: Sat, 15 Nov 2025 06:51:29 -0300 From: Geraldo Nascimento To: Dragan Simic Cc: linux-rockchip@lists.infradead.org, Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker Subject: Re: [PATCH 2/3] PCI: rockchip-host: comment danger of 5.0 GT/s speed Message-ID: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Nov 15, 2025 at 10:30:49AM +0100, Dragan Simic wrote: > Hello Geraldo, > > On Saturday, November 15, 2025 10:10 CET, Geraldo Nascimento wrote: > > According to Rockchip sources, there is grave danger in enabling 5.0 > > GT/s speed for this core. Add a comment documenting that danger and > > discouraging end-users from forcing higher speed through DT changes. > > > > Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock-chips.com/ > > Reported-by: Shawn Lin > > Signed-off-by: Geraldo Nascimento > > --- > > drivers/pci/controller/pcie-rockchip-host.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c > > index ee1822ca01db..7e6ff76466b7 100644 > > --- a/drivers/pci/controller/pcie-rockchip-host.c > > +++ b/drivers/pci/controller/pcie-rockchip-host.c > > @@ -332,6 +332,11 @@ static int rockchip_pcie_host_init_port(struct rockchip_pcie *rockchip) > > /* > > * Enable retrain for gen2. This should be configured only after > > * gen1 finished. > > + * > > + * According to Rockchip this path is dangerous and may lead to > > + * catastrophic failure. Even if the odds are small, users are > > + * still discouraged to engage the corresponding DT option. > > + * > > */ > > status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL2); > > status &= ~PCI_EXP_LNKCTL2_TLS; > > Looking good to me, thanks for this patch! There's no need > to emit warnings here, because they'd be emitted already in > the rockchip_pcie_parse_dt() function. > > Please feel free to include > > Reviewed-by: Dragan Simic > I disagree, I think the comment stands. Even if we reduce to one line, ex: + May cause damage Regards, Geraldo Nascimento