[PATCH 0/2] Add support for Skov Rev.C HDMI variant

[PATCH 0/2] Add support for Skov Rev.C HDMI variant

[Marco Felsch]

Hi,

this small patchset adds the support for the Rev.C HDMI board variant.

Regards,
  Marco

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Marco Felsch (2):
      dt-bindings: arm: fsl: add Skov Rev.C HDMI support
      arm64: dts: imx8mp-skov: add Rev.C HDMI support

 Documentation/devicetree/bindings/arm/fsl.yaml          | 1 +
 arch/arm64/boot/dts/freescale/Makefile                  | 1 +
 arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts | 8 ++++++++
 3 files changed, 10 insertions(+)
---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251107-v6-18-skov-revc-hdmi-1e8d4bbac26a

Best regards,
-- 
Marco Felsch <m.felsch@pengutronix.de>

[PATCH 1/2] dt-bindings: arm: fsl: add Skov Rev.C HDMI support

[Marco Felsch]

From software perspective, Rev.C HDMI and Rev.B HDMI don't differ since
the panel is connected via HDMI and the touchscreen is connected via
USB. However, the bootloader firmware expects to find a dts with the
correct revc-hdmi compatible.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 00cdf490b0620bf537330ee9342a197f13c8c8ab..cf4405389f68ab96e9927bb61a05e57cf698b4f1 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1110,6 +1110,7 @@ properties:
               - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
               - skov,imx8mp-skov-revb-lt6 # SKOV i.MX8MP climate control with 7” panel
               - skov,imx8mp-skov-revb-mi1010ait-1cp1 # SKOV i.MX8MP climate control with 10.1" panel
+              - skov,imx8mp-skov-revc-hdmi # SKOV i.MX8MP climate control without panel
               - skov,imx8mp-skov-revc-bd500 # SKOV i.MX8MP climate control with LED frontplate
               - skov,imx8mp-skov-revc-tian-g07017 # SKOV i.MX8MP climate control with 7" panel
               - ultratronik,imx8mp-ultra-mach-sbc # Ultratronik SBC i.MX8MP based board

-- 
2.47.3

Re: [PATCH 1/2] dt-bindings: arm: fsl: add Skov Rev.C HDMI support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: arm: fsl: add Skov Rev.C HDMI support

[Shawn Guo]

On Fri, Nov 07, 2025 at 03:49:51PM +0100, Marco Felsch wrote:
> From software perspective, Rev.C HDMI and Rev.B HDMI don't differ since
> the panel is connected via HDMI and the touchscreen is connected via
> USB. However, the bootloader firmware expects to find a dts with the
> correct revc-hdmi compatible.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

Applied both, thanks!

[PATCH 2/2] arm64: dts: imx8mp-skov: add Rev.C HDMI support

[Marco Felsch]

From software perspective, Rev.C HDMI and Rev.B HDMI don't differ since
the panel is connected via HDMI and the touchscreen is connected via
USB. However, the bootloader firmware expects to find a dts with the
correct revc-hdmi compatible.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/Makefile                  | 1 +
 arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 525ef180481d331e9c4decd092b7b831c497b67e..9da685641aa9e102a8566f0e58c0b57bb822c7d0 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -233,6 +233,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-bd500.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-hdmi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-tian-g07017.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-toradex-smarc-dev.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts
new file mode 100644
index 0000000000000000000000000000000000000000..c263e8fd048464df637604a8776aef345877e4f6
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+
+#include "imx8mp-skov-revb-hdmi.dts"
+
+/ {
+	model = "SKOV IMX8MP CPU revC - HDMI";
+	compatible = "skov,imx8mp-skov-revc-hdmi", "fsl,imx8mp";
+};

-- 
2.47.3

Re: [PATCH 0/2] Add support for Skov Rev.C HDMI variant

[Rob Herring (Arm)]

On Fri, 07 Nov 2025 15:49:50 +0100, Marco Felsch wrote:
> Hi,
> 
> this small patchset adds the support for the Rev.C HDMI board variant.
> 
> Regards,
>   Marco
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Marco Felsch (2):
>       dt-bindings: arm: fsl: add Skov Rev.C HDMI support
>       arm64: dts: imx8mp-skov: add Rev.C HDMI support
> 
>  Documentation/devicetree/bindings/arm/fsl.yaml          | 1 +
>  arch/arm64/boot/dts/freescale/Makefile                  | 1 +
>  arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts | 8 ++++++++
>  3 files changed, 10 insertions(+)
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251107-v6-18-skov-revc-hdmi-1e8d4bbac26a
> 
> Best regards,
> --
> Marco Felsch <m.felsch@pengutronix.de>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: 3a8660878839faadb4f1a6dd72c3179c1df56787 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20251107-v6-18-skov-revc-hdmi-v1-0-595549e5b496@pengutronix.de:

arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml

Re: [PATCH 0/2] Add support for Skov Rev.C HDMI variant

[Marco Felsch]

On 25-11-10, Rob Herring (Arm) wrote:
> 
> On Fri, 07 Nov 2025 15:49:50 +0100, Marco Felsch wrote:
> > Hi,
> > 
> > this small patchset adds the support for the Rev.C HDMI board variant.
> > 
> > Regards,
> >   Marco
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> > Marco Felsch (2):
> >       dt-bindings: arm: fsl: add Skov Rev.C HDMI support
> >       arm64: dts: imx8mp-skov: add Rev.C HDMI support
> > 
> >  Documentation/devicetree/bindings/arm/fsl.yaml          | 1 +
> >  arch/arm64/boot/dts/freescale/Makefile                  | 1 +
> >  arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts | 8 ++++++++
> >  3 files changed, 10 insertions(+)
> > ---
> > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > change-id: 20251107-v6-18-skov-revc-hdmi-1e8d4bbac26a
> > 
> > Best regards,
> > --
> > Marco Felsch <m.felsch@pengutronix.de>
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: 3a8660878839faadb4f1a6dd72c3179c1df56787 (use --merge-base to override)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20251107-v6-18-skov-revc-hdmi-v1-0-595549e5b496@pengutronix.de:
> 
> arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml

This may be a valid issue, but it's rather an additional patch worth it
since this patchset doesn't touch the imx8mp-skov-reva.dtsi include at
all.

Regards,
  Marco

> 
> 
> 
> 
> 
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

Re: [PATCH 0/2] Add support for Skov Rev.C HDMI variant

[Marco Felsch]

On 25-11-10, Marco Felsch wrote:
> On 25-11-10, Rob Herring (Arm) wrote:
> > 
> > On Fri, 07 Nov 2025 15:49:50 +0100, Marco Felsch wrote:
> > > Hi,
> > > 
> > > this small patchset adds the support for the Rev.C HDMI board variant.
> > > 
> > > Regards,
> > >   Marco
> > > 
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > > Marco Felsch (2):
> > >       dt-bindings: arm: fsl: add Skov Rev.C HDMI support
> > >       arm64: dts: imx8mp-skov: add Rev.C HDMI support
> > > 
> > >  Documentation/devicetree/bindings/arm/fsl.yaml          | 1 +
> > >  arch/arm64/boot/dts/freescale/Makefile                  | 1 +
> > >  arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts | 8 ++++++++
> > >  3 files changed, 10 insertions(+)
> > > ---
> > > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > > change-id: 20251107-v6-18-skov-revc-hdmi-1e8d4bbac26a
> > > 
> > > Best regards,
> > > --
> > > Marco Felsch <m.felsch@pengutronix.de>
> > > 
> > > 
> > > 
> > 
> > 
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> > 
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to reply
> > unless the platform maintainer has comments.
> > 
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> > 
> >   pip3 install dtschema --upgrade
> > 
> > 
> > This patch series was applied (using b4) to base:
> >  Base: 3a8660878839faadb4f1a6dd72c3179c1df56787 (use --merge-base to override)
> > 
> > If this is not the correct base, please add 'base-commit' tag
> > (or use b4 which does this automatically)
> > 
> > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20251107-v6-18-skov-revc-hdmi-v1-0-595549e5b496@pengutronix.de:
> > 
> > arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> > 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml
> 
> This may be a valid issue, but it's rather an additional patch worth it
> since this patchset doesn't touch the imx8mp-skov-reva.dtsi include at
> all.

FTR: If I get the binding right, the regression is caused by commit
https://lore.kernel.org/all/20250918-ksz-strap-pins-v3-2-16662e881728@bootlin.com/.

Since this commit, pinctrl-names always need to have the "default" and
"reset" value, which is wrong.

Regards,
  Marco


> 
> Regards, Marco
> 
> > 
> > 
> > 
> > 
> > 
> > 
> 
> -- #gernperDu #CallMeByMyFirstName
> 
> Pengutronix e.K.                           |
> | Steuerwalder Str. 21                       |
> https://www.pengutronix.de/ | 31137 Hildesheim, Germany
> | Phone: +49-5121-206917-0    | Amtsgericht Hildesheim, HRA 2686
> | Fax:   +49-5121-206917-9    |
> 
>