From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 140C6254AF5; Mon, 17 Nov 2025 08:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763368436; cv=none; b=Z7lCxH6ZkTDW+m5OgYTx2f/wFA35KufIlgMTpFOJbHRK4YIhdS/ZF7X3zdaB5jWP7OqLkQOKrL47Qyvc9DggH6xoiqn/ZF74mjih3C6Oc3Bi/7IvGaBnjKBnmQKdNx8auMAVwBrd0f1utj4R5HH49kf2SNc+8D4pehM17jEXkxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763368436; c=relaxed/simple; bh=fwZ0M264l2HDkJoHx6/s0vTo1RmcLUo2A7k4nruvgmg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UuTJspEMxJeJDs57nvXiJ8NY/xlTp1wnsKhUopEA96A+ONukJY8cNe/hZ5kiDq0ElOHeaYGz7Goksu/WI6kCNwMi1BDEyoDdv+AQYGM28WHT43luNph7jjIqXT0akbcp5HGdwX34vBp10AZ3sQ5EcWE6Sjua8ExGTp/xtEQlqCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=j7TPp0Nt; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="j7TPp0Nt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763368434; x=1794904434; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fwZ0M264l2HDkJoHx6/s0vTo1RmcLUo2A7k4nruvgmg=; b=j7TPp0NtSJQIUxgkn02NDcPBalaR4wdN7uStvVShM4x7+6mOi8xA+pTd 6nf4obgXyEIxh0DrZKmICJeOhKRgwz+d3zVsjdD2CliCEUxy9eFj2PtNt 3zILYBleAPUGIohFmongQu8gkovC47NHhAZ9nc3lqTipDSWAiid7GNmkn UEqOA3Yx34Cw8hKei8STQEQPLtgFp7Oh0X1zaPWWH92KjZ/7N90RP6sJZ pfKMh1wwMgChD8J0pYWSKckDXK3z5rLGNkFhaGfNeB8N8YnST7d/BzHU1 +BjswjmiJT5Zj2rFJ7wXUD57bFEZBCj8FhBn2t8sSvqvp4AyN41+R1t/Z g==; X-CSE-ConnectionGUID: X1XUZuUoTpu+3BmHpmshyw== X-CSE-MsgGUID: hkCBsV6CROiisHH7/MHA6A== X-IronPort-AV: E=McAfee;i="6800,10657,11615"; a="76711761" X-IronPort-AV: E=Sophos;i="6.19,311,1754982000"; d="scan'208";a="76711761" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2025 00:33:53 -0800 X-CSE-ConnectionGUID: LzySukzyT0q7wE/hYMMthQ== X-CSE-MsgGUID: 2U3W8q32QTu8NcnLccW2lA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,311,1754982000"; d="scan'208";a="194842874" Received: from mgoodin-mobl3.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.220.176]) by orviesa004.jf.intel.com with SMTP; 17 Nov 2025 00:33:42 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 17 Nov 2025 10:33:39 +0200 Date: Mon, 17 Nov 2025 10:33:39 +0200 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Peter Chen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v9 01/10] usb: typec: Add notifier functions Message-ID: References: <20251111105040.94-1-kernel@airkyi.com> <20251111105040.94-2-kernel@airkyi.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251111105040.94-2-kernel@airkyi.com> Tue, Nov 11, 2025 at 06:50:31PM +0800, Chaoyi Chen kirjoitti: > From: Chaoyi Chen > > Some other part of kernel may want to know the event of typec bus. > > This patch add common notifier function to notify these event. > > Signed-off-by: Chaoyi Chen > --- > > Changes in v9: > - Remove redundant header files. > > Changes in v8: > - Fix coding style. > > drivers/usb/typec/Makefile | 2 +- > drivers/usb/typec/bus.h | 2 ++ > drivers/usb/typec/class.c | 2 ++ > drivers/usb/typec/notify.c | 23 +++++++++++++++++++++++ > include/linux/usb/typec_altmode.h | 9 +++++++++ > 5 files changed, 37 insertions(+), 1 deletion(-) > create mode 100644 drivers/usb/typec/notify.c > > diff --git a/drivers/usb/typec/Makefile b/drivers/usb/typec/Makefile > index 7a368fea61bc..20d09c5314d7 100644 > --- a/drivers/usb/typec/Makefile > +++ b/drivers/usb/typec/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_TYPEC) += typec.o > -typec-y := class.o mux.o bus.o pd.o retimer.o > +typec-y := class.o mux.o notify.o bus.o pd.o retimer.o > typec-$(CONFIG_ACPI) += port-mapper.o > obj-$(CONFIG_TYPEC) += altmodes/ > obj-$(CONFIG_TYPEC_TCPM) += tcpm/ > diff --git a/drivers/usb/typec/bus.h b/drivers/usb/typec/bus.h > index 643b8c81786d..820b59b6d434 100644 > --- a/drivers/usb/typec/bus.h > +++ b/drivers/usb/typec/bus.h > @@ -26,6 +26,8 @@ struct altmode { > struct altmode *plug[2]; > }; > > +void typec_notify_event(unsigned long event, void *data); > + > #define to_altmode(d) container_of(d, struct altmode, adev) > > extern const struct bus_type typec_bus; > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index 9b2647cb199b..9d2aa3dd3f56 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -600,6 +600,8 @@ typec_register_altmode(struct device *parent, > return ERR_PTR(ret); > } > > + typec_notify_event(TYPEC_ALTMODE_REGISTERED, &alt->adev); > + > return &alt->adev; > } You need to also send TYPEC_ALTMODE_UNREGISTERED notification in typec_unregister_altmode(). thanks, > diff --git a/drivers/usb/typec/notify.c b/drivers/usb/typec/notify.c > new file mode 100644 > index 000000000000..9e50b54da359 > --- /dev/null > +++ b/drivers/usb/typec/notify.c > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include > + > +#include "bus.h" > + > +static BLOCKING_NOTIFIER_HEAD(typec_notifier_list); > + > +int typec_altmode_register_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_register(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_altmode_register_notify); > + > +int typec_altmode_unregister_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_unregister(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_altmode_unregister_notify); > + > +void typec_notify_event(unsigned long event, void *data) > +{ > + blocking_notifier_call_chain(&typec_notifier_list, event, data); > +} > diff --git a/include/linux/usb/typec_altmode.h b/include/linux/usb/typec_altmode.h > index f7db3bd4c90e..59e20702504b 100644 > --- a/include/linux/usb/typec_altmode.h > +++ b/include/linux/usb/typec_altmode.h > @@ -10,6 +10,7 @@ > #define MODE_DISCOVERY_MAX 6 > > struct typec_altmode_ops; > +struct notifier_block; > > /** > * struct typec_altmode - USB Type-C alternate mode device > @@ -77,6 +78,14 @@ int typec_altmode_notify(struct typec_altmode *altmode, unsigned long conf, > const struct typec_altmode * > typec_altmode_get_partner(struct typec_altmode *altmode); > > +enum usb_typec_event { > + TYPEC_ALTMODE_REGISTERED, > + TYPEC_ALTMODE_UNREGISTERED, > +}; > + > +int typec_altmode_register_notify(struct notifier_block *nb); > +int typec_altmode_unregister_notify(struct notifier_block *nb); > + > /** > * struct typec_cable_ops - Cable alternate mode operations vector > * @enter: Operations to be executed with Enter Mode Command > -- > 2.51.1 -- heikki