From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D40274FFD for ; Mon, 24 Nov 2025 17:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764003977; cv=none; b=aVPjKO5xmxb0BBH89/9T2E/IjgAWS+mjUltVmBT5iwVopk3L8/+LKvdmrLPZYUgkyw8tlWerF5USOGVjFIO3Fo6Hy4Pj817v3SWxtBc7G7l4jEE96zqS1ODlfN4h5zY9M38XSzDYGp2PGb5U/+wK5Bz6vPK45pygOgbVuTHG6bk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764003977; c=relaxed/simple; bh=JYk0DlsmrYkHa9pnunJP5MMBiIh8+pvQoxXtIvOuszA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JUBTHXFRwYtCnnUXTGBgXQNGcUwGvOOf6X666/12qavmARk9x79raS7v/4ZbZWuStU53EmR7HBBwsZwcpzIARi8wHg55mKzBLVPjpN7wb8hZp9uA4lWQY/XOW6HA18OWm0aKd0VzWrhiRaZdawWgA/OUHGyF73fiVnv8uROx3ZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MwUJyBAz; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MwUJyBAz" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2953ad5517dso56108435ad.0 for ; Mon, 24 Nov 2025 09:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764003975; x=1764608775; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gnHv7SSUkVZXm9MlHQF7vnbKRHnkGY//zn2BWH6fbi8=; b=MwUJyBAzQ9279jRUYy/gey3eDSFddfZgnMDp1XBvmQn2JmUMyA94hFPzfFhvrTxi3A cJj8Wlz3fXhfF1diLtyLd0BBm+X4O57exrGlyqWjKStfYkF7WEGCcg7+hvEeF7ZWP9Z9 Li6zEH1tyiNYBB7rSf9Lp/eIIJ9Rnk8JbKeesmrEd/DDc7RDx6LkqhTvo/oQIMGA1MeV 4wOoUWi7jhf9NoEjlpkwIZTFhV+Gm8wEOlvFIX2DqJda7DpKTjvHv+8QoRT3UMLxK7XW X9D0JAadElptu76pPK0UGsiRf7D090GanoeURyTrQfBWkJdLWnsO/n8/VEkk5yH5JeaJ 7ekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764003975; x=1764608775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gnHv7SSUkVZXm9MlHQF7vnbKRHnkGY//zn2BWH6fbi8=; b=AH24uxATur64Lwsyw1dqsSC3DNF/ct65sOGM0zUiugZca2jBn4HPxEh6WzQCE4BoGn VB8qwqUXWwMGWr6KvZgEBAMiAYm0rnF48f9iA1hshqiqS8I96zWXGDXJqmX53lGXwiDE HzZoMF318Vwu3i6IclbHGInL8lp3SSVAjKaWiNcM58zAf+MBlmWl+pDgUMbM0IxuXNDg lepy7Sqboqv8MQ9P2eCSSVs3RhzXgUnmmjjYKCtD/UVHvFsjo0+nIO6cEvVBvxY89T8U JJ+vW66IO9InmbGiCgI9A7VxhxI1xwTEAYxvVXwduRTEI7BMUa7U8kVMmc4MCz5qm3O7 BBdw== X-Forwarded-Encrypted: i=1; AJvYcCU+qFmvpR9zpMD9ZIeGkduTRLp0XScGpxrd7YiA0eLFHrZuq3GGV7KZ31qiPDH2AYI6nUJGkfsWUTjZ@vger.kernel.org X-Gm-Message-State: AOJu0Yyaq6QfDfoaEKHZ+KDxJSSqr41IVA5uUJ8cI7d7Ve/mJPvHJtZS wHqZFWV6o4zmGBsuVoIfbHPqAgsBOSOv6jMk2bWDt6Kuvkho+vrqN8L7OEIst3tmtqk= X-Gm-Gg: ASbGncuo6PtR1KKw3E0eAYyHHFJvuf5KjwtvQdlQFZanf5WTCSoXo2UsUJln5z3PCb2 Cy+08pueuILWBZpPJBD4xr8CN98Da3YZZ5mNr3/n46xUMKuyZFXY5nBM/mskruKIGl5vqXYxGW9 Vs7G49TGP+tiIGaoDNoHwaIuj/1Ruo30EfvlOdIimkfyBetzVy98OMxoCUc1xIbcVvC5Zp/Z/Tz a0oZSm4oD+vsovlRV7ZAywGIWm2n7F6XQwvDoJxXsmvDwXZmqMe5gxBtoW20WZtuGDP4uTYtEUP bQiBWFxTruXgmM+2IsT2L/KBB3zDC12XewChpp+nMQK+wp2HGxqjsEqnFfd70tDjUUsAejAS0j0 P9uGeeGj4PxCAVDMRguJjKupURaxaN2iMIu1jSZaDpR3P76iQ5Dfy9Qc6zWj/Hcx4GFB4O1rj3e buPaXDTGY3aRhg62cbsmeyth/6 X-Google-Smtp-Source: AGHT+IFFll1ZBv/7+NTNtf66eRKGB3OEh6EXFU3EYSb6koOyW950nZNuI/PfU8U/2nZsnDgImLDneQ== X-Received: by 2002:a17:903:384c:b0:27c:56af:88ea with SMTP id d9443c01a7336-29b6bfa1f66mr134598965ad.60.1764003974768; Mon, 24 Nov 2025 09:06:14 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:aebb:f23e:8a7c:d95d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b13965csm142296595ad.30.2025.11.24.09.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 09:06:14 -0800 (PST) Date: Mon, 24 Nov 2025 10:06:11 -0700 From: Mathieu Poirier To: Shenwei Wang Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Jonathan Corbet , Linus Walleij , Bartosz Golaszewski , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-imx@nxp.com, Randy Dunlap , Andrew Lunn , Arnaud POULIQUEN , linux-gpio@vger.kernel.org Subject: Re: [PATCH v5 0/5] Enable Remote GPIO over RPMSG on i.MX Platform Message-ID: References: <20251104203315.85706-1-shenwei.wang@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251104203315.85706-1-shenwei.wang@nxp.com> On Tue, Nov 04, 2025 at 02:33:10PM -0600, Shenwei Wang wrote: > Support the remote devices on the remote processor via the RPMSG bus on > i.MX platform. > > Changes in v5: > - move the gpio-rpmsg.rst from admin-guide to staging directory after > discussion with Randy Dunlap. > - add include files with some code improvements per Bartosz's comments. > > Changes in v4: > - add a documentation to describe the transport protocol per Andrew's > comments. > - add a new handler to get the gpio direction. > > Changes in v3: > - fix various format issue and return value check per Peng 's review > comments. > - add the logic to also populate the subnodes which are not in the > device map per Arnaud's request. (in imx_rproc.c) > - update the yaml per Frank's review comments. > > Changes in v2: > - re-implemented the gpio driver per Linus Walleij's feedback by using > GPIOLIB_IRQCHIP helper library. > - fix various format issue per Mathieu/Peng 's review comments. > - update the yaml doc per Rob's feedback > > Cc: Bartosz Golaszewski > Cc: Randy Dunlap > Cc: Andrew Lunn > Cc: Mathieu Poirier > Cc: Arnaud POULIQUEN > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org > > Shenwei Wang (5): > dt-bindings: remoteproc: imx_rproc: Add "rpmsg" subnode support > remoteproc: imx_rproc: Populate devices under "rpmsg" subnode > docs: staging: gpio-rpmsg: gpio over rpmsg bus > gpio: imx-rpmsg: add imx-rpmsg GPIO driver > arm64: dts: imx8ulp: Add rpmsg node under imx_rproc > > .../bindings/remoteproc/fsl,imx-rproc.yaml | 123 +++++ > Documentation/staging/gpio-rpmsg.rst | 202 ++++++++ > Documentation/staging/index.rst | 1 + > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 27 + > drivers/gpio/Kconfig | 17 + > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-imx-rpmsg.c | 475 ++++++++++++++++++ > drivers/remoteproc/imx_rproc.c | 146 ++++++ > include/linux/rpmsg/imx_rpmsg.h | 48 ++ > 9 files changed, 1040 insertions(+) I started reviewing this set. Given the size and amount of comments to go through, it will likely take me several days. I will tell you when I am done. Even at this early stage of review on my side, I can already confirm the only way to move forward with this set is by reaching a consensus that includes Andrew, Arneaud and Linus W. Thanks, Mathieu > create mode 100644 Documentation/staging/gpio-rpmsg.rst > create mode 100644 drivers/gpio/gpio-imx-rpmsg.c > create mode 100644 include/linux/rpmsg/imx_rpmsg.h > > -- > 2.43.0 >