From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B895398FB6; Thu, 4 Dec 2025 13:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855678; cv=none; b=HzmG34TCF/4wNx7rXqeTt0bHQEAR0ulsVmm9PuYNCw8UwQnhJUo5AXeWFkodV70YS1O4zpJpwyvdz0meV3K4Vty5C42M6gCG0ozIUaiUBeZTLYjXq5Ga2oSPRJeCKlzuBejlcM+4blfBB0UqcRxQyEPKnUypgePIHoJMJl1tNqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855678; c=relaxed/simple; bh=5vrRVcLYPFCpzhwyAw2L34Cd/fwmvirgk6ahEYjKQ3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pIMua5+bwoaPaqsVE4GPuDzDYkQ7/4aIshQ5txq8BchTc0hNwZu+udotVCshU7yKG72RaidL8e9x9QDBrURR4yiYgOJb5wQQ2snQwHhrynILCBpnVOrNppcq96N8LC3f9m/MYea6pqUkGaaNFMKkPPfKfltcgW/u9HntzUXOwRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iA42RosM; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iA42RosM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764855677; x=1796391677; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5vrRVcLYPFCpzhwyAw2L34Cd/fwmvirgk6ahEYjKQ3Y=; b=iA42RosM/IRGnCyWiVmbhNQ5nHSLRsIAmFMHcU47Q4ulifAYXAjiW824 guG5BEW2tMXYqAeMCfUuxDPNisnmvLLccJBow93N0+rqP3G/xrlC2TTAd WaRpMbgxXYHy809Pf3GgZC3pEyrYrEJTsepLheeqq+ICroPfjIY1I+DmL 0dSleuuRF19U8bf2lPwJ/+EIyrLcony9IxZFAgtTkViING9Rw3iTO1OHf SuLz3MyjrGvpFgUXh0nlSvpLnHsSTJvkb3+gkkMTkSFEUxaY5EBlh2Jjq UrvwlVJC7GYwIBgRcnbouJdY8JOzwo8FTZH0BfepMgwWUnmFqUD2IVBok g==; X-CSE-ConnectionGUID: Hs+JKHH0TQGHXTSFIhQuaw== X-CSE-MsgGUID: u8Ixy35aTwyNtHznpKCg2A== X-IronPort-AV: E=McAfee;i="6800,10657,11632"; a="77554961" X-IronPort-AV: E=Sophos;i="6.20,248,1758610800"; d="scan'208";a="77554961" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2025 05:41:16 -0800 X-CSE-ConnectionGUID: cEDuTO85SkOa/8dziq4Xxg== X-CSE-MsgGUID: B4wj07nmRam/YVp9CHTeNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,248,1758610800"; d="scan'208";a="194056172" Received: from rfrazer-mobl3.amr.corp.intel.com (HELO kuha) ([10.124.220.149]) by orviesa006.jf.intel.com with SMTP; 04 Dec 2025 05:41:05 -0800 Received: by kuha (sSMTP sendmail emulation); Thu, 04 Dec 2025 15:40:56 +0200 Date: Thu, 4 Dec 2025 15:40:56 +0200 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Peter Chen , Luca Ceresoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [RESEND PATCH v11 03/11] drm/bridge: Implement generic USB Type-C DP HPD bridge Message-ID: References: <20251204063109.104-1-kernel@airkyi.com> <20251204063109.104-4-kernel@airkyi.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204063109.104-4-kernel@airkyi.com> Hi, I don't know what's going on here - this series is the 12th? In any case, you need to fix this.. > diff --git a/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c > new file mode 100644 > index 000000000000..94be3d5f69e9 > --- /dev/null > +++ b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c > @@ -0,0 +1,51 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +#include > +#include > +#include > + > +#include > + > +static int drm_typec_bus_event(struct notifier_block *nb, > + unsigned long action, void *data) > +{ > + struct device *dev = (struct device *)data; > + struct typec_altmode *alt = to_typec_altmode(dev); > + > + if (action != BUS_NOTIFY_ADD_DEVICE) > + goto done; > + > + if (is_typec_partner_altmode(&alt->dev) || alt->svid != USB_TYPEC_DP_SID) > + goto done; That's still not enough because of the plug altmodes. You need to check that it's a port altmode: if (is_typec_port_altmode(&alt->dev) && alt->svid == USB_TYPEC_DP_SID) drm_dp_hpd_bridge_register(alt->dev.parent->parent, to_of_node(alt->dev.parent->fwnode)); > + /* > + * alt->dev.parent->parent : USB-C controller device > + * alt->dev.parent : USB-C connector device > + */ > + drm_dp_hpd_bridge_register(alt->dev.parent->parent, > + to_of_node(alt->dev.parent->fwnode)); > + > +done: > + return NOTIFY_OK; > +} > + > +static struct notifier_block drm_typec_event_nb = { > + .notifier_call = drm_typec_bus_event, > +}; > + > +static void drm_aux_hpd_typec_dp_bridge_module_exit(void) > +{ > + bus_unregister_notifier(&typec_bus, &drm_typec_event_nb); > +} > + > +static int __init drm_aux_hpd_typec_dp_bridge_module_init(void) > +{ > + bus_register_notifier(&typec_bus, &drm_typec_event_nb); > + > + return 0; > +} > + > +module_init(drm_aux_hpd_typec_dp_bridge_module_init); > +module_exit(drm_aux_hpd_typec_dp_bridge_module_exit); > + > +MODULE_DESCRIPTION("DRM TYPEC DP HPD BRIDGE"); > +MODULE_LICENSE("GPL"); thanks, -- heikki