From: Rain Yang <jiyu.yang@oss.nxp.com>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: Frank.li@nxp.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
imx@lists.linux.dev, jiyu.yang@oss.nxp.com,
kernel@pengutronix.de, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com,
robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH] arm64: dts: imx95: Use GPU_CGC as core clock for GPU
Date: Fri, 5 Dec 2025 16:17:52 +0800 [thread overview]
Message-ID: <aTKVMAMQ6v_BwD6R@oss.nxp.com> (raw)
In-Reply-To: <5944d872-01a3-47e9-977b-029f3be4fd83@mailbox.org>
On Thu, Dec 04, 2025 at 04:25:38AM +0100, Marek Vasut wrote:
>On 12/4/25 4:01 AM, Rain Yang wrote:
>
>[...]
>> > > For the Linux working environment,
>> > > CLK_GPU and CLK_GPUAPB are always-on, while CLK_GPU_CGC can be gated off.
>> > >
>> > > Regarding the IMX95_CLK_GPUAPB handle, my suggestion was based on the absence
>> > > of its frequency in any OPP entry within the frequency table. Removing it
>> > > could simplify the OPP handling logic and reduce unnecessary complexity.
>> >
>> > If the clock can be disabled by SM, Linux has to make sure they are NOT
>> > disabled, so they must be described in DT, right ?
>> >
>> > > [1] https://github.com/nxp-imx/linux-imx/commit/695f2bdc57b869ca5189313e4b5fa7eb5a12f622
>> Currently, only CLK_GPU_CGC shall be described in the Device Tree[1], as it can be gated.
>> The other clocks (CLK_GPU and CLK_GPUAPB) are always-on in the Linux environment,
>> so describing any of them in DT is not necessary and would not be proper in this context.
>
>Since this discussion is in fact unrelated to this bugfix, I would propose to
>fork the discussion into a separate patch. Can you please submit a patch for
>the GPUAPB clock ? Note that I believe GPUAPB clock have to be described in
>DT, if only because DT is a hardware description, and to make sure the GPUAPB
>clock are correctly enabled by the driver.
Okay, I’ll submit a patch later.
The commit message should reflect that only CLK_GPU_CGC is enabled.
next prev parent reply other threads:[~2025-12-05 8:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 14:31 [PATCH] arm64: dts: imx95: Use GPU_CGC as core clock for GPU Marek Vasut
2025-12-03 2:48 ` Rain Yang
2025-12-03 3:38 ` Marek Vasut
2025-12-03 9:28 ` Rain Yang
2025-12-03 22:48 ` Marek Vasut
2025-12-04 3:01 ` Rain Yang
2025-12-04 3:25 ` Marek Vasut
2025-12-05 8:17 ` Rain Yang [this message]
2025-12-07 9:01 ` Marek Vasut
2025-12-08 2:02 ` Rain Yang
2025-12-30 1:53 ` Marek Vasut
2025-12-30 2:53 ` Rain Yang
2025-12-30 14:17 ` Marek Vasut
2025-12-31 3:06 ` Rain Yang
2025-12-31 14:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTKVMAMQ6v_BwD6R@oss.nxp.com \
--to=jiyu.yang@oss.nxp.com \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marek.vasut@mailbox.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).